[rocprof-compute] Generalize Roofline by jamessiddeley-amd · Pull Request #325 · ROCm/rocm-systems

jamessiddeley-amd · 2025-08-12T22:58:47Z

Motivation

This PR extracts the roofline equation out of python code in roofline_calc.py to one section in YAML config, in which can be easily configured for each arch.

These YAMLS are per-kernel roofline analysis, allowing users to analyze individual kernel performance characteristics for roofline methodology using equations from a single-source of truth YAML (0400_roofline.yaml).

Technical Details

Added roofline YAML configuration (0400_roofline.yaml) defining metrics based directly off of AI_Data object python equations in calc_ai() to unified_configs.yaml for gfx90a, gfx908, gfx940, gfx941, gfx942, and gfx950.
Refactored calc_ai() to calc_ai_profile() which carries over the same legacy hardcoded calculations for profiling use (before analysis configs are available)
Modified calc_ai() in roofline_calc.py to calc_ai_analyze() to process individual kernels rather by calling eval_metric() on each kernel.
Added roofline.csv as an analysis runtime dependancy to read and display respective empirical peaks for roofline metrics
Updated analysis_cli.py to generate per-kernel roofline plots and display kernel-specific metrics in the CLI output
Modified cli_generate_plot to display plot points calculated from calc_ai_analyze()
Enhanced tty.py show_all() function to display per-kernel roofline metrics with cli_style = "Roofline" in organized sections (4.1 Roofline Rate Metrics, 4.2 AI Plot Points) (screenshots in ticket)
Added web Gui integration (screenshots in ticket)
Updated docs
Complete TUI integration will be moved to a later implementation.## Test Plan

Pass 100% on local testing suite

Test Result

Local ctest pass 16/16

Submission Checklist

Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.

…sers/jamessiddeley-amd/generalize-roofline

xuchen-amd

Thank you for getting this in, the individual kernel metrics and plot output looks great!
Left some comments for potential improvements.
Please update roofline docs and consider to have the docs in a separate PR for Pratik to review.

…sers/jamessiddeley-amd/generalize-roofline

feizheng10

LGTM.
BTW, we never really support/verify roofline on MI100...@carrie please help to check

…sers/jamessiddeley-amd/generalize-roofline

vedithal-amd

Left minor comments

…325)

…325) [ROCm/clr commit: a46ed60]

…325)

…how counters being profiled in metadata. (#325) * expose dimensional info in rocprofiler_counter_info_v1_t. * add counter_id in dim info. * address review comments * format. * address comments. * use array of pointers for dimensions_instaces. * format and comments. * address comments. * new line. * Update counter_defs.yaml * Update counter_defs.yaml * Update counter_defs.yaml * counter_defs. * format counter defs. * format counter defs. * format counter defs. * show only counters being profiled in metadata. * Format. * use config for counters and fix warnings. * add version for rocprofiler_counter_dimension_info_v1_t struct. * rename rocprofiler_counter_record_dimension_instance_v1_info_t. * account device id from pmc for counters metadata. * move dim structs to counters.h. * address comments to compare value. * fix tests. * Address comments. use pointer of arrays for ABI. * rebase. * fix build error. * use separate metadata::init() for rocprofv3. * also print not found counters. * precompute all the perf counters needed to be in metadata. * Misc. * format * Format. * rocprofiler::sdk::container::c_array * Address comments. * source/lib/output/metadata.cpp * lint. * add unit test for c_array. * add unit test and serialization support for c_array container. * Misc. * Clean files. * Format. * clang-tidy. * add more checks to c_array. * misc. typo * Addr comments. --------- Co-authored-by: Venkateshwar Reddy Kandula <vkandula@amd.com> Co-authored-by: Jonathan R. Madsen <Jonathan.Madsen@amd.com> [ROCm/rocprofiler-sdk commit: bf0fad1]

rahulc-gh · 2025-08-19T19:14:48Z

/AzurePipelines run rocm-ci-caller

azure-pipelines · 2025-08-19T19:14:57Z

Azure Pipelines successfully started running 1 pipeline(s).

* per kernel analysis Roofline * added per-kernel eval_metric calculation with display * fixed typo * updated tty.py show_all() * formatting * fixed ctest failures and updated equations * formatting * updated metric descriptoins * review tweaks * update docs * added roofline gui analysis * updated GUI docs * updated print statement * comment tweaks and ran ruff formatting [rocm-systems] ROCm/rocm-systems#325 (commit 5840940)

* per kernel analysis Roofline * added per-kernel eval_metric calculation with display * fixed typo * updated tty.py show_all() * formatting * fixed ctest failures and updated equations * formatting * updated metric descriptoins * review tweaks * update docs * added roofline gui analysis * updated GUI docs * updated print statement * comment tweaks and ran ruff formatting

vedithal-amd · 2025-08-21T14:31:52Z

+            t_df = OrderedDict()
+            t_df["pmc_perf"] = pd.read_csv(pmc_perf_csv)
+
+            self.__ai_data = calc_ai_profile(


Seems like we missed handling rocpd processing dataframe here

Change-Id: Ide3563a876cb530d0e80676e78f36f18a233a3ba Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>

Change-Id: Ide3563a876cb530d0e80676e78f36f18a233a3ba Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com> [ROCm/amdsmi commit: bd82e88]

jamessiddeley-amd added 11 commits August 8, 2025 16:29

per kernel analysis Roofline

10d7b26

added per-kernel eval_metric calculation with display

d90c548

merged develop and fixed conflicts

1cc2720

fixed typo

a879d9a

updated tty.py show_all()

e163661

formatting

5138ae8

fixed ctest failures and updated equations

ec91206

formatting

4bdc6cd

Merge branch 'develop' of https://github.com/ROCm/rocm-systems into u…

9dc23ec

…sers/jamessiddeley-amd/generalize-roofline

Merge branch 'develop' of https://github.com/ROCm/rocm-systems into u…

055a823

…sers/jamessiddeley-amd/generalize-roofline

updated metric descriptoins

7b049a4

github-actions Bot added the project: rocprofiler-compute label Aug 12, 2025

systems-assistant Bot added the organization: ROCm label Aug 12, 2025

jamessiddeley-amd added 3 commits August 12, 2025 18:03

Merge branch 'develop' of https://github.com/ROCm/rocm-systems into u…

7facb7f

…sers/jamessiddeley-amd/generalize-roofline

Merge branch 'develop' of https://github.com/ROCm/rocm-systems into u…

4461434

…sers/jamessiddeley-amd/generalize-roofline

Merge branch 'develop' of https://github.com/ROCm/rocm-systems into u…

6b9fda0

…sers/jamessiddeley-amd/generalize-roofline

xuchen-amd reviewed Aug 13, 2025

View reviewed changes

jamessiddeley-amd added 2 commits August 13, 2025 13:31

review tweaks

f83f20f

Merge branch 'develop' of https://github.com/ROCm/rocm-systems into u…

a170160

…sers/jamessiddeley-amd/generalize-roofline

jamessiddeley-amd mentioned this pull request Aug 14, 2025

Improve roofline documentation #180

Closed

update docs

a628f50

github-actions Bot added the documentation Improvements or additions to documentation label Aug 14, 2025

jamessiddeley-amd added 2 commits August 15, 2025 13:38

Merge branch 'develop' of https://github.com/ROCm/rocm-systems into u…

94d680b

…sers/jamessiddeley-amd/generalize-roofline

added roofline gui analysis

84e9977

jamessiddeley-amd marked this pull request as ready for review August 15, 2025 18:55

jamessiddeley-amd requested review from cfallows-amd, coleramos425, feizheng10, vedithal-amd and ywang103-amd as code owners August 15, 2025 18:55

jamessiddeley-amd requested a review from xuchen-amd August 15, 2025 18:55

updated GUI docs

5617226

feizheng10 approved these changes Aug 16, 2025

View reviewed changes

jamessiddeley-amd added 2 commits August 18, 2025 09:06

Merge branch 'develop' of https://github.com/ROCm/rocm-systems into u…

a28bea4

…sers/jamessiddeley-amd/generalize-roofline

updated print statement

3c7560f

vedithal-amd mentioned this pull request Aug 18, 2025

Add analysis db mode #236

Closed

vedithal-amd approved these changes Aug 18, 2025

View reviewed changes

Comment thread projects/rocprofiler-compute/src/rocprof_compute_analyze/analysis_base.py Resolved

Comment thread projects/rocprofiler-compute/src/utils/file_io.py Resolved

Comment thread projects/rocprofiler-compute/src/utils/roofline_calc.py Resolved

cfallows-amd pushed a commit that referenced this pull request Aug 18, 2025

SWDEV-508970 - Match hipBindTextureToArray negative return with Cuda (#…

a46ed60

…325)

jamessiddeley-amd added 2 commits August 18, 2025 14:34

comment tweaks and ran ruff formatting

ef66f08

Merge branch 'develop' into users/jamessiddeley-amd/generalize-roofline

42884b2

jayhawk-commits pushed a commit that referenced this pull request Aug 18, 2025

SWDEV-508970 - Match hipBindTextureToArray negative return with Cuda (#…

10d97b4

…325) [ROCm/clr commit: a46ed60]

systems-assistant Bot pushed a commit that referenced this pull request Aug 18, 2025

SWDEV-491258 - [catch2][dtest] Stream Capture tests for Stream API's (#…

d394102

…325)

Merge branch 'develop' into users/jamessiddeley-amd/generalize-roofline

3b3e8e0

jamessiddeley-amd requested a review from feizheng10 August 19, 2025 17:09

Merge branch 'develop' into users/jamessiddeley-amd/generalize-roofline

766dfaa

feizheng10 approved these changes Aug 19, 2025

View reviewed changes

jamessiddeley-amd merged commit 5840940 into develop Aug 20, 2025

jamessiddeley-amd deleted the users/jamessiddeley-amd/generalize-roofline branch August 20, 2025 13:58

vedithal-amd reviewed Aug 21, 2025

View reviewed changes

xuchen-amd added a commit that referenced this pull request Aug 21, 2025

Refactor TUI and adjust logic based on #325.

559b7e6

xuchen-amd mentioned this pull request Aug 21, 2025

[rocprofiler-compute][TUI] Updates and refactor. #703

Merged

1 task done

ammallya pushed a commit that referenced this pull request Nov 17, 2025

[SWDEV-529762] CMAKE - Fix lintian issues (#325)

bd82e88

Change-Id: Ide3563a876cb530d0e80676e78f36f18a233a3ba Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>

ammallya pushed a commit that referenced this pull request Nov 18, 2025

[SWDEV-529762] CMAKE - Fix lintian issues (#325)

5108838

Change-Id: Ide3563a876cb530d0e80676e78f36f18a233a3ba Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com> [ROCm/amdsmi commit: bd82e88]

ammallya pushed a commit that referenced this pull request Nov 21, 2025

[SWDEV-529762] CMAKE - Fix lintian issues (#325)

f720ce6

Change-Id: Ide3563a876cb530d0e80676e78f36f18a233a3ba Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com> [ROCm/amdsmi commit: bd82e88]

Navigation Menu

Repository navigation

[rocprof-compute] Generalize Roofline - #325

[rocprof-compute] Generalize Roofline#325
jamessiddeley-amd merged 26 commits into
developfrom
users/jamessiddeley-amd/generalize-roofline

jamessiddeley-amd commented Aug 12, 2025 •

edited

Loading

Uh oh!

xuchen-amd left a comment •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

feizheng10 left a comment

Uh oh!

vedithal-amd left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rahulc-gh commented Aug 19, 2025

Uh oh!

azure-pipelines Bot commented Aug 19, 2025

Uh oh!

vedithal-amd Aug 21, 2025

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

jamessiddeley-amd commented Aug 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation

Technical Details

Test Result

Submission Checklist

Uh oh!

xuchen-amd left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

feizheng10 left a comment

Choose a reason for hiding this comment

Uh oh!

vedithal-amd left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rahulc-gh commented Aug 19, 2025

Uh oh!

azure-pipelines Bot commented Aug 19, 2025

Uh oh!

vedithal-amd Aug 21, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

jamessiddeley-amd commented Aug 12, 2025 •

edited

Loading

xuchen-amd left a comment •

edited

Loading