Repository navigation
Add analysis db mode - #236
vedithal-amd wants to merge 4 commits into
Conversation
* Documentation updates * formatting * Update using-rocprofv3.rst * Update counter_collection_services.md --------- Co-authored-by: srawat <120587655+SwRaw@users.noreply.github.com> [ROCm/rocprofiler-sdk commit: 31b8f61]
[ROCm/rocprofiler-systems commit: 92b636a]
0f22531 to
1d29c3e
Compare
There was a problem hiding this comment.
It seems to me duplicated somewhere else, is it?
There was a problem hiding this comment.
It is debatable for me, "db" is a end-user level analysis mode. It more likes on the same level of "--save-dfs". Thought?
There was a problem hiding this comment.
I would like to skip analysis report generation and only focus on creating database. That is why I am not using CLI mode with --save-dfs option. Remember, its not only about saving metrics dfs. We also need to think about roofline, pc sampling information storage in database.
For the end user, they can still do both analyze --save-dfs and analyze --db <db_name>, so we are keeping it flexible.
feizheng10
left a comment
There was a problem hiding this comment.
Some general comments:
- Before removing the Grafana solution with Mongo DB. To reduce the confusion for the end users, we might want to explicitly claim there is no relationship for those 2 in the doc.
- As a general design, or user view, db output and df csv output are just alternatives to save the output as user's choice, they are just data storage, not analysis mode.
There was a problem hiding this comment.
I'd apologize here: we should have the doc for "--save-dfs" early.
Since you adding "data-dump" section here, I'd say we might want to include description for both db and csv format. And even more, the option could be in more unified fashion: --output [txt/csv/db]
There was a problem hiding this comment.
Agreed we should replace -o, --save-dfs, --db analysis report options with ``--output txt/csv/db`. I will make this change and also update documentation.
* Add `--db` option to analyze mode which creates database file containiing analysis result * Add documentation on `rocpd` output format and analysis database file * Create sqlite3 database using object relation mapping (ORM) provided by sqlalchemy library * Fix metrics config to remove metrics marked as `null`, fix `Unit` header, add missing `title` * Add test cases to ensure analysis data dump works * Update CHANGELOG
1d29c3e to
1dba3ef
Compare
I would like to have the analysis database results calculation in a separate file like
|
|
I will move roofline data point calculation logic inside another function in roofline_calc.py and use that in analysis_db.py |
That is precisely why i am using |
|
This PR will need dev efforts and re-testing due to #325. Calculation of roofline metrics should use the analysis config expressions, instead of hardcoded expressions. |
| pymongo | ||
| pyyaml | ||
| setuptools | ||
| sqlalchemy==2.0.42 |
There was a problem hiding this comment.
Does this need to be exactly this version? Can we do >= or <=? It is already not latest release
There was a problem hiding this comment.
Good idea, will covert to >=, we don't want to be stuck using an outdated version
|
Closing against #748 |
[ROCm/rocshmem commit: b3e2e72]
Creates a C API that wraps StatsClient and updates ais-stats to use the new API
Creates a C API that wraps StatsClient and updates ais-stats to use the new API [ROCm/hipFile commit: 9e431f9]
Analysis data dump
Add
--dboption to analyze mode which creates database filecontainiing analysis result
Add documentation on
rocpdoutput format and analysis database fileCreate sqlite3 database using object relation mapping (ORM) provided
by sqlalchemy library
Fix metrics config to remove metrics marked as
null, fixUnitheader, addmissing
titleAdd test cases to ensure analysis data dump works
Update CHANGELOG