[rocprof-sys] Fix Python Formatting by dgaliffiAMD · Pull Request #2679 · ROCm/rocm-systems

dgaliffiAMD · 2026-01-19T16:58:41Z

Motivation

Updated version of black to 26.1.0 updated some formatting rules

Technical Details

Ran black on the "rocprofiler-systems" folder.

JIRA ID

n/a

Test Plan

Test Result

Submission Checklist

Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.

Updated version of black to 26.1.0 updated some formatting rules Signed-off-by: David Galiffi <David.Galiffi@amd.com>

Copilot

Pull request overview

This PR updates Python code formatting to comply with black version 26.1.0, which introduced new formatting rules. The changes are purely cosmetic whitespace adjustments with no functional modifications.

Changes:

Reformatted multi-line f-string to single-line format
Removed extraneous blank lines between imports and code

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
projects/rocprofiler-systems/tests/validate-rocpd.py	Consolidated multi-line print statement with f-string into single line
projects/rocprofiler-systems/tests/validate-causal-json.py	Removed extra blank line after imports
projects/rocprofiler-systems/source/python/rocprofsys/user.py	Removed extra blank line after imports
projects/rocprofiler-systems/source/python/rocprofsys/common.py	Removed extra blank line after imports
projects/rocprofiler-systems/source/python/gui/source/gui.py	Removed extra blank line after imports

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Updated version of black to 26.1.0 updated some formatting rules Signed-off-by: David Galiffi <David.Galiffi@amd.com> [rocm-systems] ROCm/rocm-systems#2679 (commit c83b3aa)

…nal-merge-new-729 (#459) * SWDEV-549518 - Enable logging dynamically through HIP APIS. (#1079) * SWDEV-549518 - Enable logging dynamically through HIP APIS. * SWDEV-549518 - Adding ROCProfiler related new API changes. * rocprofiler-sdk changes for hip api additions. --------- Co-authored-by: Venkateshwar Reddy Kandula <venkateshwar.kandula1306@gmail.com> Co-authored-by: jainprad <92369414+jainprad@users.noreply.github.com> * [rocprof-compute] Pin ruff version for consistent formatting (#2680) * pin ruff versions each to current latest * Update rocprofiler-compute-formatting.yml * Downgrade .pre-commit-config.yaml to match develop * Fix Python Formatting (#2679) Updated version of black to 26.1.0 updated some formatting rules Signed-off-by: David Galiffi <David.Galiffi@amd.com> * Add automatic PyTorch library discovery for Python applications (#2623) * Add automatic PyTorch library discovery for Python applications (#2623) * Add notice for the newly deprecated env variables (#2690) * [rocprofiler-compute] Use TheRock nightly builds in testing container (#2661) * Use TheRock nightly builds in testing container * Add HIP_DEVICE_LIB_PATH env var for hipcc to work * Add HIP_PLATFORM env var for cmake hip package * Add tarball placeholder * Add -f to curl command to fail on HTTP error * [rocprofiler-compute] Fix kernel/dispatch filtering (#2479) * Fix kernel/dispatch fitlering in GUI * Disallow --kernel and --dispatch filtering in analyze --gui mode since GUI frontend offers dropdown menu for kernel and dispatch filtering * Update CHANGELOG and documentation * Gracefully handle N/A values * Ensure workload path is valid before using it in GUI * Ignore kernel filters if dispatch filters provided * Add documentation for dispatch filtering overriding kernel filtering * Fix typo * Fix documentation * remove unnecessary whitespace * Address review comments * Allow kernel/dispatch filtering with --gui * Address review comments * Address review comments * Update CHANGELOG * Fix formatting * [rocprofiler-systems] Add build option for "examples" to specify gfx-arch (#2626) ## Motivation - Added `check_rocminfo` function that returns true if the provided regex was found, false otherwise. Can also use `GET_OUTPUT` to get the raw output filtered with or without a regex. - Moved `rocprofiler_systems_get_gfx_archs()` to `MacroUtilities.cmake` - Added `rocprofiler_systems_lookup_gfx()`, which detects whether a given `gfx` is from the `instinct`, `radeon` or `apu` family. - Added `ROCPROFSYS_GFX_TARGETS` as a build argument. Used to specify the offloading architectures that GPU examples should compile for. If empty, defaults to whatever your system has. - GPU examples now check if the given `gfx` targets (from `ROCPROFSYS_GFX_TARGETS`) are supported. - OMPVV offload tests now only compile if `amdflang` version is `>= 20` - Improve link time by reducing the number of GFX targets that binaries need to support. - RCCL is now passed a `GPU_TARGETS` var specifying the architectures to build/link against. * Reset HIP_VERSION_PATCH to 0 (#2590) * [SWDEV-559965] Update Changelog for power cap type (#2647) * [SWDEV-559965] Update Changelog for amd-smi set --power-cap Updated Changelog to mention flexible argument ordering for power cap type in amdsmi power cap set. Corrected Changelog documentation on PPT1 reset power_cap command. Signed-off-by: Bindhiya Kanangot Balakrishnan <Bindhiya.KanangotBalakrishnan@amd.com> Signed-off-by: Maisam Arif <Maisam.Arif@amd.com> Co-authored-by: Maisam Arif <Maisam.Arif@amd.com> * [rocprofiler-system]: Enable UCX Communication API tracing (#2306) ## Motivation Enable UCX communication tracing and communication metadata ## Technical Details Implement UCX API wrappers to trace transport-layer communication. This adds communication data tracking and exposes “UCX Comm Send/Recv” timelines, enabling detailed analysis of MPI, OpenSHMEM, and other UCX-based runtime communication patterns. - Implements function interception for UCX functions across multiple categories using gotcha component. - Extended comm_data component to track UCX send/recv operations - Added ucx_send and ucx_recv labels for Perfetto counter tracks. Integrated UCX data tracking with existing MPI/RCCL tracking infrastructure. - Added ROCPROFSYS_USE_UCX configuration option (enabled by default). - Created FindUCX.cmake module for UCX header detection. Falls back to internal UCX headers if system headers not found. - Updated all Dockerfiles to include UCX dependencies. * hip-issue-3876 : Take into account thread-local capture mode in checks for valid capture (#2177) * Revert "rocr: Switch back to legacy IPC (#1744)" (#2676) This reverts commit 7e4b622. * SWDEV-558849 - Add support for static linking with ROCR (#2659) * [rocprofiler-systems] Fix MPI recv_data calculation (#2694) Fix incorrect `mpi_recv` calculation. It was using `_send_size` instead of `_recv_size` for `mpi_recv`. * [ROCmInfo] docs: mono-repo changes and style edits (#2584) * initial edits * mono repo related updates * standardize component name * style edits * more edits * Update CODEOWNERS (#2705): add /project/amdsmi owner * Use size_t datatype for global dimensions. (#2604) * rocrtst: set HSA_ENABLE_INTERRUPT after TestExample creation (#2687) Signed-off-by: Horatio Zhang <Hongkun.Zhang@amd.com> Co-authored-by: cfreeamd <166262151+cfreeamd@users.noreply.github.com> * Rework clock based unit tests (#2646) * Update hip_api_trace.cpp for HIP_RUNTIME_API_TABLE_STEP_VERSION 22 * Update hip_api_trace.hpp for HIP_RUNTIME_API_TABLE_STEP_VERSION 22 --------- Signed-off-by: David Galiffi <David.Galiffi@amd.com> Signed-off-by: Bindhiya Kanangot Balakrishnan <Bindhiya.KanangotBalakrishnan@amd.com> Signed-off-by: Maisam Arif <Maisam.Arif@amd.com> Signed-off-by: Horatio Zhang <Hongkun.Zhang@amd.com> Co-authored-by: Karthik Jayaprakash <54370791+kjayapra-amd@users.noreply.github.com> Co-authored-by: Venkateshwar Reddy Kandula <venkateshwar.kandula1306@gmail.com> Co-authored-by: jainprad <92369414+jainprad@users.noreply.github.com> Co-authored-by: jamessiddeley-amd <James.Siddeley@amd.com> Co-authored-by: David Galiffi <David.Galiffi@amd.com> Co-authored-by: Milan Radosavljevic <milan.radosavljevic@amd.com> Co-authored-by: marantic-amd <marantic@amd.com> Co-authored-by: vedithal-amd <Vignesh.Edithal@amd.com> Co-authored-by: Kian Cossettini <Kian.Cossettini@amd.com> Co-authored-by: Rakesh Roy <137397847+rakesroy@users.noreply.github.com> Co-authored-by: Bindhiya Kanangot Balakrishnan <Bindhiya.KanangotBalakrishnan@amd.com> Co-authored-by: Maisam Arif <Maisam.Arif@amd.com> Co-authored-by: Sajina PK <sputhala@amd.com> Co-authored-by: Ioannis Assiouras <38722728+iassiour@users.noreply.github.com> Co-authored-by: Alysa Liu <Alysa.Liu@amd.com> Co-authored-by: German Andryeyev <56892148+gandryey@users.noreply.github.com> Co-authored-by: yugang-amd <yugang.wang@amd.com> Co-authored-by: JeniferC99 <150404595+JeniferC99@users.noreply.github.com> Co-authored-by: hongkzha-amd <Hongkun.Zhang@amd.com> Co-authored-by: cfreeamd <166262151+cfreeamd@users.noreply.github.com> Co-authored-by: Jatin Chaudhary <51944368+cjatin@users.noreply.github.com> Co-authored-by: kjayapra-amd <karthik.jayaprakash@amd.com> Co-authored-by: hsivasun_amdeng <haresh.sivasuntharampillai@amd.com> Co-authored-by: Kandula, Venkateshwar reddy <Venkateshwarreddy.Kandula@amd.com>

Fix Python Formatting

10c2598

Updated version of black to 26.1.0 updated some formatting rules Signed-off-by: David Galiffi <David.Galiffi@amd.com>

dgaliffiAMD requested review from a team and jrmadsen as code owners January 19, 2026 16:58

Copilot AI review requested due to automatic review settings January 19, 2026 16:58

Copilot AI reviewed Jan 19, 2026

View reviewed changes

dgaliffiAMD requested a review from sputhala-amd January 19, 2026 16:59

github-actions Bot added the project: rocprofiler-systems label Jan 19, 2026

systems-assistant Bot added the organization: ROCm label Jan 19, 2026

ajanicijamd approved these changes Jan 19, 2026

View reviewed changes

dgaliffiAMD merged commit c83b3aa into develop Jan 20, 2026
64 of 66 checks passed

dgaliffiAMD deleted the users/dgaliffi/format-fix-python branch January 20, 2026 02:26

charis-poag-amd mentioned this pull request Jan 20, 2026

[SWDEV-552020/SWDEV-563971] Fail memory partition tests if ASIC supports memory partitions & kmod not installed #2695

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[rocprof-sys] Fix Python Formatting#2679

[rocprof-sys] Fix Python Formatting#2679
dgaliffiAMD merged 1 commit into
developfrom
users/dgaliffi/format-fix-python

dgaliffiAMD commented Jan 19, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

dgaliffiAMD commented Jan 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation

Technical Details

JIRA ID

Test Plan

Test Result

Submission Checklist

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

dgaliffiAMD commented Jan 19, 2026 •

edited

Loading