Skip to content

[rocjitsu] Assert the instrumentor architecture invariant #14404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
IanWood1 merged 2 commits into from
Oct 28, 2026
+8 −3
Merged

[rocjitsu] Assert the instrumentor architecture invariant #14404

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
655f800
[rocjitsu] Assert admitted instrumentor architectures
IanWood1 Oct 27, 2026
2a7f3cc
[rocjitsu] Make instrumentor allocation switch exhaustive
IanWood1 Oct 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions emulation/rocjitsu/lib/rocjitsu/src/rocjitsu/code/patch/instrumentor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,11 @@
#include "rocjitsu/isa/decoder.h"
#include "rocjitsu/isa/instruction.h"
#include "rocjitsu/isa/target_registry.h"
#include "util/except.h"
#include "util/diagnostic.h"

#include <algorithm>
#include <array>
#include <cassert>
#include <cstring>
#include <optional>
#include <span>
Expand Down Expand Up @@ -179,9 +180,13 @@ bool arch_has_unified_vgpr_allocation(rj_code_arch_t arch) {
case ROCJITSU_CODE_ARCH_RDNA4:
case ROCJITSU_CODE_ARCH_CDNA5:
return false;
default:
throw util::UnimplementedInst("unified VGPR allocation for target architecture");
case ROCJITSU_CODE_ARCH_RV32I:
case ROCJITSU_CODE_ARCH_RV64I:
case ROCJITSU_CODE_ARCH_INVALID:
break;
}
assert(false && "unified VGPR allocation for an unadmitted architecture");
return false;
}

// How one kernel's VGPR allocation divides into an ordinary prefix and an
Expand Down
Loading