Repository navigation
[rocjitsu] Assert the instrumentor architecture invariant - #14404
Merged
IanWood1 merged 2 commits intoOct 28, 2026
Merged
Conversation
Signed-off-by: Ian Wood <ianwood@u.northwestern.edu>
✅ All Checks Passed — Ready for Review
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🎉 All checks passed! This PR is ready for review. |
accauble
approved these changes
Oct 28, 2026
kuhar
reviewed
Oct 28, 2026
Signed-off-by: Ian Wood <ianwood@u.northwestern.edu>
Contributor
rocjitsu post-commit fuzz passedThe 32-worker multiplexer campaigns for commit
|
Contributor
TheRock Submodule Bump ActivityNewest first
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Remove the unreachable architecture exception from the instrumentor’s VGPR allocation helper.
Technical Details
Replace the throw with an assertion after an exhaustive architecture switch. Explicitly handle unsupported enum values so adding an architecture requires an allocation-model decision through compiler switch diagnostics. Patch admission still rejects unsupported inputs through the existing result.
Existing instrumentor, spill, and target-registry tests pass. No new tests are added; runtime assertion firing is not tested in the RelWithDebInfo build.
Issue Tracking
Part of #10239.