Repository navigation
feat(rocSHMEM): audit rocSHMEM hand-written GCN assembly for XNACK-Replay compliance, #AIROCSHMEM-533 - #13747
Merged
Conversation
✅ All Policy Checks Passed
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The replay-wait guard excludes gfx1250-strict, leaving its inline stores vulnerable to premature source-register reuse.
1 open issue
What changed in this PR
Updates rocSHMEM’s hand-written GPU assembly to address XNACK replay hazards.
Changes:
- Adds gfx1250 translation waits and early-clobber load constraints.
- Replaces flat memory instructions with global instructions and renames the corresponding cache policy.
- Adjusts buffer descriptors for gfx1250 variants.
| File | Description |
|---|---|
| projects/rocshmem/src/assembly.hpp | Updates memory instructions, register constraints, replay waits, and buffer descriptors. |
Review effort: Balanced
abouteiller
reviewed
Oct 23, 2026
amirsojoodi
force-pushed
the
users/asojoodi/rocshmem-fix-xnack-replay
branch
from
October 23, 2026 20:17
ba0f39c to
79c268d
Compare
abouteiller
approved these changes
Oct 23, 2026
abouteiller
left a comment
abouteiller
left a comment
Contributor
There was a problem hiding this comment.
cosmetic indent issue, no need to rereview after done
amirsojoodi
force-pushed
the
users/asojoodi/rocshmem-fix-xnack-replay
branch
from
October 23, 2026 23:13
79c268d to
34419f4
Compare
Contributor
TheRock Submodule Bump ActivityNewest first
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Compiler-generated code handles the required hazard avoidance automatically, but for hand-written inline assembly the programmer is responsible to follow the XNACK-Replay rules (group semantics, not clobbering source registers of in-flight VMEM/SMEM translations, correct wait instructions, mode-specific hazards for single- vs multi-group REPLAY_MODE).
Details
Issue Tracking
JIRA ID: AIROCSHMEM-533