Repository navigation
feat(rocSHMEM): Replace flat instructions with their global counterparts, #AIROCSHMEM-506 - #13490
Merged
Merged
Conversation
✅ All Policy Checks Passed
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Cross-architecture GPU assembly changes require target-GPU CI validation and final human review.
0 open findings
What changed in this PR
Updates rocSHMEM’s IPC memory-access assembly to use global instructions while preserving plain load/store operations on the local side.
Changes:
- Replaces flat load/store instructions with global counterparts across architecture-specific implementations.
- Renames
FlatCachetoGlobalCache. - Documents global-address requirements without changing copy-policy selection.
| File | Description |
|---|---|
| projects/rocshmem/src/util.hpp | Adds address-requirement comments and adjusts formatting; behavior is unchanged. |
| projects/rocshmem/src/assembly.hpp | Converts assembly instructions, renames the cache policy, and documents address requirements. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
abouteiller
approved these changes
Oct 23, 2026
amirsojoodi
added a commit
that referenced
this pull request
Oct 26, 2026
…play compliance, #AIROCSHMEM-533 (#13747) ## Motivation Compiler-generated code handles the required hazard avoidance automatically, but for hand-written inline assembly the programmer is responsible to follow the XNACK-Replay rules (group semantics, not clobbering source registers of in-flight VMEM/SMEM translations, correct wait instructions, mode-specific hazards for single- vs multi-group REPLAY_MODE). ## Details - Supposed to be merged on top of #13490 ## Issue Tracking JIRA ID: AIROCSHMEM-533
Contributor
TheRock Submodule Bump ActivityNewest first
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Enable IPC backend to move to global instructions from flat ones.
Technical Details
memcpy_lane's existing CachePolicy assignment already putsStandard(a plain load/store, not AsmAccess asm) on whichever side of a transfer is local and the asm-backed policy only on the genuinely global remote side, so the flat -> global revert doesn't require bypassing it for scalars.Issue Tracking
JIRA ID: AIROCSHMEM-506
Test Plan
CI should be green on Functional and Unit tests.