Skip to content

[rocjitsu] Pair mixed-format WMMA operands by K coordinate - #13122

Merged
kuhar merged 1 commit into
developfrom
users/kuhar/corpus-wmma-pairing
Oct 9, 2026
Merged

kuhar merged 1 commit into
developfrom
users/kuhar/corpus-wmma-pairing

Conversation

@kuhar

@kuhar kuhar commented Oct 8, 2026 •

Copy link
Copy Markdown
Member

Use contiguous K groups for the sub-byte operand when gfx1250 WMMA mixes 8-bit and 4-bit or 6-bit inputs. The previous permutation paired different K coordinates between the operands and produced incorrect products.

Exercise all mixed-format pairs with independently packed one-hot inputs, including 6-bit word crossings, scalar and SIMD execution, and ordinary, scale32, and scale16 variants.

Issue #7891

Use contiguous K groups for the sub-byte operand when gfx1250 WMMA mixes
8-bit and 4-bit or 6-bit inputs. The previous permutation paired different
K coordinates between the operands and produced incorrect products.

Exercise all mixed-format pairs with independently packed one-hot inputs,
including 6-bit word crossings, scalar and SIMD execution, and ordinary,
scale32, and scale16 variants.
@kuhar
kuhar requested review from a team and atgutier as code owners October 8, 2026 15:46
Copilot AI balanced review requested due to automatic review settings October 8, 2026 15:46

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@therock-pr-bot

therock-pr-bot Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

✅ All Policy Checks Passed

Check Status Details
📝 PR Description ✅ Pass —
⛔ Forbidden Files ✅ Pass —
🧪 Unit Test ✅ Pass —
🚫 Draft PR 🔜 To Be Enabled —
🚩 Feature Flag 🔜 To Be Enabled —
📊 Code Coverage 🔜 To Be Enabled —

🎉 All policy checks passed!

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

@therock-pr-bot

therock-pr-bot Bot commented Oct 8, 2026

Copy link
Copy Markdown

🚫 Please fix the failed policies before requesting reviews.

The following policy checks failed:

  • ❌ PR Description

The Not ready to Review label has been added to this PR.
Once all policies pass, the label will be removed automatically.

@kuhar
kuhar merged commit ad69963 into develop Oct 9, 2026
164 of 176 checks passed
@kuhar
kuhar deleted the users/kuhar/corpus-wmma-pairing branch October 9, 2026 00:42
@systems-assistant

Copy link
Copy Markdown
Contributor

TheRock Submodule Bump Activity

Newest first

anujshuk-amd pushed a commit that referenced this pull request Oct 12, 2026
Use contiguous K groups for the sub-byte operand when gfx1250 WMMA mixes
8-bit and 4-bit or 6-bit inputs. The previous permutation paired
different K coordinates between the operands and produced incorrect
products.

Exercise all mixed-format pairs with independently packed one-hot
inputs, including 6-bit word crossings, scalar and SIMD execution, and
ordinary, scale32, and scale16 variants.

Issue #7891
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants