Repository navigation
[rocjitsu][ci] Add cpu thread budget in CI - #12652
RattataKing wants to merge 5 commits into
Conversation
github-actions
Bot
added
github actions
✅ All Checks Passed — Ready for Review
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🎉 All checks passed! This PR is ready for review. |
kuhar
left a comment
kuhar
left a comment
There was a problem hiding this comment.
One comment, plus an inline reply
bb8e0ea to
24f9ecc
Compare
| -R '^LaunchPreloadTest\.' \ | ||
| --output-on-failure | ||
|
|
||
| - name: Test corpus harness options |
There was a problem hiding this comment.
We should run this check after Install corpus test dependencies, alongside Run amdisa tests, so a harness-test failure still leaves the corpus results available. Currently, a failure here skips dependency installation through GitHub Actions' implicit success() condition. Run corpus tests then skips too because it requires steps.install_corpus_dependencies.outcome == 'success', despite its explicit intent to preserve the corpus signal after independent test failures. Moving this stub-based unit test below dependency installation would retain that behavior while still failing the job when the test fails.
| #!/usr/bin/env python3 | ||
| # Copyright (c) 2026 Advanced Micro Devices, Inc. | ||
| # SPDX-License-Identifier: MIT | ||
| # Test corpus budget forwarding without launching simulator workloads. | ||
| # Usage: python tests/corpus/test-run-corpus-tests.py | ||
|
|
||
| import os | ||
| from pathlib import Path | ||
| import shlex | ||
| import subprocess | ||
| import tempfile | ||
| import unittest | ||
|
|
||
| SOURCE = Path(__file__).resolve().parents[2] | ||
| SCRIPT = SOURCE / 'tests/corpus/run-corpus-tests.sh' | ||
|
|
||
|
|
||
| class ThreadBudgetTests(unittest.TestCase): | ||
| def setUp(self): |
There was a problem hiding this comment.
After looking at this again, I'm not convinced we need tests that test our tests... I'd drop this.
Restore commits missed in #12236
Issue ID: #12234