Skip to content

[rocjitsu][CI] Bound each corpus simulator's CPU thread budget - #12236

Merged
kuhar merged 1 commit into
developfrom
users/RattataKing/test-corpus-ci
Sep 28, 2026
Merged

kuhar merged 1 commit into
developfrom
users/RattataKing/test-corpus-ci

Conversation

@RattataKing

@RattataKing RattataKing commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

FPSAN tests are sensitive to CPU synchronization overhead, which can stretch a single test from 17s locally to 296s on the CI machine, causing intermittent timeouts and CI failures.

This PR adjusts the number of pytest workers and uses the newly added --cpu-thread-budget CLI option to limit the CPU consumption of multi-threaded rocjitsu.

Issue ID: #12234

@RattataKing
RattataKing force-pushed the users/RattataKing/test-corpus-ci branch from f98bbcc to 7786c1b Compare September 24, 2026 23:18
@github-actions github-actions Bot added documentation Improvements or additions to documentation github actions Pull requests that update GitHub Actions code project: rocjitsu labels Sep 24, 2026
@therock-pr-bot

therock-pr-bot Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

✅ All Checks Passed — Ready for Review

Check Status Details
📝 PR Description ✅ Pass —
⛔ Forbidden Files ✅ Pass —
🧪 Unit Test ✅ Pass PR does not contain code files — Unit Test auto-passed
🔎 pre-commit ✅ Pass —
🚫 Draft PR 🔜 To Be Enabled —
🚩 Feature Flag 🔜 To Be Enabled —
📊 Code Coverage 🔜 To Be Enabled —
🤖 therock-pr-bot ✅ Pass —

🎉 All checks passed! This PR is ready for review.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

@therock-pr-bot

Copy link
Copy Markdown

🎉 All checks passed! This PR is ready for review.

@RattataKing RattataKing changed the title [rocjitsu] Set cpu thread budget for rocjitsu in CI [rocjitsu][CI] Set cpu thread budget for rocjitsu in CI Sep 24, 2026

@kuhar kuhar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two CLI consistency suggestions below. The environment handoff already covers the native launcher without rewriting the input config.

@RattataKing
RattataKing changed the base branch from develop to users/RattataKing/cpu-thread-budget-cli September 25, 2026 04:52
@RattataKing
RattataKing force-pushed the users/RattataKing/test-corpus-ci branch from 7786c1b to ca554d5 Compare September 25, 2026 04:52
@RattataKing RattataKing changed the title [rocjitsu][CI] Set cpu thread budget for rocjitsu in CI [rocjitsu][CI] Bound each corpus simulator's CPU thread budget Sep 25, 2026
@RattataKing
RattataKing marked this pull request as ready for review September 25, 2026 05:00
@RattataKing
RattataKing requested review from a team and atgutier as code owners September 25, 2026 05:00
@RattataKing
RattataKing force-pushed the users/RattataKing/test-corpus-ci branch from 02a989d to 910acbf Compare September 25, 2026 17:24
Base automatically changed from users/RattataKing/cpu-thread-budget-cli to develop September 25, 2026 22:59
@RattataKing
RattataKing force-pushed the users/RattataKing/test-corpus-ci branch 2 times, most recently from b943300 to 287ff02 Compare September 28, 2026 14:03
@RattataKing
RattataKing removed this pull request from stack #12246 September 28, 2026 17:36
@RattataKing
RattataKing force-pushed the users/RattataKing/test-corpus-ci branch from 287ff02 to 42b9d23 Compare September 28, 2026 17:41
@RattataKing
RattataKing changed the base branch from develop to users/RattataKing/fix-pr-12245 September 28, 2026 17:41
@RattataKing
RattataKing changed the base branch from users/RattataKing/fix-pr-12245 to develop September 28, 2026 17:44
@RattataKing
RattataKing force-pushed the users/RattataKing/test-corpus-ci branch from 42b9d23 to da88b73 Compare September 28, 2026 17:46
@kuhar
kuhar merged commit 1f44cb5 into develop Sep 28, 2026
83 checks passed
@kuhar
kuhar deleted the users/RattataKing/test-corpus-ci branch September 28, 2026 19:29
@systems-assistant

Copy link
Copy Markdown
Contributor

TheRock Submodule Bump Activity

Newest first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation github actions Pull requests that update GitHub Actions code organization: ROCm project: rocjitsu

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants