Skip to content

fix(ci): update ci_config_api to use load_config v2 for rocprofiler-sdk-util #12474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
geomin12 merged 2 commits into from
Sep 29, 2026
Merged

fix(ci): update ci_config_api to use load_config v2 for rocprofiler-sdk-util #12474

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c1f6a60
fix(ci): update ci_config_api to use load_config v2
geomin12 Sep 29, 2026
0f553c6
fix(ci): update test mock to use load_config v2 API
geomin12 Sep 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/actions/rocprofiler-sdk-util/resolve-ci-config/resolve_ci_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,9 @@ def load_ci_configs(

sys.path.insert(0, str(config_path))
try:
from ci_config_api import load_config_v1
from ci_config_api import load_config

config = load_config_v1(config_path)
config = load_config(version=2, config_path=config_path)
all_families = config.get_gpu_families(TRIGGER_TYPES)
gpu_configs = {
family: all_families.get(family, {}).get("linux", {})
Expand Down
6 changes: 3 additions & 3 deletions .github/actions/rocprofiler-sdk-util/resolve-ci-config/test_resolve_ci_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ def _write_config(tmpdir: Path, config: dict) -> None:
from typing import Any

@dataclass
class ConfigV1:
class Config:
build_runners: dict
gpu_families: dict
_raw: dict
Expand All @@ -104,12 +104,12 @@ def get_gpu_families(self, trigger_types):
result[name] = cfg
return result

def load_config_v1(config_path=None):
def load_config(version=2, config_path=None):
if config_path is None:
config_path = Path(__file__).parent
with open(config_path / "runner-config.json") as f:
raw = json.load(f)
return ConfigV1(
return Config(
build_runners=raw["build_runners"],
gpu_families=raw["gpu_families"],
_raw=raw,
Expand Down
Loading