Skip to content

fix(ci): update ci_config_api to use load_config v2 for rocprofiler-sdk-util - #12474

Merged
geomin12 merged 2 commits into
developfrom
users/geomin12/config-update-systems
Sep 29, 2026
Merged

fix(ci): update ci_config_api to use load_config v2 for rocprofiler-sdk-util#12474
geomin12 merged 2 commits into
developfrom
users/geomin12/config-update-systems

Conversation

@geomin12

@geomin12 geomin12 commented Sep 29, 2026

Copy link
Copy Markdown
Contributor

Migrate from load_config_v1 to load_config(version=2) to match the API change in ROCm/TheRock.

@geomin12 @claude
fix(ci): update ci_config_api to use load_config v2
c1f6a60 
Migrate from load_config_v1 to load_config(version=2) to match
the API change in ROCm/TheRock.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@geomin12
geomin12 requested a review from a team as a code owner September 29, 2026 17:11
@geomin12 geomin12 added the ci:skip Skip all CI builds/tests for this PR label Sep 29, 2026
@geomin12
geomin12 requested a review from venkat1361 September 29, 2026 17:11
@therock-pr-bot

therock-pr-bot Bot commented Sep 29, 2026 •
edited
Loading

Copy link
Copy Markdown

❌ PR Check — Action Required

Check Status Details
📝 PR Description ❌ Fail Error: PR description must reference a JIRA ID, ISSUE ID, or a GitHub closing keyword.
Expected: include a JIRA ID / ISSUE ID line (separator : or -, or omitted; value may be a JIRA key, a number with/without #, or a link), OR a closing keyword + issue reference. Accepted examples:
• JIRA ID : TESTAUTO-6039
• JIRA ID - #330
• JIRA ID #330
• JIRA ID (on separate line)
ROCM-25757
• ISSUE ID : TESTUTO-3334
• ISSUE ID #3334
• ISSUE ID - TESTAUTO-3433
• ISSUE ID (on separate line)
AIRUNTIME-2352
• ISSUE ID : https://github.com/<org_name>/<repo_name>/issues/1234
• Closes #10
• Fixes octo-org/octo-repo#100
• Resolves: #123
• #123
• https://github.com/<org_name>/<repo_name>/issues/123
Current: no valid JIRA/ISSUE/closing-keyword reference found
⛔ Forbidden Files ✅ Pass —
🧪 Unit Test ✅ Pass —
🔎 pre-commit ⏳ Pending ⏳ Still running…
🚫 Draft PR 🔜 To Be Enabled —
🚩 Feature Flag 🔜 To Be Enabled —
📊 Code Coverage 🔜 To Be Enabled —

⚠️ 1 policy check(s) failed. Please address the issues above before this PR can be Reviewed.

🚫 Please fix the failed policies

  • ❌ PR Description

The Not ready to Review label was added to this PR. Once all policies pass, the label is removed automatically.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

@therock-pr-bot

therock-pr-bot Bot commented Sep 29, 2026

Copy link
Copy Markdown

🚫 Please fix the failed policies before requesting reviews.

The following policy checks failed:

  • ❌ PR Description

The Not ready to Review label has been added to this PR.
Once all policies pass, the label will be removed automatically.

@geomin12 @claude
fix(ci): update test mock to use load_config v2 API
0f553c6 
Update the mock ci_config_api in tests to match the v2 API signature.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@geomin12
geomin12 merged commit 5600ee2 into develop Sep 29, 2026
70 of 78 checks passed
@geomin12
geomin12 deleted the users/geomin12/config-update-systems branch September 29, 2026 17:18
@systems-assistant

systems-assistant Bot commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

TheRock Submodule Bump Activity

Newest first

@andraghetti andraghetti mentioned this pull request Oct 6, 2026
Merged
1 task done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@venkat1361 venkat1361 venkat1361 approved these changes

Assignees

No one assigned

Labels

ci:skip Skip all CI builds/tests for this PR Not ready to Review organization: ROCm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@geomin12 @venkat1361