Repository navigation
fix(amdsmi): drm_examples SIGSEGV due to partition var init - #11922
Merged
amd-hsivasun merged 1 commit intoOct 1, 2026
Merged
amd-hsivasun merged 1 commit into
amd-hsivasun merged 1 commit into
Conversation
✅ All Policy Checks Passed
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
marifamd
changed the title
marifamd
changed the title
marifamd
approved these changes
Sep 23, 2026
marifamd
force-pushed
the
amd_smi_drm_ex_SIGSEGV_in_accelerator_partition_loop
branch
from
September 24, 2026 14:27
0ed867e to
d89f348
Compare
dee-mew
force-pushed
the
amd_smi_drm_ex_SIGSEGV_in_accelerator_partition_loop
branch
from
September 27, 2026 09:52
d89f348 to
6ddc00b
Compare
adam360x
approved these changes
Sep 27, 2026
dee-mew
force-pushed
the
amd_smi_drm_ex_SIGSEGV_in_accelerator_partition_loop
branch
from
September 29, 2026 12:30
6ddc00b to
41807fa
Compare
eble-amd
reviewed
Sep 30, 2026
… NOT_SUPPORTED/NO_PERM Signed-off-by: Deepak Mewar <deepak.mewar@amd.com>
gabrpham
force-pushed
the
amd_smi_drm_ex_SIGSEGV_in_accelerator_partition_loop
branch
from
September 30, 2026 18:58
41807fa to
88a28ad
Compare
dee-mew
deleted the
amd_smi_drm_ex_SIGSEGV_in_accelerator_partition_loop
branch
October 5, 2026 04:18
Contributor
TheRock Submodule Bump ActivityNewest first
|
marifamd
added a commit
that referenced
this pull request
Oct 9, 2026
…smi-verification-fixes Conflicts: - amdsmi_cli/amdsmi_cli.py: take develop. #8624 already drops the exception class-name prefix for every output format and sets the format from argv before parsing. - example/amd_smi_drm_example.cc: keep the success-guarded profile loop. #11922 only zero-initialized the structs. - tests/python/cli/base.py: keep develop's reset --profile branch and the requires_value skip, reported in develop's "Untested" format. Signed-off-by: Maisam Arif <Maisam.Arif@amd.com>
1 task done
marifamd
added a commit
that referenced
this pull request
Oct 13, 2026
- Quote the real --json shape, a list - Drop the zero-init clause from the DRM entry; #11922 made that change Signed-off-by: Maisam Arif <Maisam.Arif@amd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fix a segmentation fault in amd_smi_drm_ex on Strix/Gorgon Halo systems when the accelerator-partition loop encounters APIs returning NOT_SUPPORTED or NO_PERM. The Jira title identifies the problem as"[Strix Halo][AMD SMI 10.1.0] amd_smi_drm_ex SIGSEGV in accelerator partition loop when APIs return NOT_SUPPORTED/NO_PERM."
The issue was reproduced on a Strix Halo APU with gfx1151 on AMD SMI library 27.1.0, ROCm 10.2.0, and amdgpu 6.19.0 .
Technical Details
The change should ensure that amd_smi_drm_ex safely handles unsupported or permission-restricted API results in the accelerator-partition processing path instead of reaching a SIGSEGV.
Issue Tracking
JIRA ID: ROCM-30849
Test Plan
Test Result
After running the example again with the fix, SIGSEGV is not reported.
Submission Checklist