[marifamd]

Motivation

Verifying develop across MI300A, MI350X, MI210, Strix Halo, Navi 21 + Navi 32 and a 75c1 part turned up these defects:

• amd-smi node --tray printed an empty section on hardware without UALoE.
• amdsmi_get_afids_from_cper() raised TypeError for list input.
• amd_smi_drm_ex segfaulted when run without root, and CI discarded the example exit codes, so nothing caught it.
• The CLI test generator ran value-taking flags with no value, so those commands failed by construction.

Technical Details

CLI (amdsmi_cli/subcommands/node.py):

• Drop the non-empty tray_dict guard. Human, --json and --csv now report MAX_ACC_PER_TRAY and TRAY_TYPE as N/A when tray info is unavailable, instead of a bare NODE: and {"node": {}}

Python API (py-interface/amdsmi_interface.py):

• amdsmi_get_afids_from_cper(): check list input with isinstance(..., list). isinstance() with List[Dict[str, Any]] always raises TypeError, so the documented list-of-dicts input never worked and other bad input raised TypeError instead of AmdSmiParameterException. bytes input (the CLI path) was unaffected

Example (example/amd_smi_drm_example.cc):

• Run the partition profile loop only when amdsmi_get_gpu_accelerator_partition_profile_config() succeeds. Without root it returns AMDSMI_STATUS_NO_PERM before filling its output, so the loop read an uninitialized num_profiles. fix(amdsmi): drm_examples SIGSEGV due to partition var init #11922 zero-initialized the struct on develop; this adds the status check
• Zero-initialize the remaining output buffers: socket_info, profile, partition_id, vmode, temp_measurements

CLI test generator (tests/python/cli/base.py):

• Detect value-taking flags from the argparse help layout (one space before a metavar) instead of isupper()
• Skip a value-taking flag that has no sweep values and report it as Untested

CI (.github/workflows/amdsmi-build.yml):

• Fail the example step when an example dies from a signal (exit 129-192). Other non-zero exits are the first failing amdsmi_status_t returned from main() and are only logged, since a call can be unsupported on a given ASIC. Before, || echo discarded every exit code

Changelog (CHANGELOG.md):

• Three 10.2.0 Resolved Issues entries

The --json error-prefix fix from the first revision is dropped: #8624 already removed the exception class name from every output format.

Issue Tracking

N/A, found during manual verification of develop.

Test Plan

Original branch, on the machines above (source build installed to a staging prefix):

• amd-smi node --tray in human, --json and --csv
• amd_smi_drm_ex as root and non-root
• amdsmitst read-only suites, unit_tests.py, test_abi_compat.py
• cli.test_list, cli.test_node, cli.test_version, cli.test_static

After merging develop:

• pre-commit on every changed file
• g++ -fsyntax-only -Wall -Wextra on the DRM example
• amdsmi_get_afids_from_cper() with bytes, a list of records, and an int, against the installed 27.1.0 library and the mock_cper fixtures
• FindArgs against stubbed --help output

Test Result

Check	Build	Before	After
amd_smi_drm_ex, non-root (Navi 21 + Navi 32)	original	Segmentation fault, rc=139	rc=17 (INPUT_OUT_OF_BOUNDS from the clock query, no crash)
amd-smi node --tray	original	bare NODE:	TRAY: with MAX_ACC_PER_TRAY: N/A and TRAY_TYPE: N/A
cli.test_list	original	failed	passed
amdsmitst read-only	original		95/95 passed
unit_tests.py	original		85 passed, 6 skipped
test_abi_compat.py	original		12 passed
cli.test_node, cli.test_version	original		passed
amdsmi_get_afids_from_cper([record])	merged	TypeError	same result as the bytes call
amdsmi_get_afids_from_cper(5)	merged	TypeError	AmdSmiParameterException
FindArgs stub	merged	--nic run with no value	skipped and reported as Untested; reset --profile still expands
pre-commit, g++ -fsyntax-only	merged		clean

cli.test_static failed test_tray and test_asic_revision_id_keys on the original host because tests/python/common/runcmd.py puts /opt/rocm/bin first on PATH, so the CLI tests ran the older installed amd-smi, which has no --tray.

Submission Checklist

• Look over the contributing guidelines at https://github.com/ROCm/rocm-systems/blob/develop/CONTRIBUTING.md.

[therock-pr-bot]

✅ All Policy Checks Passed

Check	Status	Details
📝 PR Description	✅ Pass	—
⛔ Forbidden Files	✅ Pass	—
🧪 Unit Test	⚠️ Warning	Error: Source/code files changed without an accompanying unit test. Expected: add at least one test file named like test_<name>.py / test_<name>.cpp (or <name>_test.*). Current: code file(s) changed: projects/amdsmi/amdsmi_cli/subcommands/node.py, projects/amdsmi/example/amd_smi_drm_example.cc, projects/amdsmi/py-interface/amdsmi_interface.py; no test file found
🚫 Draft PR	🔜 To Be Enabled	—
🚩 Feature Flag	🔜 To Be Enabled	—
📊 Code Coverage	🔜 To Be Enabled	—

🎉 All policy checks passed!

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

[therock-pr-bot]

🚫 Please fix the failed policies before requesting reviews.

The following policy checks failed:

• ❌ PR Description

The Not ready to Review label has been added to this PR.
Once all policies pass, the label will be removed automatically.

[oliveiradan]

Comments were addressed. Approved.

[adam360x]

@copilot rebase and fix conflict

[Copilot]

@copilot rebase and fix conflict

Integrated develop with a clean merge (no conflicts) in fdf54386. I merged rather than rebased because this environment cannot publish rewritten history.

[systems-assistant]

TheRock Submodule Bump Activity

Newest first

• 2026-10-15 — Included in TheRock via ROCm/TheRock#9003.