Repository navigation
Bump TheRock ref to 648a501 in Multi-Arch CI workflows - #11134
Closed
amd-justchen wants to merge 1 commit into
Closed
amd-justchen wants to merge 1 commit into
amd-justchen wants to merge 1 commit into
Conversation
Follow-up to #11050, which bumped the TheRock ref to 648a501 (2026-09-02, TheRock#7820) across the therock-ci*/rccl/build workflows but left the four therock-multi-arch-ci* workflows pinned to the older 3c4ec01 (2026-08-31). Align them so the gating Multi-Arch CI runs against the same TheRock commit. actions/checkout pin left untouched. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
github-actions
Bot
added
the
github actions
✅ All Policy Checks Passed
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The changes are a straightforward, consistent SHA pin update across the intended multi-arch workflows with no remaining references to the old pin.
Pull request overview
This PR aligns the four TheRock Multi-Arch CI GitHub Actions workflows in rocm-systems to use the same pinned ROCm/TheRock commit (648a501e..., 2026-09-02) as the rest of the TheRock CI workflows, ensuring the gating multi-arch summary check runs against the intended TheRock revision.
Changes:
- Updated all
ref:checkout pins in the multi-arch workflows from3c4ec01...to648a501.... - Updated reusable-workflow
uses: ROCm/TheRock/.github/workflows/*@<sha>references to648a501.... - Updated the pinned-ref header comment in the nightly multi-arch workflow to match the new commit.
File summaries
| File | Description |
|---|---|
| .github/workflows/therock-multi-arch-ci.yml | Bumps all TheRock checkout/workflow-call pins used by the presubmit multi-arch gating pipeline to 648a501.... |
| .github/workflows/therock-multi-arch-ci-nightly.yml | Bumps TheRock pins (and the pinned-ref comment) for the nightly multi-arch workflow to 648a501.... |
| .github/workflows/therock-multi-arch-ci-asan.yml | Bumps TheRock pins for presubmit/on-demand ASAN multi-arch runs to 648a501.... |
| .github/workflows/therock-multi-arch-ci-asan-nightly.yml | Bumps TheRock pins for nightly ASAN multi-arch runs to 648a501.... |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
geomin12
approved these changes
Sep 2, 2026
erman-gurses
approved these changes
Sep 2, 2026
Collaborator
|
Outdated |
jayhawk-commits
deleted the
gardener/bump-therock-multi-arch-ref-2026-09-02
branch
September 21, 2026 16:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #11050.
#11050 bumped the TheRock ref to
648a501(2026-09-02, TheRock#7820) across thetherock-ci*/rccl/buildworkflows, but left the four Multi-Arch CI workflows pinned to the older3c4ec01(2026-08-31, TheRock#7779):.github/workflows/therock-multi-arch-ci.yml.github/workflows/therock-multi-arch-ci-nightly.yml.github/workflows/therock-multi-arch-ci-asan.yml.github/workflows/therock-multi-arch-ci-asan-nightly.ymlSince Multi-Arch CI is the gating summary check, this aligns those workflows to the same TheRock commit (26 refs across
ref:checkouts anduses: ROCm/TheRock/.github/workflows/*@<sha>reusable-workflow calls). Theactions/checkout@de0fac2 # v6.0.2pins are intentionally left unchanged. Verifiedsetup_multi_arch.yml/multi_arch_ci_linux.yml/multi_arch_ci_windows.ymlexist at 648a501.Mirrors ROCm/rocm-libraries#11590.