Skip to content

feat(ci): bump TheRock ref to 648a501 (2026-09-02) - #11590

Closed
amd-justchen wants to merge 2 commits into
developfrom
gardener/bump-therock-ref-2026-09-02
Closed

amd-justchen wants to merge 2 commits into
developfrom
gardener/bump-therock-ref-2026-09-02

Conversation

@amd-justchen

Copy link
Copy Markdown
Contributor

Bump the pinned ROCm/TheRock ref from b45a060 (2026-08-26) to 648a501 (2026-09-02) across the rocm-libraries TheRock CI pins.

Mirrors ROCm/rocm-systems#11050, which bumps the same shared develop TheRock pin so builds pass as they do on TheRock main. 648a501 is the current TheRock main tip and includes ROCm/TheRock#7820 (guard Unix-only fcntl import in the Windows driver/GPU sanity check), so the newer ref does not break the Windows test lane.

Changes (3 files):

  • .github/actions/ci-env/action.yml — the single source of truth: therock-ref output b45a060 -> 648a501 and the paired baseline-run-id 33012920661 -> 33573805461 (TheRock main Multi-Arch CI run for 648a501), matching how assistant-librarian[bot] bumps them together.
  • .github/workflows/clang-tidy.yml — hardcoded checkout ref: copy of the same pin.
  • .github/workflows/therock-ci-nightly.yml — therock_ref_override default copy of the same pin.

The unrelated kpack-ref (a022846… rocm-systems commit, 2026-08-22) is left unchanged.

Ref: ROCm/rocm-systems#11050

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions github-actions Bot added github actions project: none Does not target any component labels Sep 2, 2026
@therock-pr-bot

therock-pr-bot Bot commented Sep 2, 2026 •

Copy link
Copy Markdown

❌ PR Check — Action Required

Check Status Details
📝 PR Description ❌ Fail Error: PR description must reference a JIRA ID, ISSUE ID, or a GitHub closing keyword.
Expected: include a JIRA ID / ISSUE ID line (separator : or -, or omitted; value may be a JIRA key, a number with/without #, or a link), OR a closing keyword + issue reference. Accepted examples:
• JIRA ID : TESTAUTO-6039
• JIRA ID - #330
• JIRA ID #330
• JIRA ID (on separate line)
ROCM-25757
• ISSUE ID : TESTUTO-3334
• ISSUE ID #3334
• ISSUE ID - TESTAUTO-3433
• ISSUE ID (on separate line)
AIRUNTIME-2352
• ISSUE ID : https://github.com/<org_name>/<repo_name>/issues/1234
• Closes #10
• Fixes octo-org/octo-repo#100
• Resolves: #123
• #123
• https://github.com/<org_name>/<repo_name>/issues/123
Current: no valid JIRA/ISSUE/closing-keyword reference found
⛔ Forbidden Files ✅ Pass —
🧪 Unit Test ✅ Pass PR does not contain code files — Unit Test auto-passed
🔎 pre-commit ✅ Pass —
🚫 Draft PR 🔜 To Be Enabled —
🚩 Feature Flag 🔜 To Be Enabled —
📊 Code Coverage 🔜 To Be Enabled —

⚠️ 1 policy check(s) failed. Please address the issues above before this PR can be Reviewed.

🚫 Please fix the failed policies

  • ❌ PR Description

The Not ready to Review label was added to this PR. Once all policies pass, the label is removed automatically.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

@therock-pr-bot

therock-pr-bot Bot commented Sep 2, 2026

Copy link
Copy Markdown

🚫 Please fix the failed policies before requesting reviews.

The following policy checks failed:

  • ❌ PR Description

The Not ready to Review label has been added to this PR.
Once all policies pass, the label will be removed automatically.

@amd-justchen
amd-justchen marked this pull request as ready for review September 2, 2026 01:46
@amd-justchen
amd-justchen requested a review from a team as a code owner September 2, 2026 01:46

@geomin12 geomin12 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls update multi arch files pls

Align the hardcoded TheRock ref in the therock-multi-arch-ci* workflows
with the ci-env pin (3c4ec01 -> 648a501, 2026-09-02).

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown
Contributor

This pull request has been inactive for 25 days and will be marked as stale.

If you would like to keep this PR open, please:

  • Add new commits
  • Add a comment explaining why it should remain open

This PR will be automatically closed in 5 days if no further activity occurs.

@github-actions github-actions Bot added the Stale PR has no activity for 25+ days label Sep 28, 2026
@github-actions

github-actions Bot commented Oct 4, 2026

Copy link
Copy Markdown
Contributor

This pull request has been automatically closed due to inactivity (30 days with no updates).

If you'd like to continue working on this, feel free to reopen the PR or create a new one.

@github-actions github-actions Bot closed this Oct 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github actions Not ready to Review organization: ROCm project: none Does not target any component Stale PR has no activity for 25+ days

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants