Repository navigation
test(amdsmi): Update API summary script - #10998
Merged
Merged
Conversation
✅ All Policy Checks Passed
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
amd-josnarlo
force-pushed
the
users/josnarlo/update_api_summary
branch
from
August 31, 2026 21:25
1cc8dcc to
6a6cf6d
Compare
adam360x
approved these changes
Aug 31, 2026
Signed-off-by: josnarlo <joseph.narlo@amd.com>
amd-josnarlo
force-pushed
the
users/josnarlo/update_api_summary
branch
from
September 1, 2026 14:04
6a6cf6d to
96520dd
Compare
marifamd
approved these changes
Sep 2, 2026
Contributor
TheRock Submodule Bump ActivityNewest first
|
marifamd
added a commit
that referenced
this pull request
Sep 24, 2026
## Motivation `amdsmi-license-headers` is `pass_filenames: false`, so it rescans the whole tree. Once a violation lands on `develop`, every later PR goes red instead of the merge that caused it. #10010 merged on a stale-green formatting run and reddened #10973 and #10998 until #8561 fixed the headers. Third time against this hook (#10402, #10845, #8561), each fixed reactively. ## Technical Details `.github/workflows/lstt-formatting.yml`: - `push` trigger on `develop`, same path filter as `pull_request`, so a whole-tree hook runs on the merge commit. - `--from-ref` is event-aware via `FROM_REF`: `github.event.before` on push, base branch on PR. PR behavior unchanged. - `cancel-in-progress` limited to `pull_request`, so consecutive merges each keep their verdict. Detection at merge, not prevention. Prevention is "Require branches to be up to date before merging". `develop`'s ruleset has `required_status_checks` with `strict_required_status_checks_policy: false`, so a PR can merge on a check that last ran against an older base — which is how the stale-green merge happened. Signed-off-by: Maisam Arif <Maisam.Arif@amd.com>
anujshuk-amd
pushed a commit
that referenced
this pull request
Sep 25, 2026
## Motivation `amdsmi-license-headers` is `pass_filenames: false`, so it rescans the whole tree. Once a violation lands on `develop`, every later PR goes red instead of the merge that caused it. #10010 merged on a stale-green formatting run and reddened #10973 and #10998 until #8561 fixed the headers. Third time against this hook (#10402, #10845, #8561), each fixed reactively. ## Technical Details `.github/workflows/lstt-formatting.yml`: - `push` trigger on `develop`, same path filter as `pull_request`, so a whole-tree hook runs on the merge commit. - `--from-ref` is event-aware via `FROM_REF`: `github.event.before` on push, base branch on PR. PR behavior unchanged. - `cancel-in-progress` limited to `pull_request`, so consecutive merges each keep their verdict. Detection at merge, not prevention. Prevention is "Require branches to be up to date before merging". `develop`'s ruleset has `required_status_checks` with `strict_required_status_checks_policy: false`, so a PR can merge on a check that last ran against an older base — which is how the stale-green merge happened. Signed-off-by: Maisam Arif <Maisam.Arif@amd.com>
dgaliffiAMD
pushed a commit
that referenced
this pull request
Sep 25, 2026
## Motivation `amdsmi-license-headers` is `pass_filenames: false`, so it rescans the whole tree. Once a violation lands on `develop`, every later PR goes red instead of the merge that caused it. #10010 merged on a stale-green formatting run and reddened #10973 and #10998 until #8561 fixed the headers. Third time against this hook (#10402, #10845, #8561), each fixed reactively. ## Technical Details `.github/workflows/lstt-formatting.yml`: - `push` trigger on `develop`, same path filter as `pull_request`, so a whole-tree hook runs on the merge commit. - `--from-ref` is event-aware via `FROM_REF`: `github.event.before` on push, base branch on PR. PR behavior unchanged. - `cancel-in-progress` limited to `pull_request`, so consecutive merges each keep their verdict. Detection at merge, not prevention. Prevention is "Require branches to be up to date before merging". `develop`'s ruleset has `required_status_checks` with `strict_required_status_checks_policy: false`, so a PR can merge on a check that last ran against an older base — which is how the stale-green merge happened. Signed-off-by: Maisam Arif <Maisam.Arif@amd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The API coverage report folded functional tests into the integration bucket, so the C and Python functional suites were invisible in the summary — and the table's
Funccolumn was in fact reporting integration counts under a functional heading. This adds first-class functional categories for both languages, so the report mirrors how the tests are actually organized (unit/,functional/,integration/).Technical Details
Coverage report (
tests/api_summary.py):c_func_testandpy_func_testc_integration/py_integrationtoc_intg_test/py_intg_testfor a consistent{lang}_{level}_testscheme across all six categories--c_func_test/--py_func_test, and align every default log filename with its category (_c_unit_test.log,_c_func_test.log,_c_intg_test.log,_py_unit_test.log,_py_func_test.log,_py_intg_test.log)Funccolumn to the summary table and relabel the previousFunccolumn toIntg, which is what it was already countingheaderstringmkdir(parents=True, exist_ok=True)Docs (
tests/README.md):amdsmitstinvocations (*Unit*.*,*Functional*.*,*Integration*.*) that produce the C logs--outputexample to--output_dirand fix the documented--output_dirdefaultIssue Tracking
JIRA ID : AILITOOLS-311
Test Plan
Run C++ and Python unit, integration and functional tests and capture output
Run api_summary.py script against testing output
Test Result
API summary report generated properly