Repository navigation
fix(amdsmi): FCLK max no longer reported as 0 - #10010
Merged
Merged
Conversation
✅ All Policy Checks Passed
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🚫 Please fix the failed policies before requesting reviews. The following policy checks failed:
The |
gabrpham
force-pushed
the
users/kbillaka/FWDEV-220253
branch
from
August 17, 2026 18:32
df86e68 to
0fdd382
Compare
gabrpham
approved these changes
Aug 19, 2026
gabrpham
left a comment
gabrpham
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me. Approved
koushikbillakanti-amd
force-pushed
the
users/kbillaka/FWDEV-220253
branch
from
August 24, 2026 17:23
0fdd382 to
0a465c0
Compare
marifamd
approved these changes
Aug 28, 2026
bill-shuzhou-liu
approved these changes
Aug 28, 2026
Contributor
TheRock Submodule Bump ActivityNewest first
|
marifamd
added a commit
that referenced
this pull request
Sep 24, 2026
## Motivation `amdsmi-license-headers` is `pass_filenames: false`, so it rescans the whole tree. Once a violation lands on `develop`, every later PR goes red instead of the merge that caused it. #10010 merged on a stale-green formatting run and reddened #10973 and #10998 until #8561 fixed the headers. Third time against this hook (#10402, #10845, #8561), each fixed reactively. ## Technical Details `.github/workflows/lstt-formatting.yml`: - `push` trigger on `develop`, same path filter as `pull_request`, so a whole-tree hook runs on the merge commit. - `--from-ref` is event-aware via `FROM_REF`: `github.event.before` on push, base branch on PR. PR behavior unchanged. - `cancel-in-progress` limited to `pull_request`, so consecutive merges each keep their verdict. Detection at merge, not prevention. Prevention is "Require branches to be up to date before merging". `develop`'s ruleset has `required_status_checks` with `strict_required_status_checks_policy: false`, so a PR can merge on a check that last ran against an older base — which is how the stale-green merge happened. Signed-off-by: Maisam Arif <Maisam.Arif@amd.com>
anujshuk-amd
pushed a commit
that referenced
this pull request
Sep 25, 2026
## Motivation `amdsmi-license-headers` is `pass_filenames: false`, so it rescans the whole tree. Once a violation lands on `develop`, every later PR goes red instead of the merge that caused it. #10010 merged on a stale-green formatting run and reddened #10973 and #10998 until #8561 fixed the headers. Third time against this hook (#10402, #10845, #8561), each fixed reactively. ## Technical Details `.github/workflows/lstt-formatting.yml`: - `push` trigger on `develop`, same path filter as `pull_request`, so a whole-tree hook runs on the merge commit. - `--from-ref` is event-aware via `FROM_REF`: `github.event.before` on push, base branch on PR. PR behavior unchanged. - `cancel-in-progress` limited to `pull_request`, so consecutive merges each keep their verdict. Detection at merge, not prevention. Prevention is "Require branches to be up to date before merging". `develop`'s ruleset has `required_status_checks` with `strict_required_status_checks_policy: false`, so a PR can merge on a check that last ran against an older base — which is how the stale-green merge happened. Signed-off-by: Maisam Arif <Maisam.Arif@amd.com>
dgaliffiAMD
pushed a commit
that referenced
this pull request
Sep 25, 2026
## Motivation `amdsmi-license-headers` is `pass_filenames: false`, so it rescans the whole tree. Once a violation lands on `develop`, every later PR goes red instead of the merge that caused it. #10010 merged on a stale-green formatting run and reddened #10973 and #10998 until #8561 fixed the headers. Third time against this hook (#10402, #10845, #8561), each fixed reactively. ## Technical Details `.github/workflows/lstt-formatting.yml`: - `push` trigger on `develop`, same path filter as `pull_request`, so a whole-tree hook runs on the merge commit. - `--from-ref` is event-aware via `FROM_REF`: `github.event.before` on push, base branch on PR. PR behavior unchanged. - `cancel-in-progress` limited to `pull_request`, so consecutive merges each keep their verdict. Detection at merge, not prevention. Prevention is "Require branches to be up to date before merging". `develop`'s ruleset has `required_status_checks` with `strict_required_status_checks_policy: false`, so a PR can merge on a check that last ran against an older base — which is how the stale-green merge happened. Signed-off-by: Maisam Arif <Maisam.Arif@amd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
amd-smi metric --clockreportedFCLK_0 MAX_CLK: 0 MHzon MI45x, failing AMD-SMI acceptance.Technical Details
smi_amdgpu_get_ranges()read the FCLK range frompp_od_clk_voltage, which on MI45x has no FCLK section, and only fell back topp_dpm_fclkwhen that file was entirely absent. The parsed max stayed 0. Now the per-domain flag is cleared when its overdrive section is missing, so the range falls back topp_dpm_*(also covers SCLK/MCLK).Issue Tracking
JIRA ID: ROCM-29391
Test Plan
Ran
amd-smi metric --clockon two MI45x systems with the shipped vs. patched build.Test Result
Before:
FCLK_0 MAX_CLK: 0 MHz. After:MAX_CLK: 1100 MHz(matchespp_dpm_fclk) on all GPUs, both systems.Submission Checklist