Repository navigation
[rocjitsu] Rename gfx1250 to cdna5 for enums, configs, amdisa codegen helpers and generated symbols. (NFC) #10137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 82 commits
fe1cdc2
1652f3c
d270353
8e0deae
00d85b8
b4b9a7f
b1f795a
52608ac
5c08f69
d560d9d
1a6f47f
9ad2981
ca800ec
eb7af31
ee7685c
db6a621
50b1857
915bc37
b17ed83
92b54a0
ad540ef
d8224b2
39626c8
3459da4
2d46e40
35cdc0c
86cb6da
9fb1531
4eb3165
a453197
5166aed
222a2e6
602bce0
be6c782
ba2c3fe
7f854d8
4382a99
5d90c04
42ed507
c4fd60f
e6baa3f
06ff530
d2594ff
82b9135
8f402bb
9b38160
969b0b5
30ffcda
2fe282d
1b3e19a
f0be251
ed159e0
51530fc
a6173a7
c099f20
4c3bc24
7fa79ae
4693e94
01b8338
4db968b
f98c0c5
d4b6d4d
733d640
a8c9bf9
a598ac8
524e81c
b5302c2
e676432
0128dc4
127e7ef
0a1b65c
eeee937
cfbe740
96f5e0b
3e7a6b4
0b86a72
57be8fa
a00b9aa
fd66986
98f303e
a15b6bc
b4c94fd
68b561e
810edaa
2eef72e
0965659
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,7 +2,7 @@ | |
| //! | ||
| //! Each agent mirrors one of the rocjitsu `configs/*.json` files: | ||
| //! `MI300X` follows `gfx942_cdna3.json`, `MI350X` follows | ||
| //! `gfx950_cdna4.json`, and `MI450X` follows `gfx1250.json`. | ||
| //! `gfx950_cdna4.json`, and `MI450X` follows `gfx1250_cdna5.json`. | ||
| //! All three share the same `soc -> {vram, iod, xcd -> {l2, cp, | ||
| //! se -> cu}}` component tree and six link patterns; they differ | ||
| //! only in their device identity, the IOD fan-out, and the per-CU | ||
|
|
@@ -127,7 +127,7 @@ pub fn mi350x() -> AgentDef { | |
| } | ||
|
|
||
| /// `MI450X` builtin agent (registry key `MI450X`), mirroring the | ||
| /// rocjitsu `gfx1250.json` config: `arch = gfx1250`, an | ||
| /// rocjitsu `gfx1250_cdna5.json` config: `arch = cdna5`, an | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We should finish the MI450X producer rename here.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| /// 8-XCD / 4-SE / 8-CU shader fabric and a 2-IOD memory tier. | ||
| pub fn mi450x() -> AgentDef { | ||
| AgentDef { | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,7 +3,7 @@ | |
| "num_threads": 1, | ||
| "exec_mode": "functional", | ||
| "vm": { | ||
| "arch": "gfx1250", | ||
| "arch": "cdna5", | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We should rename this file to gfx1250_mi455x.json, following the convention used by the newer rdna3/4 configs.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| "gpu": { | ||
| "device": { | ||
| "gpu_id": 1250, | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should update this workflow to
configs/gfx1250_mi455x.jsonand check that the config exists before launch.configs/gfx1250_cdna5.jsonis absent at this head, so both wrappers receive a missing config and the release corpus comparison cannot run.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
810edaa