[rocjitsu] Rename gfx1250 to cdna5 for enums, configs, amdisa codegen helpers and generated symbols. (NFC)

.github/workflows/rocjitsu-corpus-tests.yml

@@ -360,7 +360,7 @@ jobs:
           ROCM_PATH="$(rocm-sdk path --root)"
           export ROCM_PATH
           LAUNCHER="${ROCJITSU_BUILD_DIR}/tools/rocjitsu/rocjitsu"
-          CONFIG="${ROCJITSU_SOURCE_DIR}/configs/gfx1250.json"
+          CONFIG="${ROCJITSU_SOURCE_DIR}/configs/gfx1250_mi455x.json"
           HOTSWAP="${ROCJITSU_BUILD_DIR}/lib/rocjitsu/src/rocjitsu/hooks/libhsa_hotswap_rocjitsu.so"
           test -f "${HOTSWAP}"
           # Disable ROCr's built-in mechanism in both legs. Load the branch-built

emulation/mirage/builtin/src/agents.rs

@@ -2,7 +2,7 @@
 //!
 //! Each agent mirrors one of the rocjitsu `configs/*.json` files:
 //! `MI300X` follows `gfx942_cdna3.json`, `MI350X` follows
-//! `gfx950_cdna4.json`, and `MI450X` follows `gfx1250.json`.
+//! `gfx950_cdna4.json`, and `MI450X` follows `gfx1250_mi455x.json`.
 //! All three share the same `soc -> {vram, iod, xcd -> {l2, cp,
 //! se -> cu}}` component tree and six link patterns; they differ
 //! only in their device identity, the IOD fan-out, and the per-CU
@@ -127,12 +127,12 @@ pub fn mi350x() -> AgentDef {
 }
 
 /// `MI450X` builtin agent (registry key `MI450X`), mirroring the
-/// rocjitsu `gfx1250.json` config: `arch = gfx1250`, an
+/// rocjitsu `gfx1250_mi455x.json` config: `arch = cdna5`, an
 /// 8-XCD / 4-SE / 8-CU shader fabric and a 2-IOD memory tier.
 pub fn mi450x() -> AgentDef {
     AgentDef {
         vm: VirtualMachineConfig {
-            arch: "gfx1250".to_string(),
+            arch: "cdna5".to_string(),
             gpu: AmdgpuConfig {
                 num_xcds: 0,
                 num_iods: 0,
@@ -336,7 +336,7 @@ mod tests {
     #[test]
     fn mi450x_identity() {
         let a = mi450x();
-        assert_eq!(a.vm.arch, "gfx1250");
+        assert_eq!(a.vm.arch, "cdna5");
         assert_eq!(a.vm.gpu.device.marketing_name, "gfx1250");
         assert_eq!(a.vm.gpu.device.gfx_target_version, 120500);
         assert_eq!(a.topology.links.len(), 6);

emulation/rocjitsu/configs/gfx1250.json → emulation/rocjitsu/configs/gfx1250_mi455x.json

@@ -3,7 +3,7 @@
   "num_threads": 1,
   "exec_mode": "functional",
   "vm": {
-    "arch": "gfx1250",
+    "arch": "cdna5",
     "gpu": {
       "device": {
         "gpu_id": 1250,

emulation/rocjitsu/docs/codegen.md

@@ -48,8 +48,9 @@ rocm-systems/shared/machine-readable-isa/isa/
 | Cross-ISA legalization tables | `lib/rocjitsu/src/rocjitsu/code/dbt/generated/` | `legalization_codegen.py` |
 | Encoding decode/encode functions | `lib/rocjitsu/src/rocjitsu/code/dbt/generated/` | `encoding_translator_codegen.py` |
 
-CDNA5's MR ISA name, logical architecture key, runtime target, ELF identity,
-configuration, and public DBT target identity remain `gfx1250`. Its filesystem
+CDNA5's logical generator key and configuration architecture are `cdna5`. Its
+MR ISA name and filename, concrete GPU/runtime target, ELF identity, and public
+DBT target identity intentionally remain `gfx1250`. Its filesystem
 directories, generated and hand-written C++ namespace (`rocjitsu::cdna5`), and
 internal CMake provider targets use `cdna5`.
 
@@ -88,8 +89,9 @@ generated.
 ## Regenerating everything
 
 The repository helper derives the repository, shared MR ISA, and generated
-output directories from its own location. Its argument is the CDNA5 MR ISA XML,
-whose concrete GPU filename and logical architecture key remain `gfx1250`.
+output directories from its own location. Its argument is the CDNA5 MR ISA XML
+with the concrete filename `amdgpu_isa_gfx1250.xml`; the logical generator key
+used by the command is `cdna5`.
 Activate a Python virtual environment containing the generator dependencies and
 `pre-commit`, then run this command from the `rocm-systems` repository root:
 
@@ -122,7 +124,7 @@ python -m amdisa \
     rdna3:$MRISA/amdgpu_isa_rdna3.xml \
     rdna3_5:$MRISA/amdgpu_isa_rdna3_5.xml \
     rdna4:$MRISA/amdgpu_isa_rdna4.xml \
-    gfx1250:$CDNA5_MRISA/amdgpu_isa_gfx1250.xml \
+    cdna5:$CDNA5_MRISA/amdgpu_isa_gfx1250.xml \
   --isa-output lib/rocjitsu/src/rocjitsu/isa/arch/amdgpu/generated \
   --dbt-output lib/rocjitsu/src/rocjitsu/code/dbt/generated
 
@@ -144,7 +146,7 @@ python -m amdisa \
     rdna3:$MRISA/amdgpu_isa_rdna3.xml \
     rdna3_5:$MRISA/amdgpu_isa_rdna3_5.xml \
     rdna4:$MRISA/amdgpu_isa_rdna4.xml \
-    gfx1250:$CDNA5_MRISA/amdgpu_isa_gfx1250.xml \
+    cdna5:$CDNA5_MRISA/amdgpu_isa_gfx1250.xml \
   --gen-isas \
   --isa-output lib/rocjitsu/src/rocjitsu/isa/arch/amdgpu/generated
 
@@ -166,7 +168,7 @@ python -m amdisa \
     rdna3:$MRISA/amdgpu_isa_rdna3.xml \
     rdna3_5:$MRISA/amdgpu_isa_rdna3_5.xml \
     rdna4:$MRISA/amdgpu_isa_rdna4.xml \
-    gfx1250:$CDNA5_MRISA/amdgpu_isa_gfx1250.xml \
+    cdna5:$CDNA5_MRISA/amdgpu_isa_gfx1250.xml \
   --gen-dbt \
   --dbt-output lib/rocjitsu/src/rocjitsu/code/dbt/generated
 

emulation/rocjitsu/docs/configuration.md

@@ -15,7 +15,7 @@ Pre-built simulator configs are in `configs/`:
 | `gfx950_cdna4.json` | Single CDNA4 GPU (standalone simulation) |
 | `gfx950_cdna4_kmd.json` | Single CDNA4 GPU (daemon/KFD mode) |
 | `gfx950_cdna4_kmd_2gpu.json` | Two CDNA4 GPUs (multi-GPU daemon mode) |
-| `gfx1250.json` | Single gfx1250 GPU (standalone simulation, no KMD) |
+| `gfx1250_mi455x.json` | Single CDNA5 GPU (standalone simulation, no KMD) |
 | `gfx1100_w7900.json` | Single RDNA3 GPU (standalone simulation) |
 | `gfx1151.json` | Single RDNA3.5 GPU (standalone simulation) |
 | `gfx1201_r9700.json` | Single RDNA4 GPU (standalone simulation) |

emulation/rocjitsu/lib/python/amdisa/__init__.py

@@ -15,7 +15,7 @@
     Cdna2Profile,
     CdnaProfile,
     EncodingModifier,
-    Gfx1250Profile,
+    Cdna5Profile,
     IsaProfile,
     MemoryCoherencyModel,
     MnemonicRule,
@@ -47,7 +47,7 @@
     'CodeGenerator',
     'CppFile',
     'EncodingModifier',
-    'Gfx1250Profile',
+    'Cdna5Profile',
     'InstEncoding',
     'Instruction',
     'IsaProfile',

emulation/rocjitsu/lib/python/amdisa/__main__.py

@@ -15,7 +15,7 @@
     CdnaProfile,
     CodegenConfig,
     CodeGenerator,
-    Gfx1250Profile,
+    Cdna5Profile,
     Parser,
     Rdna1Profile,
     Rdna2Profile,
@@ -51,7 +51,7 @@
     'rdna3': Rdna3Profile,
     'rdna3.5': Rdna3_5Profile,
     'rdna4': Rdna4Profile,
-    'gfx1250': Gfx1250Profile,
+    'cdna5': Cdna5Profile,
 }
 
 
@@ -118,7 +118,7 @@ def _detect_profile(isa_xml: str) -> str:
     # TODO: Remove this filename override once the gfx1250 XML carries a
     # finalized architecture name that can be detected through the normal path.
     if 'gfx1250' in Path(isa_xml).stem:
-        return 'gfx1250'
+        return 'cdna5'
 
     root = elem_tree.parse(isa_xml).getroot()
     isa_node = xs.get_node(root, xs.ISA)