Add rpath for rocff-test to help find libomp.so#995
Closed
assistant-librarian[bot] wants to merge 2 commits into
Closed
Add rpath for rocff-test to help find libomp.so#995assistant-librarian[bot] wants to merge 2 commits into
assistant-librarian[bot] wants to merge 2 commits into
Conversation
assistant-librarian
Bot
requested review from
af-ayala,
eng-flavio-teixeira,
evetsso,
feizheng10 and
malcolmroberts
as code owners
NguyenNhuDi
pushed a commit
to NguyenNhuDi/rocm-libraries
that referenced
this pull request
Aug 1, 2025
[ROCm/hipBLAS commit: 37f4421]
malcolmroberts
force-pushed
the
import/develop/malcolmroberts_rocFFT/omp_tests_list
branch
from
7196dfa to
f42b4c0
Compare
regan-amd
approved these changes
Aug 6, 2025
malcolmroberts
force-pushed
the
import/develop/malcolmroberts_rocFFT/omp_tests_list
branch
from
f42b4c0 to
b8289bb
Compare
eng-flavio-teixeira
approved these changes
Aug 6, 2025
Contributor
|
Closed in favour of #1004 |
vamovsik
pushed a commit
that referenced
this pull request
Sep 8, 2025
…ng libomp.so (#1308) ## Motivation Cherry-pick ~~#995~~ #1004 and #1164 to 7.0, to fix RHEL10/OL10. ## Technical Details Test executables have absolute rpaths, which are not allowed in RHEL10 and OL10. ## Test Plan Regular regression tests are now runnable via packages on these OSes. --------- Co-authored-by: assistant-librarian[bot] <210906412+assistant-librarian[bot]@users.noreply.github.com> Co-authored-by: Malcolm Roberts <malcolm.roberts@amd.com> Co-authored-by: regan-amd <Raphael.Egan@amd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #___
Summary of proposed changes:
🔁 Imported from ROCm/rocFFT#628
🧑💻 Originally authored by @malcolmroberts