Add rpath for rocfft-test and hipfft-test to help find libomp, and changes for rocm-libraries CI#1004
Merged
amd-aakash merged 16 commits intoAug 11, 2025
Conversation
assistant-librarian
Bot
requested review from
eng-flavio-teixeira,
evetsso,
feizheng10 and
malcolmroberts
as code owners
regan-amd
reviewed
Jul 31, 2025
Contributor
regan-amd
left a comment
regan-amd
left a comment
There was a problem hiding this comment.
Transferring my most recent comments from the now-deprecated repo.
NguyenNhuDi
pushed a commit
to NguyenNhuDi/rocm-libraries
that referenced
this pull request
Aug 1, 2025
Bumps [rocm-docs-core](https://github.com/ROCm/rocm-docs-core) from 1.18.2 to 1.18.4. - [Release notes](https://github.com/ROCm/rocm-docs-core/releases) - [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md) - [Commits](ROCm/rocm-docs-core@v1.18.2...v1.18.4) --- updated-dependencies: - dependency-name: rocm-docs-core dependency-version: 1.18.4 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> [ROCm/hipBLAS commit: f6fbd8f]
xiaohuguo2023
pushed a commit
to xiaohuguo2023/rocm-libraries
that referenced
this pull request
Aug 3, 2025
[ROCm/rocSPARSEcommit: d121d5a]
Fix linking directory to fix clients compilation. Allow for building from clients/tests.
malcolmroberts
force-pushed
the
import/develop/malcolmroberts_hipFFT/omprpath
branch
from
2faa199 to
41590ef
Compare
regan-amd
reviewed
Aug 7, 2025
Contributor
regan-amd
left a comment
regan-amd
left a comment
There was a problem hiding this comment.
It's not obvious to me how/whether rocfft-test's rpath was also updated to find libomp: could you clarify?
malcolmroberts
changed the title
regan-amd
approved these changes
Aug 8, 2025
eng-flavio-teixeira
approved these changes
Aug 8, 2025
evetsso
approved these changes
Aug 8, 2025
af-ayala
approved these changes
Aug 8, 2025
regan-amd
approved these changes
Aug 8, 2025
Contributor
|
Windows is failing with a java exception: issue |
Contributor
|
rocm examples are still having trouble. Issue: #1128 |
Contributor
|
The Azure CI summary is taking 6 hours (so far). Issue: #1129 |
malcolmroberts
changed the title
Collaborator
|
Gardner Override based on
|
amd-garydeng
pushed a commit
that referenced
this pull request
Aug 13, 2025
…anges for rocm-libraries CI (#1004) --- 🔁 Imported from [ROCm/hipFFT#173](ROCm/hipFFT#173) 🧑💻 Originally authored by @malcolmroberts --------- Co-authored-by: Malcolm Roberts <malcolm.roberts@amd.com> Co-authored-by: Malcolm Roberts <malcolm.i.w.roberts@gmail.com>
vamovsik
pushed a commit
that referenced
this pull request
Sep 8, 2025
…ng libomp.so (#1308) ## Motivation Cherry-pick ~~#995~~ #1004 and #1164 to 7.0, to fix RHEL10/OL10. ## Technical Details Test executables have absolute rpaths, which are not allowed in RHEL10 and OL10. ## Test Plan Regular regression tests are now runnable via packages on these OSes. --------- Co-authored-by: assistant-librarian[bot] <210906412+assistant-librarian[bot]@users.noreply.github.com> Co-authored-by: Malcolm Roberts <malcolm.roberts@amd.com> Co-authored-by: regan-amd <Raphael.Egan@amd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔁 Imported from ROCm/hipFFT#173
🧑💻 Originally authored by @malcolmroberts