Adding auto-allocation logic for rocfft tests#993
Merged
regan-amd merged 1 commit intoAug 27, 2025
Conversation
assistant-librarian
Bot
requested review from
af-ayala,
eng-flavio-teixeira,
evetsso,
feizheng10 and
malcolmroberts
as code owners
NguyenNhuDi
pushed a commit
to NguyenNhuDi/rocm-libraries
that referenced
this pull request
Aug 1, 2025
[ROCm/hipBLAS commit: 9bbe64c]
regan-amd
force-pushed
the
import/develop/regan-amd_rocFFT/auto_alloc_rocfft
branch
from
d70e95f to
05e9c9a
Compare
regan-amd
force-pushed
the
import/develop/regan-amd_rocFFT/auto_alloc_rocfft
branch
from
05e9c9a to
a255112
Compare
malcolmroberts
approved these changes
Aug 26, 2025
regan-amd
deleted the
import/develop/regan-amd_rocFFT/auto_alloc_rocfft
branch
assistant-librarian Bot
pushed a commit
to ROCm/rocFFT
that referenced
this pull request
Aug 27, 2025
Adding auto-allocation logic for rocfft tests MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Following up here upon completion of ROCm/hipFFT#160. Note: 1. if auto-allocation is used, plans allocate resources at execution for rocFFT whereas they do it at plan generation for hipFFT; 2. "default" auto-allocation flag for rocFFT tests is equivalent to "off", while "default" auto-allocation behavior for hipFFT tests is equivalent to "on", consistently with the above; 3. If "on" auto-allocation flag is used for a rocFFT test, that would force the underlying plan to allocate resources at execution time. It might be best to have a warning printed by bench in that case?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following up here upon completion of ROCm/hipFFT#160.
Note:
🔁 Imported from ROCm/rocFFT#626
🧑💻 Originally authored by @regan-amd