Adding auto-allocation logic for rocfft tests#626
Closed
regan-amd wants to merge 1 commit into
Closed
Conversation
regan-amd
requested review from
af-ayala,
eng-flavio-teixeira,
evetsso and
malcolmroberts
as code owners
Contributor
|
Imported to ROCm/rocm-libraries |
regan-amd
added a commit
to ROCm/rocm-libraries
that referenced
this pull request
Aug 27, 2025
Following up here upon completion of ROCm/hipFFT#160. Note: 1. if auto-allocation is used, plans allocate resources at execution for rocFFT whereas they do it at plan generation for hipFFT; 2. "default" auto-allocation flag for rocFFT tests is equivalent to "off", while "default" auto-allocation behavior for hipFFT tests is equivalent to "on", consistently with the above; 3. If "on" auto-allocation flag is used for a rocFFT test, that would force the underlying plan to allocate resources at execution time. It might be best to have a warning printed by bench in that case? --- 🔁 Imported from [ROCm/rocFFT#626](ROCm/rocFFT#626) 🧑💻 Originally authored by @regan-amd Co-authored-by: Raphael Egan <Raphael.Egan@amd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following up here upon completion of ROCm/hipFFT#160.
Note: