Repository navigation
Conversation
The current therock_configure_ci.py doesn't have a clean way to only configure the project that has changed, and not other components that the changed component has been grouped together with. For code coverage reports, it does not make sense to even test downstream components.
|
🎉 All checks passed! This PR is ready for review. |
reboss
requested changes
Jul 13, 2026
reboss
left a comment
reboss
left a comment
Member
There was a problem hiding this comment.
Please reduce the scope of this PR to just the changes needed for adding codecov.io upload tools to the docker container.
1 task
jainprad
added a commit
to jainprad/rocm-libraries
that referenced
this pull request
Jul 21, 2026
Per review, the Codecov config + upload tooling now live in a dedicated PR (users/jainprad/codecoverage_codecov_tool, ROCm#9288). Remove the "Upload coverage to Codecov" step here; this PR builds, tests, and produces the coverage report artifact only. The job summary points to the Codecov PR. Co-authored-by: Cursor <cursoragent@cursor.com>
reboss
pushed a commit
that referenced
this pull request
Jul 21, 2026
Per review, the Codecov config + upload tooling now live in a dedicated PR (users/jainprad/codecoverage_codecov_tool, #9288). Remove the "Upload coverage to Codecov" step here; this PR builds, tests, and produces the coverage report artifact only. The job summary points to the Codecov PR. Co-authored-by: Cursor <cursoragent@cursor.com>
jainprad
added a commit
to jainprad/rocm-libraries
that referenced
this pull request
Jul 21, 2026
Per review, the Codecov config + upload tooling now live in a dedicated PR (users/jainprad/codecoverage_codecov_tool, ROCm#9288). Remove the "Upload coverage to Codecov" step here; this PR builds, tests, and produces the coverage report artifact only. The job summary points to the Codecov PR. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
Closing because there are 10 of these open. |
reboss
pushed a commit
that referenced
this pull request
Jul 23, 2026
Per review, the Codecov config + upload tooling now live in a dedicated PR (users/jainprad/codecoverage_codecov_tool, #9288). Remove the "Upload coverage to Codecov" step here; this PR builds, tests, and produces the coverage report artifact only. The job summary points to the Codecov PR. Co-authored-by: Cursor <cursoragent@cursor.com>
reboss
pushed a commit
that referenced
this pull request
Jul 23, 2026
Per review, the Codecov config + upload tooling now live in a dedicated PR (users/jainprad/codecoverage_codecov_tool, #9288). Remove the "Upload coverage to Codecov" step here; this PR builds, tests, and produces the coverage report artifact only. The job summary points to the Codecov PR. Co-authored-by: Cursor <cursoragent@cursor.com>
reboss
pushed a commit
that referenced
this pull request
Jul 24, 2026
Per review, the Codecov config + upload tooling now live in a dedicated PR (users/jainprad/codecoverage_codecov_tool, #9288). Remove the "Upload coverage to Codecov" step here; this PR builds, tests, and produces the coverage report artifact only. The job summary points to the Codecov PR. Co-authored-by: Cursor <cursoragent@cursor.com>
reboss
pushed a commit
that referenced
this pull request
Jul 27, 2026
Per review, the Codecov config + upload tooling now live in a dedicated PR (users/jainprad/codecoverage_codecov_tool, #9288). Remove the "Upload coverage to Codecov" step here; this PR builds, tests, and produces the coverage report artifact only. The job summary points to the Codecov PR. Co-authored-by: Cursor <cursoragent@cursor.com>
reboss
pushed a commit
that referenced
this pull request
Jul 27, 2026
Per review, the Codecov config + upload tooling now live in a dedicated PR (users/jainprad/codecoverage_codecov_tool, #9288). Remove the "Upload coverage to Codecov" step here; this PR builds, tests, and produces the coverage report artifact only. The job summary points to the Codecov PR. Co-authored-by: Cursor <cursoragent@cursor.com>
reboss
pushed a commit
that referenced
this pull request
Jul 29, 2026
Per review, the Codecov config + upload tooling now live in a dedicated PR (users/jainprad/codecoverage_codecov_tool, #9288). Remove the "Upload coverage to Codecov" step here; this PR builds, tests, and produces the coverage report artifact only. The job summary points to the Codecov PR. Co-authored-by: Cursor <cursoragent@cursor.com>
reboss
pushed a commit
that referenced
this pull request
Jul 29, 2026
Per review, the Codecov config + upload tooling now live in a dedicated PR (users/jainprad/codecoverage_codecov_tool, #9288). Remove the "Upload coverage to Codecov" step here; this PR builds, tests, and produces the coverage report artifact only. The job summary points to the Codecov PR. Co-authored-by: Cursor <cursoragent@cursor.com>
reboss
pushed a commit
that referenced
this pull request
Jul 29, 2026
Per review, the Codecov config + upload tooling now live in a dedicated PR (users/jainprad/codecoverage_codecov_tool, #9288). Remove the "Upload coverage to Codecov" step here; this PR builds, tests, and produces the coverage report artifact only. The job summary points to the Codecov PR. Co-authored-by: Cursor <cursoragent@cursor.com>
reboss
pushed a commit
that referenced
this pull request
Jul 29, 2026
Per review, the Codecov config + upload tooling now live in a dedicated PR (users/jainprad/codecoverage_codecov_tool, #9288). Remove the "Upload coverage to Codecov" step here; this PR builds, tests, and produces the coverage report artifact only. The job summary points to the Codecov PR. Co-authored-by: Cursor <cursoragent@cursor.com>
reboss
pushed a commit
that referenced
this pull request
Jul 29, 2026
Per review, the Codecov config + upload tooling now live in a dedicated PR (users/jainprad/codecoverage_codecov_tool, #9288). Remove the "Upload coverage to Codecov" step here; this PR builds, tests, and produces the coverage report artifact only. The job summary points to the Codecov PR. Co-authored-by: Cursor <cursoragent@cursor.com>
reboss
pushed a commit
that referenced
this pull request
Aug 6, 2026
Per review, the Codecov config + upload tooling now live in a dedicated PR (users/jainprad/codecoverage_codecov_tool, #9288). Remove the "Upload coverage to Codecov" step here; this PR builds, tests, and produces the coverage report artifact only. The job summary points to the Codecov PR. Co-authored-by: Cursor <cursoragent@cursor.com>
reboss
pushed a commit
that referenced
this pull request
Aug 10, 2026
Per review, the Codecov config + upload tooling now live in a dedicated PR (users/jainprad/codecoverage_codecov_tool, #9288). Remove the "Upload coverage to Codecov" step here; this PR builds, tests, and produces the coverage report artifact only. The job summary points to the Codecov PR. Co-authored-by: Cursor <cursoragent@cursor.com>
reboss
pushed a commit
that referenced
this pull request
Aug 10, 2026
Per review, the Codecov config + upload tooling now live in a dedicated PR (users/jainprad/codecoverage_codecov_tool, #9288). Remove the "Upload coverage to Codecov" step here; this PR builds, tests, and produces the coverage report artifact only. The job summary points to the Codecov PR. Co-authored-by: Cursor <cursoragent@cursor.com>
reboss
pushed a commit
that referenced
this pull request
Aug 12, 2026
Per review, the Codecov config + upload tooling now live in a dedicated PR (users/jainprad/codecoverage_codecov_tool, #9288). Remove the "Upload coverage to Codecov" step here; this PR builds, tests, and produces the coverage report artifact only. The job summary points to the Codecov PR. Co-authored-by: Cursor <cursoragent@cursor.com>
reboss
pushed a commit
that referenced
this pull request
Aug 13, 2026
Per review, the Codecov config + upload tooling now live in a dedicated PR (users/jainprad/codecoverage_codecov_tool, #9288). Remove the "Upload coverage to Codecov" step here; this PR builds, tests, and produces the coverage report artifact only. The job summary points to the Codecov PR. Co-authored-by: Cursor <cursoragent@cursor.com>
reboss
pushed a commit
that referenced
this pull request
Aug 14, 2026
Per review, the Codecov config + upload tooling now live in a dedicated PR (users/jainprad/codecoverage_codecov_tool, #9288). Remove the "Upload coverage to Codecov" step here; this PR builds, tests, and produces the coverage report artifact only. The job summary points to the Codecov PR. Co-authored-by: Cursor <cursoragent@cursor.com>
reboss
pushed a commit
that referenced
this pull request
Aug 14, 2026
Per review, the Codecov config + upload tooling now live in a dedicated PR (users/jainprad/codecoverage_codecov_tool, #9288). Remove the "Upload coverage to Codecov" step here; this PR builds, tests, and produces the coverage report artifact only. The job summary points to the Codecov PR. Co-authored-by: Cursor <cursoragent@cursor.com>
reboss
pushed a commit
that referenced
this pull request
Aug 14, 2026
Per review, the Codecov config + upload tooling now live in a dedicated PR (users/jainprad/codecoverage_codecov_tool, #9288). Remove the "Upload coverage to Codecov" step here; this PR builds, tests, and produces the coverage report artifact only. The job summary points to the Codecov PR. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Dedicated PR for the Codecov integration, split out from the coverage-generation work per review feedback (reboss: keep codecov config + upload tooling separate).
This PR owns:
codecov.yml— the per-component flag/target configuration.therock-ci-coverage.yml— installscodecovcliand uploads the LCOV report (token for non-fork/postsubmit; tokenlessowner:branchpath for fork PRs). Adds the required--git-service githubso the tokenless upload completes (without a tokencodecovclicannot infer the git provider → "Upload service is missing").Branched from the coverage infrastructure (following #9221's
users/<user>/…→developconvention), so it runs standalone.Relationship to the other coverage PRs
Follow-up (separate, reboss #470)
Baking
codecov-cliinto the build container (instead ofpip installat runtime) is a TheRock container change and will be handled separately (cc @geomin12).Test plan
Made with Cursor
Made with Cursor