Repository navigation
Conversation
The current therock_configure_ci.py doesn't have a clean way to only configure the project that has changed, and not other components that the changed component has been grouped together with. For code coverage reports, it does not make sense to even test downstream components.
reboss
pushed a commit
that referenced
this pull request
Jul 27, 2026
…ents only Header-only coverage (rocPRIM/hipCUB/rocThrust) is split into its own PR (users/jainprad/codecoverage_lib_header_only -> develop, #9287). Remove it here: - the disabled header-only metadata dict in therock_configure_coverage.py - the *_ENABLE_COVERAGE options + instrumentation blocks in the rocPRIM/hipCUB/ rocThrust CMakeLists (pre-existing BUILD_CODE_COVERAGE/CODE_COVERAGE untouched) This PR now covers only the shared-object components: hipRAND, rocRAND, rocFFT, rocBLAS. Co-authored-by: Cursor <cursoragent@cursor.com>
reboss
pushed a commit
that referenced
this pull request
Jul 27, 2026
The prior cleanup deleted the pre-existing if(BUILD_CODE_COVERAGE) / if(CODE_COVERAGE) instrumentation blocks instead of only reverting the <PROJECT>_ENABLE_COVERAGE guard rename, so the PR still modified these files. Restore all three to develop verbatim so this PR does not touch the header-only projects at all (they live in #9287). Co-authored-by: Cursor <cursoragent@cursor.com>
reboss
pushed a commit
that referenced
this pull request
Jul 27, 2026
…ents only Header-only coverage (rocPRIM/hipCUB/rocThrust) is split into its own PR (users/jainprad/codecoverage_lib_header_only -> develop, #9287). Remove it here: - the disabled header-only metadata dict in therock_configure_coverage.py - the *_ENABLE_COVERAGE options + instrumentation blocks in the rocPRIM/hipCUB/ rocThrust CMakeLists (pre-existing BUILD_CODE_COVERAGE/CODE_COVERAGE untouched) This PR now covers only the shared-object components: hipRAND, rocRAND, rocFFT, rocBLAS. Co-authored-by: Cursor <cursoragent@cursor.com>
reboss
pushed a commit
that referenced
this pull request
Jul 27, 2026
The prior cleanup deleted the pre-existing if(BUILD_CODE_COVERAGE) / if(CODE_COVERAGE) instrumentation blocks instead of only reverting the <PROJECT>_ENABLE_COVERAGE guard rename, so the PR still modified these files. Restore all three to develop verbatim so this PR does not touch the header-only projects at all (they live in #9287). Co-authored-by: Cursor <cursoragent@cursor.com>
reboss
pushed a commit
that referenced
this pull request
Jul 29, 2026
…ents only Header-only coverage (rocPRIM/hipCUB/rocThrust) is split into its own PR (users/jainprad/codecoverage_lib_header_only -> develop, #9287). Remove it here: - the disabled header-only metadata dict in therock_configure_coverage.py - the *_ENABLE_COVERAGE options + instrumentation blocks in the rocPRIM/hipCUB/ rocThrust CMakeLists (pre-existing BUILD_CODE_COVERAGE/CODE_COVERAGE untouched) This PR now covers only the shared-object components: hipRAND, rocRAND, rocFFT, rocBLAS. Co-authored-by: Cursor <cursoragent@cursor.com>
reboss
pushed a commit
that referenced
this pull request
Jul 29, 2026
The prior cleanup deleted the pre-existing if(BUILD_CODE_COVERAGE) / if(CODE_COVERAGE) instrumentation blocks instead of only reverting the <PROJECT>_ENABLE_COVERAGE guard rename, so the PR still modified these files. Restore all three to develop verbatim so this PR does not touch the header-only projects at all (they live in #9287). Co-authored-by: Cursor <cursoragent@cursor.com>
reboss
pushed a commit
that referenced
this pull request
Jul 29, 2026
…ents only Header-only coverage (rocPRIM/hipCUB/rocThrust) is split into its own PR (users/jainprad/codecoverage_lib_header_only -> develop, #9287). Remove it here: - the disabled header-only metadata dict in therock_configure_coverage.py - the *_ENABLE_COVERAGE options + instrumentation blocks in the rocPRIM/hipCUB/ rocThrust CMakeLists (pre-existing BUILD_CODE_COVERAGE/CODE_COVERAGE untouched) This PR now covers only the shared-object components: hipRAND, rocRAND, rocFFT, rocBLAS. Co-authored-by: Cursor <cursoragent@cursor.com>
reboss
pushed a commit
that referenced
this pull request
Jul 29, 2026
The prior cleanup deleted the pre-existing if(BUILD_CODE_COVERAGE) / if(CODE_COVERAGE) instrumentation blocks instead of only reverting the <PROJECT>_ENABLE_COVERAGE guard rename, so the PR still modified these files. Restore all three to develop verbatim so this PR does not touch the header-only projects at all (they live in #9287). Co-authored-by: Cursor <cursoragent@cursor.com>
reboss
pushed a commit
that referenced
this pull request
Jul 29, 2026
…ents only Header-only coverage (rocPRIM/hipCUB/rocThrust) is split into its own PR (users/jainprad/codecoverage_lib_header_only -> develop, #9287). Remove it here: - the disabled header-only metadata dict in therock_configure_coverage.py - the *_ENABLE_COVERAGE options + instrumentation blocks in the rocPRIM/hipCUB/ rocThrust CMakeLists (pre-existing BUILD_CODE_COVERAGE/CODE_COVERAGE untouched) This PR now covers only the shared-object components: hipRAND, rocRAND, rocFFT, rocBLAS. Co-authored-by: Cursor <cursoragent@cursor.com>
reboss
pushed a commit
that referenced
this pull request
Jul 29, 2026
The prior cleanup deleted the pre-existing if(BUILD_CODE_COVERAGE) / if(CODE_COVERAGE) instrumentation blocks instead of only reverting the <PROJECT>_ENABLE_COVERAGE guard rename, so the PR still modified these files. Restore all three to develop verbatim so this PR does not touch the header-only projects at all (they live in #9287). Co-authored-by: Cursor <cursoragent@cursor.com>
reboss
pushed a commit
that referenced
this pull request
Jul 29, 2026
…ents only Header-only coverage (rocPRIM/hipCUB/rocThrust) is split into its own PR (users/jainprad/codecoverage_lib_header_only -> develop, #9287). Remove it here: - the disabled header-only metadata dict in therock_configure_coverage.py - the *_ENABLE_COVERAGE options + instrumentation blocks in the rocPRIM/hipCUB/ rocThrust CMakeLists (pre-existing BUILD_CODE_COVERAGE/CODE_COVERAGE untouched) This PR now covers only the shared-object components: hipRAND, rocRAND, rocFFT, rocBLAS. Co-authored-by: Cursor <cursoragent@cursor.com>
reboss
pushed a commit
that referenced
this pull request
Jul 29, 2026
The prior cleanup deleted the pre-existing if(BUILD_CODE_COVERAGE) / if(CODE_COVERAGE) instrumentation blocks instead of only reverting the <PROJECT>_ENABLE_COVERAGE guard rename, so the PR still modified these files. Restore all three to develop verbatim so this PR does not touch the header-only projects at all (they live in #9287). Co-authored-by: Cursor <cursoragent@cursor.com>
reboss
pushed a commit
that referenced
this pull request
Jul 29, 2026
…ents only Header-only coverage (rocPRIM/hipCUB/rocThrust) is split into its own PR (users/jainprad/codecoverage_lib_header_only -> develop, #9287). Remove it here: - the disabled header-only metadata dict in therock_configure_coverage.py - the *_ENABLE_COVERAGE options + instrumentation blocks in the rocPRIM/hipCUB/ rocThrust CMakeLists (pre-existing BUILD_CODE_COVERAGE/CODE_COVERAGE untouched) This PR now covers only the shared-object components: hipRAND, rocRAND, rocFFT, rocBLAS. Co-authored-by: Cursor <cursoragent@cursor.com>
reboss
pushed a commit
that referenced
this pull request
Jul 29, 2026
The prior cleanup deleted the pre-existing if(BUILD_CODE_COVERAGE) / if(CODE_COVERAGE) instrumentation blocks instead of only reverting the <PROJECT>_ENABLE_COVERAGE guard rename, so the PR still modified these files. Restore all three to develop verbatim so this PR does not touch the header-only projects at all (they live in #9287). Co-authored-by: Cursor <cursoragent@cursor.com>
reboss
pushed a commit
that referenced
this pull request
Aug 6, 2026
…ents only Header-only coverage (rocPRIM/hipCUB/rocThrust) is split into its own PR (users/jainprad/codecoverage_lib_header_only -> develop, #9287). Remove it here: - the disabled header-only metadata dict in therock_configure_coverage.py - the *_ENABLE_COVERAGE options + instrumentation blocks in the rocPRIM/hipCUB/ rocThrust CMakeLists (pre-existing BUILD_CODE_COVERAGE/CODE_COVERAGE untouched) This PR now covers only the shared-object components: hipRAND, rocRAND, rocFFT, rocBLAS. Co-authored-by: Cursor <cursoragent@cursor.com>
reboss
pushed a commit
that referenced
this pull request
Aug 6, 2026
The prior cleanup deleted the pre-existing if(BUILD_CODE_COVERAGE) / if(CODE_COVERAGE) instrumentation blocks instead of only reverting the <PROJECT>_ENABLE_COVERAGE guard rename, so the PR still modified these files. Restore all three to develop verbatim so this PR does not touch the header-only projects at all (they live in #9287). Co-authored-by: Cursor <cursoragent@cursor.com>
reboss
pushed a commit
that referenced
this pull request
Aug 10, 2026
…ents only Header-only coverage (rocPRIM/hipCUB/rocThrust) is split into its own PR (users/jainprad/codecoverage_lib_header_only -> develop, #9287). Remove it here: - the disabled header-only metadata dict in therock_configure_coverage.py - the *_ENABLE_COVERAGE options + instrumentation blocks in the rocPRIM/hipCUB/ rocThrust CMakeLists (pre-existing BUILD_CODE_COVERAGE/CODE_COVERAGE untouched) This PR now covers only the shared-object components: hipRAND, rocRAND, rocFFT, rocBLAS. Co-authored-by: Cursor <cursoragent@cursor.com>
reboss
pushed a commit
that referenced
this pull request
Aug 10, 2026
The prior cleanup deleted the pre-existing if(BUILD_CODE_COVERAGE) / if(CODE_COVERAGE) instrumentation blocks instead of only reverting the <PROJECT>_ENABLE_COVERAGE guard rename, so the PR still modified these files. Restore all three to develop verbatim so this PR does not touch the header-only projects at all (they live in #9287). Co-authored-by: Cursor <cursoragent@cursor.com>
reboss
pushed a commit
that referenced
this pull request
Aug 10, 2026
…ents only Header-only coverage (rocPRIM/hipCUB/rocThrust) is split into its own PR (users/jainprad/codecoverage_lib_header_only -> develop, #9287). Remove it here: - the disabled header-only metadata dict in therock_configure_coverage.py - the *_ENABLE_COVERAGE options + instrumentation blocks in the rocPRIM/hipCUB/ rocThrust CMakeLists (pre-existing BUILD_CODE_COVERAGE/CODE_COVERAGE untouched) This PR now covers only the shared-object components: hipRAND, rocRAND, rocFFT, rocBLAS. Co-authored-by: Cursor <cursoragent@cursor.com>
reboss
pushed a commit
that referenced
this pull request
Aug 10, 2026
The prior cleanup deleted the pre-existing if(BUILD_CODE_COVERAGE) / if(CODE_COVERAGE) instrumentation blocks instead of only reverting the <PROJECT>_ENABLE_COVERAGE guard rename, so the PR still modified these files. Restore all three to develop verbatim so this PR does not touch the header-only projects at all (they live in #9287). Co-authored-by: Cursor <cursoragent@cursor.com>
reboss
pushed a commit
that referenced
this pull request
Aug 12, 2026
…ents only Header-only coverage (rocPRIM/hipCUB/rocThrust) is split into its own PR (users/jainprad/codecoverage_lib_header_only -> develop, #9287). Remove it here: - the disabled header-only metadata dict in therock_configure_coverage.py - the *_ENABLE_COVERAGE options + instrumentation blocks in the rocPRIM/hipCUB/ rocThrust CMakeLists (pre-existing BUILD_CODE_COVERAGE/CODE_COVERAGE untouched) This PR now covers only the shared-object components: hipRAND, rocRAND, rocFFT, rocBLAS. Co-authored-by: Cursor <cursoragent@cursor.com>
reboss
pushed a commit
that referenced
this pull request
Aug 12, 2026
The prior cleanup deleted the pre-existing if(BUILD_CODE_COVERAGE) / if(CODE_COVERAGE) instrumentation blocks instead of only reverting the <PROJECT>_ENABLE_COVERAGE guard rename, so the PR still modified these files. Restore all three to develop verbatim so this PR does not touch the header-only projects at all (they live in #9287). Co-authored-by: Cursor <cursoragent@cursor.com>
reboss
pushed a commit
that referenced
this pull request
Aug 13, 2026
…ents only Header-only coverage (rocPRIM/hipCUB/rocThrust) is split into its own PR (users/jainprad/codecoverage_lib_header_only -> develop, #9287). Remove it here: - the disabled header-only metadata dict in therock_configure_coverage.py - the *_ENABLE_COVERAGE options + instrumentation blocks in the rocPRIM/hipCUB/ rocThrust CMakeLists (pre-existing BUILD_CODE_COVERAGE/CODE_COVERAGE untouched) This PR now covers only the shared-object components: hipRAND, rocRAND, rocFFT, rocBLAS. Co-authored-by: Cursor <cursoragent@cursor.com>
reboss
pushed a commit
that referenced
this pull request
Aug 13, 2026
The prior cleanup deleted the pre-existing if(BUILD_CODE_COVERAGE) / if(CODE_COVERAGE) instrumentation blocks instead of only reverting the <PROJECT>_ENABLE_COVERAGE guard rename, so the PR still modified these files. Restore all three to develop verbatim so this PR does not touch the header-only projects at all (they live in #9287). Co-authored-by: Cursor <cursoragent@cursor.com>
reboss
pushed a commit
that referenced
this pull request
Aug 14, 2026
…ents only Header-only coverage (rocPRIM/hipCUB/rocThrust) is split into its own PR (users/jainprad/codecoverage_lib_header_only -> develop, #9287). Remove it here: - the disabled header-only metadata dict in therock_configure_coverage.py - the *_ENABLE_COVERAGE options + instrumentation blocks in the rocPRIM/hipCUB/ rocThrust CMakeLists (pre-existing BUILD_CODE_COVERAGE/CODE_COVERAGE untouched) This PR now covers only the shared-object components: hipRAND, rocRAND, rocFFT, rocBLAS. Co-authored-by: Cursor <cursoragent@cursor.com>
reboss
pushed a commit
that referenced
this pull request
Aug 14, 2026
The prior cleanup deleted the pre-existing if(BUILD_CODE_COVERAGE) / if(CODE_COVERAGE) instrumentation blocks instead of only reverting the <PROJECT>_ENABLE_COVERAGE guard rename, so the PR still modified these files. Restore all three to develop verbatim so this PR does not touch the header-only projects at all (they live in #9287). Co-authored-by: Cursor <cursoragent@cursor.com>
reboss
pushed a commit
that referenced
this pull request
Aug 14, 2026
…ents only Header-only coverage (rocPRIM/hipCUB/rocThrust) is split into its own PR (users/jainprad/codecoverage_lib_header_only -> develop, #9287). Remove it here: - the disabled header-only metadata dict in therock_configure_coverage.py - the *_ENABLE_COVERAGE options + instrumentation blocks in the rocPRIM/hipCUB/ rocThrust CMakeLists (pre-existing BUILD_CODE_COVERAGE/CODE_COVERAGE untouched) This PR now covers only the shared-object components: hipRAND, rocRAND, rocFFT, rocBLAS. Co-authored-by: Cursor <cursoragent@cursor.com>
reboss
pushed a commit
that referenced
this pull request
Aug 14, 2026
The prior cleanup deleted the pre-existing if(BUILD_CODE_COVERAGE) / if(CODE_COVERAGE) instrumentation blocks instead of only reverting the <PROJECT>_ENABLE_COVERAGE guard rename, so the PR still modified these files. Restore all three to develop verbatim so this PR does not touch the header-only projects at all (they live in #9287). Co-authored-by: Cursor <cursoragent@cursor.com>
reboss
pushed a commit
that referenced
this pull request
Aug 14, 2026
…ents only Header-only coverage (rocPRIM/hipCUB/rocThrust) is split into its own PR (users/jainprad/codecoverage_lib_header_only -> develop, #9287). Remove it here: - the disabled header-only metadata dict in therock_configure_coverage.py - the *_ENABLE_COVERAGE options + instrumentation blocks in the rocPRIM/hipCUB/ rocThrust CMakeLists (pre-existing BUILD_CODE_COVERAGE/CODE_COVERAGE untouched) This PR now covers only the shared-object components: hipRAND, rocRAND, rocFFT, rocBLAS. Co-authored-by: Cursor <cursoragent@cursor.com>
reboss
pushed a commit
that referenced
this pull request
Aug 14, 2026
The prior cleanup deleted the pre-existing if(BUILD_CODE_COVERAGE) / if(CODE_COVERAGE) instrumentation blocks instead of only reverting the <PROJECT>_ENABLE_COVERAGE guard rename, so the PR still modified these files. Restore all three to develop verbatim so this PR does not touch the header-only projects at all (they live in #9287). Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enables code-coverage CI for the header-only libraries — rocPRIM, hipCUB, rocThrust — split out from the shared-object coverage work (hipRAND/rocRAND/rocFFT/rocBLAS, tracked in #8656). Header-only libraries have no shared object to instrument, so coverage is collected from their instrumented test binaries.
Branched from the coverage infrastructure (following #9221's
users/<user>/…→developconvention) and scoped to the header-only components.Changes
.github/scripts/therock_configure_coverage.py: coverage matrix = rocPRIM / hipCUB / rocThrust (PRIM group), each with a per-projectcoverage_configpath.test_categories_coverage.yamlunder each project'stest/dir (test-binary name prefixes); the combined root file is removed andexport_coverage_metadata.pynow reads the flat per-project file..github/workflows/therock-ci-coverage.yml: the report step passes the staged instrumented test binaries (coverage-objects/test/*) tollvm-covas-object;coverage_configis threaded through the matrix.projects/rocthrust/cmake/Dependencies.cmake: fall back to the bundled SQLite when the system package is unsuitable (TheRock coverage builds report SQLite version "unknown"), so the PRIM-group configure step does not hard-fail.codecov.yml: add therocPRIMflag.Test plan
rocPRIM/hipCUB/rocThrustMade with Cursor
Made with Cursor