Repository navigation
Conversation
github-actions
Bot
added
project: hipblaslt
project: hipsparselt
ci:hipsparselt-fast
labels
Codecov Report❌ Patch coverage is ❌ Your project status has failed because the head coverage (77.83%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #8409 +/- ##
===========================================
- Coverage 65.04% 65.04% -0.00%
===========================================
Files 2597 2597
Lines 403887 403891 +4
Branches 60168 60168
===========================================
- Hits 262695 262690 -5
- Misses 121963 121972 +9
Partials 19229 19229
*This pull request uses carry forward flags. Click here to find out more.
🚀 New features to boost your workflow:
|
mengzcai
force-pushed
the
users/mengzcai/reduce-test
branch
2 times, most recently
from
June 15, 2026 08:01
1337562 to
6b08743
Compare
mengzcai
changed the title
mengzcai
force-pushed
the
users/mengzcai/reduce-test
branch
from
June 15, 2026 09:59
6b08743 to
12705c7
Compare
see default LDS size in hardware_caps.hpp
Defer SIA0 non-TDM PGR2 global reads until after the local-write iteration consumes the previous vgprG2L values, and keep tail local-read offsets reset before tail MACs. This prevents next-prefetch buffer loads from clobbering data before it is stored to LDS.
mengzcai
force-pushed
the
users/mengzcai/reduce-test
branch
from
June 15, 2026 18:38
12705c7 to
756d30e
Compare
added 2 commits
June 15, 2026 18:47
Before: TDM + double-buffer tail forced the tail LR offsets back to
buffer0, but the TDM write pointer may stay at buffer1.
(after an odd number of main-loop iters)
After: No longer forces buffer 0 in the tail, unless wider local read
needs the offset recomputed (numReadsIterCoalesced>1).
Repro/affected tests: TDM kernels with a tail
e.g. bf6_tdm_gfx1250, tdm_gfx1250, ...
1. Set LDS>=64KB and 1LDSB and SIA0 to reproduce the issue 2. Fix test yaml: f64_gfx1250 (using LocalReadVALU)
mengzcai
force-pushed
the
users/mengzcai/reduce-test
branch
from
June 15, 2026 18:57
756d30e to
afcc188
Compare
mengzcai
changed the title
mengzcai
changed the title
Contributor
|
This pull request has been inactive for 25 days and will be marked as stale. If you would like to keep this PR open, please:
This PR will be automatically closed in 5 days if no further activity occurs. |
Contributor
|
This pull request has been automatically closed due to inactivity (30 days with no updates). If you'd like to continue working on this, feel free to reopen the PR or create a new one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Waiting for #8417 to be merged.
Waiting for #8406 to be merged.
Motivation
Set SIA and 1LDSBuffer to 0, and remove deviceLDS and maxLDS in test yamls.
Fix kernel bugs:
The gfx1250 mxf8/mxf4 test yamls fork a near-full Cartesian product of kernel parameters and run it against large problem sizes. This makes the FFM test pass slow (~89 min total) without adding coverage, since most
parameter combinations are redundant. The goal is to cut runtime while keeping at least one test for every functional parameter value (HalfPLR, TDMIterateMode, TDMSplit, PGR, GSU) and every code path (unrolled / tail / edge-m / edge-n).
Technical Details
Approach:
solution groups, then shrink each group's problem sizes to the minimal
set that still hits its target path.
Test Plan
Evaluate the change
Test Result
Results (Actual Solutions x Problem Sizes):
Submission Checklist