Skip to content

[rocsparse] add OutputRedirectListener#769

Merged
kliegeois merged 5 commits into
ROCm:developfrom
kliegeois:redirected_logs
Jul 24, 2025
Merged

[rocsparse] add OutputRedirectListener#769
kliegeois merged 5 commits into
ROCm:developfrom
kliegeois:redirected_logs

Conversation

@kliegeois
Copy link
Copy Markdown
Contributor

@kliegeois kliegeois commented Jul 21, 2025

This PR adds a gtest listener named OutputRedirectListener that allows to capture the output of passing gtest tests.
By default, only the prints of the failing tests are printed.

YvanMokwinski
YvanMokwinski reviewed Jul 22, 2025
View reviewed changes
Comment thread projects/rocsparse/clients/tests/rocsparse_test_main.cpp Outdated
Comment thread projects/rocsparse/clients/tests/rocsparse_test_main.cpp Outdated
Comment thread projects/rocsparse/clients/tests/rocsparse_test_main.cpp Outdated
Comment thread projects/rocsparse/clients/tests/rocsparse_test_main.cpp Outdated
Comment thread projects/rocsparse/clients/tests/rocsparse_test_main.cpp Outdated
Comment thread projects/rocsparse/clients/tests/rocsparse_test_main.cpp Outdated
Comment thread projects/rocsparse/clients/tests/rocsparse_test_main.cpp Outdated
Comment thread projects/rocsparse/clients/tests/rocsparse_test_main.cpp Outdated
Comment thread projects/rocsparse/clients/tests/rocsparse_test_main.cpp Outdated
@kliegeois kliegeois requested a review from YvanMokwinski July 22, 2025 19:10
YvanMokwinski
YvanMokwinski reviewed Jul 22, 2025
View reviewed changes
Comment thread projects/rocsparse/clients/tests/rocsparse_test_listeners.hpp Outdated
@kliegeois kliegeois requested a review from YvanMokwinski July 22, 2025 21:43
YvanMokwinski
YvanMokwinski reviewed Jul 24, 2025
View reviewed changes
Comment thread projects/rocsparse/clients/tests/rocsparse_test_listeners.cpp
@kliegeois kliegeois merged commit e2ecd80 into ROCm:develop Jul 24, 2025
8 of 13 checks passed
@kliegeois kliegeois deleted the redirected_logs branch July 24, 2025 16:26
assistant-librarian Bot pushed a commit to ROCm/rocSPARSE that referenced this pull request Jul 24, 2025
@kliegeois @assistant-librarian
[rocm-libraries] ROCm/rocm-libraries#769 (commit e2ecd80)
c3f6943 
[rocsparse] add OutputRedirectListener

This PR adds a gtest listener named `OutputRedirectListener` that allows
to capture the output of passing gtest tests.
By default, only the prints of the failing tests are printed.
ammallya pushed a commit that referenced this pull request Sep 18, 2025
@cgmb
Revert "Added small-size larfg and larf kernels" (#769)
3af83ba 
Revert "Added small-size larfg and larf kernels (#759)"

Reverting due to failures in single-precision SYGVDX on gfx1101 when
GetParam() = ({ 50, 50, 60, 70, -15, -5, 28, 35, 1 }, { 2, V, I, U }).

This reverts commit 63c4ed0.

[ROCm/rocSOLVER commit: 057cfa7]
mgates3 pushed a commit to mgates3/rocm-libraries that referenced this pull request Mar 6, 2026
@cgmb
Revert "Added small-size larfg and larf kernels" (ROCm#769)
69b3f56 
Revert "Added small-size larfg and larf kernels (ROCm#759)"

Reverting due to failures in single-precision SYGVDX on gfx1101 when
GetParam() = ({ 50, 50, 60, 70, -15, -5, 28, 35, 1 }, { 2, V, I, U }).

This reverts commit 3bbb7c4.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@YvanMokwinski YvanMokwinski YvanMokwinski approved these changes

@ntrost57 ntrost57 ntrost57 approved these changes

@jsandham jsandham jsandham approved these changes

Assignees

No one assigned

Labels

organization: ROCm project: rocsparse

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kliegeois @YvanMokwinski @ntrost57 @jsandham