Skip to content

[rocRAND][Code Coverage][Cherry Pick] Increase Code Coverage for rocRAND (#409)#759

Closed
NguyenNhuDi wants to merge 3 commits into
ROCm:release/rocm-rel-7.0from
NguyenNhuDi:zenguyen-rocrand/increase-code-coverage-cherry-pick-7.0
Closed

[rocRAND][Code Coverage][Cherry Pick] Increase Code Coverage for rocRAND (#409)#759
NguyenNhuDi wants to merge 3 commits into
ROCm:release/rocm-rel-7.0from
NguyenNhuDi:zenguyen-rocrand/increase-code-coverage-cherry-pick-7.0

Conversation

@NguyenNhuDi
Copy link
Copy Markdown
Contributor

This PR is recreated to merge into develop instead of release staging branch. Previous PR is #173.

This PR is recreated to merge into develop instead of release staging
branch. Previous PR is ROCm#173.
@NguyenNhuDi NguyenNhuDi requested a review from a team as a code owner July 29, 2025 17:18
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jul 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

❌ Your project status has failed because the head coverage (52.06%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@                    Coverage Diff                    @@
##           release/rocm-rel-7.0     #759       +/-   ##
=========================================================
- Coverage                 75.10%   52.06%   -23.04%     
=========================================================
  Files                       495       63      -432     
  Lines                     44357     7436    -36921     
  Branches                   5686      810     -4876     
=========================================================
- Hits                      33310     3871    -29439     
+ Misses                     6839     3233     -3606     
+ Partials                   4208      332     -3876     
Flag Coverage Δ
rocRAND 52.06% <ø> (ø)
rocThrust ?
see 433 files with indirect coverage changes
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@NguyenNhuDi
Copy link
Copy Markdown
Contributor Author

Closing ticket to re-opoen from source to trigger all CI build. New PR here (#1038)

@NguyenNhuDi NguyenNhuDi reopened this Aug 1, 2025
@NguyenNhuDi NguyenNhuDi closed this Aug 1, 2025
vamovsik pushed a commit that referenced this pull request Aug 8, 2025
…AND (#409) (#1038)

Re opening this cherry-pick PR from source to trigger CI. Original PR
here (#759)
ammallya pushed a commit that referenced this pull request Sep 18, 2025
* Empty small-size kernel for larfg

* Implemented small-size larfg kernel

* Minor improvement to geqr2

* Empty small-size kernel for larf

* Basic implementation of small-size kernel for larf

* Improved implementation of small-size kernel for larf

* Fixed workspace issues

* Increased size constants

* Updated changelog

* Fix failures in latrd and sytd2

[ROCm/rocSOLVER commit: 5156c3a]
ammallya pushed a commit that referenced this pull request Sep 18, 2025
Revert "Added small-size larfg and larf kernels (#759)"

Reverting due to failures in single-precision SYGVDX on gfx1101 when
GetParam() = ({ 50, 50, 60, 70, -15, -5, 28, 35, 1 }, { 2, V, I, U }).

This reverts commit 63c4ed0.

[ROCm/rocSOLVER commit: 057cfa7]
mgates3 pushed a commit to mgates3/rocm-libraries that referenced this pull request Mar 6, 2026
* Empty small-size kernel for larfg

* Implemented small-size larfg kernel

* Minor improvement to geqr2

* Empty small-size kernel for larf

* Basic implementation of small-size kernel for larf

* Improved implementation of small-size kernel for larf

* Fixed workspace issues

* Increased size constants

* Updated changelog

* Fix failures in latrd and sytd2
mgates3 pushed a commit to mgates3/rocm-libraries that referenced this pull request Mar 6, 2026
Revert "Added small-size larfg and larf kernels (ROCm#759)"

Reverting due to failures in single-precision SYGVDX on gfx1101 when
GetParam() = ({ 50, 50, 60, 70, -15, -5, 28, 35, 1 }, { 2, V, I, U }).

This reverts commit 3bbb7c4.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants