Skip to content

[rocRAND][Code Coverage][Cherry Pick] Increase Code Coverage for rocRAND (#409) #759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
NguyenNhuDi wants to merge 3 commits into from
Closed

[rocRAND][Code Coverage][Cherry Pick] Increase Code Coverage for rocRAND (#409) #759

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7476d81
[rocRAND][Code Coverage] Increase Code Coverage for rocRAND (#409)
NguyenNhuDi Jul 14, 2025
7e05874
resolved changelog merge conflict
NguyenNhuDi Jul 28, 2025
80bd6c3
nuking jenkins to fix mathci
NguyenNhuDi Jul 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions projects/rocrand/test/internal/test_normal_distribution.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright (c) 2017-2024 Advanced Micro Devices, Inc. All rights reserved.
// Copyright (c) 2017-2025 Advanced Micro Devices, Inc. All rights reserved.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
Expand All @@ -24,7 +24,6 @@
#include <random>

#include <rng/distribution/normal.hpp>

using namespace rocrand_impl::host;

TEST(normal_distribution_tests, float_test)
Expand Down
24 changes: 14 additions & 10 deletions projects/rocrand/test/internal/test_rocrand_config_dispatch.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,8 @@
#include "test_common.hpp"
#include <gtest/gtest.h>

__global__ void write_target_arch(rocrand_impl::host::target_arch* dest_arch)
__global__
void write_target_arch(rocrand_impl::host::target_arch* dest_arch)
{
constexpr auto arch = rocrand_impl::host::get_device_arch();
*dest_arch = arch;
Expand Down Expand Up @@ -61,8 +62,8 @@ template<class T,
unsigned int BlockSize = rocrand_impl::host::default_config_provider<
dummy_rng_type>::template device_config<T>(true)
.threads>
__global__ __launch_bounds__(BlockSize) void write_config(unsigned int* block_size,
unsigned int* grid_size)
__global__ __launch_bounds__(BlockSize)
void write_config(unsigned int* block_size, unsigned int* grid_size)
{
if(blockIdx.x == 0 && threadIdx.x == 0 && BlockSize == blockDim.x)
{
Expand Down Expand Up @@ -174,8 +175,8 @@ TEST(rocrand_config_dispatch_tests, device_id_from_stream)
}

template<class ConfigProvider>
__global__ void least_common_grid_size_kernel(unsigned int* least_common_grid_size,
rocrand_ordering order)
__global__
void least_common_grid_size_kernel(unsigned int* least_common_grid_size, rocrand_ordering order)
{
*least_common_grid_size = rocrand_impl::host::get_least_common_grid_size<ConfigProvider>(
rocrand_impl::host::is_ordering_dynamic(order));
Expand Down Expand Up @@ -226,7 +227,8 @@ TEST(rocrand_config_dispatch_tests, default_config_provider)
}

template<class ConfigProvider>
__global__ void config_selector_kernel(unsigned int* output)
__global__
void config_selector_kernel(unsigned int* output)
{
if(threadIdx.x == 0 && blockIdx.x == 0)
{
Expand All @@ -241,14 +243,16 @@ namespace rocrand_impl::host
template<>
struct generator_config_selector<dummy_rng_type, unsigned short>
{
__host__ __device__ static constexpr unsigned int get_threads(const target_arch arch)
__host__ __device__
static constexpr unsigned int get_threads(const target_arch arch)
{
if(arch == target_arch::gfx906)
return 64;
return generator_config_defaults<dummy_rng_type, unsigned short>::threads;
}

__host__ __device__ static constexpr unsigned int get_blocks(const target_arch /*arch*/)
__host__ __device__
static constexpr unsigned int get_blocks(const target_arch /*arch*/)
{
return generator_config_defaults<dummy_rng_type, unsigned short>::blocks;
}
Expand All @@ -263,8 +267,8 @@ TEST(rocrand_config_dispatch_tests, config_selection)
HIP_CHECK(hipMallocHelper(&d_output, size * sizeof(*d_output)));

using config_provider_t = rocrand_impl::host::default_config_provider<dummy_rng_type>;
config_provider_t config_provider{};
rocrand_impl::host::generator_config config{};
config_provider_t config_provider{};
rocrand_impl::host::generator_config config{};

static constexpr hipStream_t default_stream = 0;
static constexpr rocrand_ordering ordering = ROCRAND_ORDERING_PSEUDO_DYNAMIC;
Expand Down
Loading