[MIOpen] ROCM-24413 Fix CK dynamic-lib applicability tests#7354
Merged
BrianHarrisonAMD merged 3 commits intoMay 13, 2026
Merged
Conversation
BrianHarrisonAMD
force-pushed
the
users/bharriso/miopen-ck-dynamic-applicability-tests
branch
from
5e37a21 to
65a6a2a
Compare
DarylHawkinsAMD
approved these changes
May 12, 2026
BrianHarrisonAMD
force-pushed
the
users/bharriso/miopen-ck-dynamic-applicability-tests
branch
from
65a6a2a to
7376700
Compare
BrianHarrisonAMD
force-pushed
the
users/bharriso/miopen-ck-dynamic-applicability-tests
branch
from
7376700 to
2d5826a
Compare
DarylHawkinsAMD
approved these changes
May 12, 2026
This was referenced May 12, 2026
DarylHawkinsAMD
approved these changes
May 12, 2026
Contributor
Author
|
Okay confirmed this fixes both observed issues. |
BrianHarrisonAMD
deleted the
users/bharriso/miopen-ck-dynamic-applicability-tests
branch
aledudek
pushed a commit
that referenced
this pull request
May 20, 2026
## Summary Updates MIOpen CK dynamic-library applicability tests so runtime-backed CK checks only run against the current real HIP device. If the CK device library for the current GPU is missing, the test skips instead of failing. ## Risk Assessment Low. This is limited to MIOpen gtest harness and test expectation logic. No solver implementation, ABI, API, schema, or build-system behavior changes. ## Testing Summary - Local gfx90a validation covered present-current-device, multiarch plugin layout, missing-current-device skip behavior, and CK loader path behavior. - TheRock Linux Multi-Arch validation built the MIOpen artifacts for `gfx90a,gfx94X,gfx950`; the overall workflow failed in gfx950 container initialization, not in MIOpen tests. - Focused gfx942 artifact validation covered full CK plugin set, gfx942-only plugin set, missing-gfx942 plugin set, and empty CK plugin directory. ## Testing Checklist - [x] Local focused MIOpen build for the affected CK dynamic-library gtests - Status: Passed - [x] Local focused CK applicability tests with current-device CK library present - ASICs: gfx90a - Status: Passed - [x] Local multiarch-style plugin layout with current and non-current CK libraries present - ASICs: gfx90a - Status: Passed - [x] Local missing-current-device plugin layout skipped instead of failing with only a non-current CK library present - ASICs: gfx90a - Status: Passed - [x] CK loader path check with `MIOPEN_CK_LIB_PATH` unset - Status: Passed - [x] TheRock Linux MIOpen artifact build - Scope: `gfx90a,gfx94X,gfx950`, `test:miopen` - Status: Passed for required MIOpen artifacts - Link: [TheRock run](https://github.com/ROCm/TheRock/actions/runs/25766884609) - [x] TheRock MIOpen artifact validation, full CK plugin set - `miopen_gtest --gtest_filter=<focused CK grouped-conv applicability suites>` - ASICs: gfx942 - Status: Passed, 12/12 passed - [x] TheRock MIOpen artifact validation, gfx942-only CK plugin set - `miopen_gtest --gtest_filter=<focused CK grouped-conv applicability suites>` - ASICs: gfx942 - Status: Passed, 12/12 passed - [x] TheRock MIOpen artifact validation, missing-gfx942 CK plugin set - `miopen_gtest --gtest_filter=<focused CK grouped-conv applicability suites>` - ASICs: gfx942 - Status: Passed, 10 skipped and 2 passed - [x] TheRock MIOpen artifact validation, empty CK plugin directory - `miopen_gtest --gtest_filter=<focused CK grouped-conv applicability suites>` - ASICs: gfx942 - Status: Passed, 10 skipped and 2 passed ## Technical Changes - Adds shared skip handling for CK dynamic-library tests when the current device library is unavailable. - Restricts CK dynamic-library dev-applicability checks to mock device entries matching the current device base architecture. - Keeps the existing all-known-device mock sweep for non-CK solvers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates MIOpen CK dynamic-library applicability tests so runtime-backed CK checks only run against the current real HIP device. If the CK device library for the current GPU is missing, the test skips instead of failing.
Risk Assessment
Low. This is limited to MIOpen gtest harness and test expectation logic. No solver implementation, ABI, API, schema, or build-system behavior changes.
Testing Summary
gfx90a,gfx94X,gfx950; the overall workflow failed in gfx950 container initialization, not in MIOpen tests.Testing Checklist
MIOPEN_CK_LIB_PATHunset - Status: Passedgfx90a,gfx94X,gfx950,test:miopen- Status: Passed for required MIOpen artifacts - Link: TheRock runmiopen_gtest --gtest_filter=<focused CK grouped-conv applicability suites>- ASICs: gfx942 - Status: Passed, 12/12 passedmiopen_gtest --gtest_filter=<focused CK grouped-conv applicability suites>- ASICs: gfx942 - Status: Passed, 12/12 passedmiopen_gtest --gtest_filter=<focused CK grouped-conv applicability suites>- ASICs: gfx942 - Status: Passed, 10 skipped and 2 passedmiopen_gtest --gtest_filter=<focused CK grouped-conv applicability suites>- ASICs: gfx942 - Status: Passed, 10 skipped and 2 passedTechnical Changes