Skip to content

Test: bump rocm-libraries for MIOpen CK dynamic applicability#5222

Closed
BrianHarrisonAMD wants to merge 1 commit into
mainfrom
users/bharriso/test-miopen-ck-dynamic-applicability
Closed

Test: bump rocm-libraries for MIOpen CK dynamic applicability#5222
BrianHarrisonAMD wants to merge 1 commit into
mainfrom
users/bharriso/test-miopen-ck-dynamic-applicability

Conversation

@BrianHarrisonAMD
Copy link
Copy Markdown
Contributor

Purpose

Validation-only PR - not intended to merge.

This bumps the rocm-libraries submodule to c0490e8b5a6929cf8371f77f771e178a033c34d1 from ROCm/rocm-libraries#7354.

The goal is to exercise TheRock multi-arch CI with ci:run-all-archs and validate the MIOpen CK dynamic-library applicability test fix for ROCM-24419 on gfx942.

What changed

  • rocm-libraries submodule: 8d33c2d2d1 -> c0490e8b5a6

Validation focus

  1. Apply ci:run-all-archs to trigger all-architecture CI.
  2. Monitor gfx94X/gfx942 MIOpen test jobs for the previous hipErrorInvalidDeviceFunction / CK is_applicable failure.
  3. Download MIOpen artifacts and run focused gfx942 tests with these CK plugin layouts:
    • full CK set: gfx90a + gfx942 + gfx950 present; expected pass on gfx942
    • gfx942 only; expected pass on gfx942
    • missing gfx942; expected skip, not fail
    • empty CK directory; expected skip, not fail

If clean, use the run as validation for ROCm/rocm-libraries#7354 and ROCM-24419, then close this PR without merging.

@BrianHarrisonAMD BrianHarrisonAMD requested a review from a team as a code owner May 12, 2026 22:40
@BrianHarrisonAMD BrianHarrisonAMD added the ci:run-all-archs Opt-in to building for all architectures on a pull request label May 12, 2026
@ScottTodd
Copy link
Copy Markdown
Member

Validation-only PR - not intended to merge.

Please create as a draft PR to avoid tagging codeowners.

The goal is to exercise TheRock multi-arch CI with ci:run-all-archs and validate the MIOpen CK dynamic-library applicability test fix for ROCM-24419 on gfx942.

You can also trigger https://github.com/ROCm/TheRock/actions/workflows/multi_arch_ci.yml with workflow_dispatch to choose the exact test filters and platforms that you want. As is, this will build all archs on Windows too, and run component tests other than miopen. See https://github.com/ROCm/TheRock/blob/main/docs/development/ci_behavior_manipulation.md (you can filter tests to just miopen from a PR by adding a label, but there is no way on a PR right now to skip Windows builds)

@ScottTodd
Copy link
Copy Markdown
Member

ScottTodd commented May 12, 2026

@geomin12 this is also running CI ASan (for all archs for gfx942/gfx950): https://github.com/ROCm/TheRock/actions/runs/25766463731/job/75680141745?pr=5222 . That was my concern on #5140 (comment)

People are going to send their own [draft] PRs that include submodule updates outside of our regularly scheduled bumps, and this is going to run expensive ASan builds on those PRs.

I bet we'll want a system like https://github.com/iree-org/iree/blob/fbe60d8c0fc391d5f64fe0a71bca330f7bff445c/build_tools/github_actions/configure_ci.py#L203-L212

Let's keep an eye on this. Probably worth a TODO or more details in the comment.

@BrianHarrisonAMD BrianHarrisonAMD marked this pull request as draft May 12, 2026 22:48
@BrianHarrisonAMD
Copy link
Copy Markdown
Contributor Author

Validation-only PR - not intended to merge.

Please create as a draft PR to avoid tagging codeowners.

The goal is to exercise TheRock multi-arch CI with ci:run-all-archs and validate the MIOpen CK dynamic-library applicability test fix for ROCM-24419 on gfx942.

You can also trigger https://github.com/ROCm/TheRock/actions/workflows/multi_arch_ci.yml with workflow_dispatch to choose the exact test filters and platforms that you want. As is, this will build all archs on Windows too, and run component tests other than miopen. See https://github.com/ROCm/TheRock/blob/main/docs/development/ci_behavior_manipulation.md (you can filter tests to just miopen from a PR by adding a label, but there is no way on a PR right now to skip Windows builds)

Will swap thanks!

@github-project-automation github-project-automation Bot moved this from TODO to Done in TheRock Triage May 12, 2026
@BrianHarrisonAMD
Copy link
Copy Markdown
Contributor Author

Closing/closed this validation-only PR per Scott's guidance. Superseded by targeted workflow_dispatch run https://github.com/ROCm/TheRock/actions/runs/25766884609 using linux_amdgpu_families=gfx90a,gfx94X,gfx950, linux_test_labels=test:miopen, and no Windows families.

@ScottTodd
Copy link
Copy Markdown
Member

Thanks! Sorry for the CI system being so tricky to use x_x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:run-all-archs Opt-in to building for all architectures on a pull request

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants