hipblaslt: restore *_EXT hipDataType compatibility macros#7118
Closed
tony-davis wants to merge 1 commit into
Closed
hipblaslt: restore *_EXT hipDataType compatibility macros#7118tony-davis wants to merge 1 commit into
tony-davis wants to merge 1 commit into
Conversation
…OCM-24233) PR #6499 dropped int const HIP_R_*_EXT for mxfp4 types now represented in HIP's hipDataType enum. Re-introduce those spellings as preprocessor aliases to HIP_R_6F_E2M3 / HIP_R_6F_E3M2 / HIP_R_4F_E2M1 when building for AMD HIP, with numeric fallbacks elsewhere, matching prior constant values. Fixes JAX/XLA builds that still reference HIP_R_4F_E2M1_EXT, without duplicating symbols or conflicting with HIP_R_8F_E5M3_EXT. Co-authored-by: Cursor <cursoragent@cursor.com>
tony-davis
changed the title
Contributor
Author
|
Overtaken by PR #7078 |
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (77.83%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #7118 +/- ##
===========================================
- Coverage 65.25% 65.25% -0.00%
===========================================
Files 2083 2083
Lines 323506 323504 -2
Branches 42438 42437 -1
===========================================
- Hits 211075 211073 -2
Misses 94896 94896
Partials 17535 17535
*This pull request uses carry forward flags. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this change
[hipblaslt] Add support for gfx950 mxfp4 (#6499) removed the legacy
int constdeclarations forHIP_R_6F_E2M3_EXT,HIP_R_6F_E3M2_EXT, andHIP_R_4F_E2M1_EXTfromhipblaslt-types.hafter those cases were represented on HIP’shipDataTypeenum (HIP_R_6F_E2M3,HIP_R_6F_E3M2,HIP_R_4F_E2M1). That was an ABI/header compatibility break: downstream projects that still reference the*_EXTidentifiers (notably portable Linux JAX wheel builds compiling XLA’s ROCm path) fail with undeclared-identifier errors, even though the underlying enum values are unchanged.What we do here
Restore the
*_EXTspellings as#definealiases to the canonical HIP enumerators when building for AMD HIP (#include <hip/library_types.h>), guarded with#ifndefso overrides remain possible. For other compilation modes, fall back to the prior integer literals (31, 32, 33) so behavior matches the old constants.HIP_R_8F_E5M3_EXTstays a singleint constextension as today.This follows the compatibility direction: unbreak consumers without duplicating symbols or forcing an immediate mass rename in JAX/XLA.
Made with Cursor
ROCM-24233