Restore removed _EXT HIP datatype constants in hipblaslt-types.h#7078
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (77.83%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #7078 +/- ##
========================================
Coverage 65.25% 65.25%
========================================
Files 2082 2082
Lines 323444 323444
Branches 42433 42433
========================================
Hits 211032 211032
Misses 94834 94834
Partials 17578 17578
*This pull request uses carry forward flags. Click here to find out more. 🚀 New features to boost your workflow:
|
talumbau
approved these changes
May 6, 2026
Contributor
talumbau
left a comment
talumbau
left a comment
There was a problem hiding this comment.
Looks like a clean revert of the unexplained removal of the ints here:
thanks for the fix!
|
Thanks! |
aledudek
pushed a commit
that referenced
this pull request
May 20, 2026
…#7078) ## Summary Commit 89b3fc4 ("[hipblaslt] Add support for gfx950 mxfp4" #6499) inadvertently removed three public `_EXT` datatype constants from `projects/hipblaslt/library/include/hipblaslt/hipblaslt-types.h`: - `HIP_R_6F_E2M3_EXT = 31` - `HIP_R_6F_E3M2_EXT = 32` - `HIP_R_4F_E2M1_EXT = 33` Only `HIP_R_8F_E5M3_EXT = 34` was left in place. The original PR description for #6499 explicitly stated that "`_EXT` HIP types are still accepted on the host side via aliases", so dropping these public constants was unintentional. ## Motivation These constants are part of the public hipBLASLt API surface and are referenced by downstream projects. Removing them is a source-breaking change for any consumer that includes `hipblaslt-types.h` and references `HIP_R_6F_E2M3_EXT`, `HIP_R_6F_E3M2_EXT`, or `HIP_R_4F_E2M1_EXT`. ## Changes - Re-add the three removed `_EXT` constants in `hipblaslt-types.h` with their original integer values, alongside the existing `HIP_R_8F_E5M3_EXT`. ## Backwards compatibility / risk - Pure restoration of previously-public constants with their original values — no behavioral change inside hipBLASLt. - Unblocks downstream builds that broke after #6499 landed. ## Submission Checklist - [ ] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Commit 89b3fc4 ("[hipblaslt] Add support for gfx950 mxfp4" #6499) inadvertently removed three public
_EXTdatatype constants fromprojects/hipblaslt/library/include/hipblaslt/hipblaslt-types.h:HIP_R_6F_E2M3_EXT = 31HIP_R_6F_E3M2_EXT = 32HIP_R_4F_E2M1_EXT = 33Only
HIP_R_8F_E5M3_EXT = 34was left in place. The original PR description for [hipblaslt] Add support for gfx950 mxfp4 #6499 explicitly stated that "_EXTHIP types are still accepted on the host side via aliases", so dropping these public constants was unintentional.Motivation
These constants are part of the public hipBLASLt API surface and are referenced by downstream projects. Removing them is a source-breaking change for any consumer that includes
hipblaslt-types.hand referencesHIP_R_6F_E2M3_EXT,HIP_R_6F_E3M2_EXT, orHIP_R_4F_E2M1_EXT.Changes
_EXTconstants inhipblaslt-types.hwith their original integer values, alongside the existingHIP_R_8F_E5M3_EXT.Backwards compatibility / risk
Submission Checklist
ROCM-24233