Repository navigation
test(therock): run rocWMMA CTest with --parallel 1 (ROCM-24171) - #7075
Closed
tony-davis wants to merge 1 commit into
Closed
tony-davis wants to merge 1 commit into
tony-davis wants to merge 1 commit into
Conversation
Default parallelism was 2; intermittent lockups on gfx942 TheRock CI. Serialize CTest jobs until the root cause is understood. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Author
|
TheRock companion PR: ROCm/TheRock#5061 |
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Reduces rocWMMA TheRock CTest parallelism to mitigate intermittent GPU test stalls/timeouts in CI (ROCM-24171).
Changes:
- Set CTest
--parallelto1unconditionally for rocWMMA TheRock tests. - Remove the gfx1153-only parallelism branch and the now-unused
AMDGPU_FAMILIESenv var read. - Add inline context comments explaining the rationale and affected CI hardware.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+53
to
+54
| # ROCM-24171: Default CTest --parallel was 2; intermittent lockups / 60m timeouts on | ||
| # gfx942 TheRock CI suggested avoiding concurrent GPU tests — use 1 until root cause is found. |
bsyrowik
approved these changes
May 6, 2026
bsyrowik
left a comment
bsyrowik
left a comment
Contributor
There was a problem hiding this comment.
Seems fine as a temporary workaround. Thanks Tony!
tony-davis
added a commit
to ROCm/TheRock
that referenced
this pull request
May 6, 2026
## Summary Set rocWMMA TheRock CTest `--parallel` default from **2** to **1** in `build_tools/github_actions/test_executable_scripts/test_rocwmma.py` only (no rocm-libraries submodule change on this branch). ## Context Mitigate intermittent 60m test-step stalls on Linux gfx94X-dcgpu rocWMMA CI by avoiding two concurrent CTest jobs on single-GPU runners. Prior discussion: TheRock#2823 (flaky gfx94X / `unpack_util_test`); nightly already skips those tests via `TESTS_TO_IGNORE` in this script. ## Related - rocm-libraries (mirrored `test/therock` script only): ROCm/rocm-libraries#7075 ## Follow-up After merge, rocm-libraries picks up behavior on the **next pinned TheRock SHA bump** in its TheRock workflows (this PR does not advance the submodule). Made with [Cursor](https://cursor.com) ROCM-24171 --------- Co-authored-by: Cursor <cursoragent@cursor.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
kcossett-amd
pushed a commit
to ROCm/TheRock
that referenced
this pull request
May 7, 2026
## Summary Set rocWMMA TheRock CTest `--parallel` default from **2** to **1** in `build_tools/github_actions/test_executable_scripts/test_rocwmma.py` only (no rocm-libraries submodule change on this branch). ## Context Mitigate intermittent 60m test-step stalls on Linux gfx94X-dcgpu rocWMMA CI by avoiding two concurrent CTest jobs on single-GPU runners. Prior discussion: TheRock#2823 (flaky gfx94X / `unpack_util_test`); nightly already skips those tests via `TESTS_TO_IGNORE` in this script. ## Related - rocm-libraries (mirrored `test/therock` script only): ROCm/rocm-libraries#7075 ## Follow-up After merge, rocm-libraries picks up behavior on the **next pinned TheRock SHA bump** in its TheRock workflows (this PR does not advance the submodule). Made with [Cursor](https://cursor.com) ROCM-24171 --------- Co-authored-by: Cursor <cursoragent@cursor.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Default CTest
--parallelfor rocWMMA TheRock test driver is reduced from 2 to 1 to mitigate intermittent long stalls / 60-minute timeouts on gfx942 TheRock CI.Notes
build_tools/(see linked TheRock PR).AMDGPU_FAMILIESafter dropping the gfx1153-only parallel branch.Made with Cursor
ROCM-24171