Skip to content

[rocThrust] Fix google benchmark compile issue on Windows #643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NguyenNhuDi merged 5 commits into from
Jul 16, 2025
Merged

[rocThrust] Fix google benchmark compile issue on Windows #643

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8dafc86
implemented fix
NguyenNhuDi Jul 14, 2025
7b99095
removed comment aboout hiop-clang can not compile google benchmark
NguyenNhuDi Jul 15, 2025
9ab7ead
updated to latest on develop
NguyenNhuDi Jul 15, 2025
8ca3e06
Merge branch 'develop' into zenguyen-rocthrust/fix-window-build-bench…
NguyenNhuDi Jul 15, 2025
b629146
Update projects/rocthrust/CHANGELOG.md
NguyenNhuDi Jul 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions projects/rocthrust/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ Documentation for rocThrust available at
* Updated the required version of Google Benchmark from 1.8.0 to 1.9.0.
* Drop `c++14` support for rocthrust.
* Renamed `cpp14_required.h` to `cpp_version_check.h`
* Switched to using `clang++` to compile for google benchmark on Windows system
Comment thread
NguyenNhuDi marked this conversation as resolved.
Outdated
* Added gfx950 support.
* Merged changes from upstream CCCL/thrust 2.6.0

Expand Down
4 changes: 2 additions & 2 deletions projects/rocthrust/cmake/Dependencies.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,9 +150,9 @@ if(BUILD_BENCHMARKS)
endif()
set(GOOGLEBENCHMARK_ROOT ${CMAKE_CURRENT_BINARY_DIR}/deps/googlebenchmark CACHE PATH "")
if(NOT (CMAKE_CXX_COMPILER_ID STREQUAL "GNU"))
# hip-clang cannot compile googlebenchmark for some reason
if(WIN32)
set(COMPILER_OVERRIDE "-DCMAKE_CXX_COMPILER=cl")
get_filename_component(CXX_DIRNAME ${CMAKE_CXX_COMPILER} DIRECTORY)
set(COMPILER_OVERRIDE "-DCMAKE_CXX_COMPILER=${CXX_DIRNAME}/clang++.exe")
else()
set(COMPILER_OVERRIDE "-DCMAKE_CXX_COMPILER=g++")
endif()
Expand Down
Loading