[rocThrust] Fix google benchmark compile issue on Windows#643
Conversation
|
Just curious, is Visual Studio installed on the machines that this issue is happening on - or is CMake just failing to find the cl executable? It looks like we do list Visual Studio as a requirement in the readme. Though I guess either way, if we can just use clang++ now, that would probably be preferable, since it cuts down on the number of extra requirements on Windows. |
|
I think CMAKE is failing to find the cl compiler and is not related to vscode. Although I do not know why vscode is a requirement as its possible to compile and run rocthrust unit tests and benchmarks just on powershell. |
umfranzw
left a comment
umfranzw
left a comment
There was a problem hiding this comment.
Thanks - ok, if this passes CI, then I think that's good enough for me.
spolifroni-amd
left a comment
spolifroni-amd
left a comment
There was a problem hiding this comment.
I made a small change to the wording in the changelog. It's not much and isn't super necessary; it just makes it smoother. Approving.
Co-authored-by: spolifroni-amd <Sandra.Polifroni@amd.com>
NguyenNhuDi
dismissed stale reviews from spolifroni-amd and umfranzw
via
b629146
Our Windows CI is currently offline, but this seems simple enough for us to work around if we need to. We'll let you know if anything needs to change (or we'll create a PR). Poking @cenxuantian who is also working on this part of the CI on our end. |
[rocThrust] Fix google benchmark compile issue on Windows (#643) On some Windows system the compiler used for building google benchmark (`cl`) is not available. We will switch to using `clang++` instead. --------- Co-authored-by: spolifroni-amd <Sandra.Polifroni@amd.com>
4 participants
On some Windows system the compiler used for building google benchmark (
cl) is not available. We will switch to usingclang++instead.