Repository navigation
align scale datatype with cublaslt for I8I8I - #490
Closed
xiaohuguo2023 wants to merge 7 commits into
Closed
xiaohuguo2023 wants to merge 7 commits into
xiaohuguo2023 wants to merge 7 commits into
Conversation
xiaohuguo2023
commented
Jul 2, 2025
xiaohuguo2023
commented
Member
- change I8I8I scale data type to fp32 when UseScaleAB == Vector
- change I8I8I scale data type to fp32 when UseScaleAB == Scalar
- add tests for the above
| UseBeta: True | ||
| Batched: True | ||
| Activation: False | ||
| UseScaleAB: "Scalar" |
Contributor
There was a problem hiding this comment.
Did you try to verify "Vector" or "Scalar"?
ammallya
pushed a commit
that referenced
this pull request
Jul 14, 2025
[ROCm/rocSPARSEcommit: 96c0e7e]
ammallya
pushed a commit
that referenced
this pull request
Jul 14, 2025
[ROCm/rocSPARSE commit: 96c0e7e]
ammallya
pushed a commit
that referenced
this pull request
Jul 22, 2025
ammallya
pushed a commit
that referenced
this pull request
Oct 27, 2025
* Split algorithm and functional utils into their own files. Add is_standard_layout and is_trivial type traits * Update algorithm_impl.hpp removed comment
ammallya
pushed a commit
that referenced
this pull request
Oct 28, 2025
* Split algorithm and functional utils into their own files. Add is_standard_layout and is_trivial type traits * Update algorithm_impl.hpp removed comment [ROCm/rocwmma commit: b558db1]
Contributor
|
This pull request has been inactive for 25 days and will be marked as stale. If you would like to keep this PR open, please:
This PR will be automatically closed in 5 days if no further activity occurs. |
Contributor
|
This pull request has been automatically closed due to inactivity (30 days with no updates). If you'd like to continue working on this, feel free to reopen the PR or create a new one. |
mpanoop
pushed a commit
to mpanoop/rocm-libraries
that referenced
this pull request
Oct 5, 2026
* Remove Thrust comments referencing website (ROCm#451) Referencing or using code from some websites is prohibited in rocThrust. Some comments with these kinds of references were recently added by Thrust, and then when we updated the API, were brought into rocThrust. This change removes the references in the comments. * Specify minimum version for Google benchmark (ROCm#450) * Remove Thrust comments referencing website (ROCm#447) Referencing or using code from some websites is prohibited in rocThrust. Some comments with these kinds of references were recently added by Thrust, and then when we updated the API, were brought into rocThrust. This change removes the references in the comments. * Bump rocm-docs-core from 1.6.2 to 1.7.1 in /docs/sphinx (ROCm#448) Bumps [rocm-docs-core](https://github.com/ROCm/rocm-docs-core) from 1.6.2 to 1.7.1. - [Release notes](https://github.com/ROCm/rocm-docs-core/releases) - [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md) - [Commits](ROCm/rocm-docs-core@v1.6.2...v1.7.1) --- updated-dependencies: - dependency-name: rocm-docs-core dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Specify minimum version for Google benchmark Pass a minimum version to find_package to prevent it from using outdated versions of Google benchmark that may be present on the system. --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Temporarily disable scan tests, re-enable tests on gfx11xx (ROCm#449) * Remove Thrust comments referencing website (ROCm#447) Referencing or using code from some websites is prohibited in rocThrust. Some comments with these kinds of references were recently added by Thrust, and then when we updated the API, were brought into rocThrust. This change removes the references in the comments. * Temporarily disable scan tests, re-enable tests on gfx11xx Remove code that excludes gfx11xx tests on Jenkins, since they work there now. Add a temporary exclusion for test_thrust_scan, which needs a compiler fix. * Remove website URL from comments (ROCm#456) Referencing or using code from some websites is prohibited in this repository. This change removes an informational reference in the comments. * Add checks around some platform-specific benchmark code (ROCm#455) There were two spots in the new benchmark code that were causing compile-time issues on some Windows systems. This change adds a check to make sure we have 128-bit integer support before using int128_t in generation_utils.hpp. It also avoids calling clock_gettime on Windows, since it seems to be causing build issues there. Instead, I've restored the old Windows timing code from PR ROCm#431, which uses QueryPerformanceFrequency/Counter instead. * Add gfx1151 build target (ROCm#457) (ROCm#459) * Add gfx1151 target * Revert "Add gfx1151 target" This reverts commit 5889238d5e754f79fbb9d353b0bf4def528cfc78. * Add gfx1151 target while preserving address sanitizer targets --------- Co-authored-by: Stanley Tsang <stanley.tsang@amd.com> * Remove website reference (ROCm#460) Removed the link to more information from the CRC algorithm comments. * updated the changelog for 6.3 (ROCm#480) * updated the changelog for 6.3 * removed '(unreleased)' for 6.2 * added support for gfx12 and gfx1151 in default gpu list * updated changelog * fixed some minor grammar in changelog * Remove gfx940,gfx941 targets (ROCm#484) --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Wayne Franz <wayfranz@amd.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: amd-garydeng <garydeng@amd.com> Co-authored-by: spolifroni-amd <Sandra.Polifroni@amd.com> Co-authored-by: NguyenNhuDi <dinguyennhu@gmail.com> Co-authored-by: Val Movsik <160653499+vamovsik@users.noreply.github.com> [ROCm/rocThrust commit: d935e55]
mpanoop
pushed a commit
to mpanoop/rocm-libraries
that referenced
this pull request
Oct 5, 2026
* Remove Thrust comments referencing website (ROCm#451) Referencing or using code from some websites is prohibited in rocThrust. Some comments with these kinds of references were recently added by Thrust, and then when we updated the API, were brought into rocThrust. This change removes the references in the comments. * Specify minimum version for Google benchmark (ROCm#450) * Remove Thrust comments referencing website (ROCm#447) Referencing or using code from some websites is prohibited in rocThrust. Some comments with these kinds of references were recently added by Thrust, and then when we updated the API, were brought into rocThrust. This change removes the references in the comments. * Bump rocm-docs-core from 1.6.2 to 1.7.1 in /docs/sphinx (ROCm#448) Bumps [rocm-docs-core](https://github.com/ROCm/rocm-docs-core) from 1.6.2 to 1.7.1. - [Release notes](https://github.com/ROCm/rocm-docs-core/releases) - [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md) - [Commits](ROCm/rocm-docs-core@v1.6.2...v1.7.1) --- updated-dependencies: - dependency-name: rocm-docs-core dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Specify minimum version for Google benchmark Pass a minimum version to find_package to prevent it from using outdated versions of Google benchmark that may be present on the system. --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Temporarily disable scan tests, re-enable tests on gfx11xx (ROCm#449) * Remove Thrust comments referencing website (ROCm#447) Referencing or using code from some websites is prohibited in rocThrust. Some comments with these kinds of references were recently added by Thrust, and then when we updated the API, were brought into rocThrust. This change removes the references in the comments. * Temporarily disable scan tests, re-enable tests on gfx11xx Remove code that excludes gfx11xx tests on Jenkins, since they work there now. Add a temporary exclusion for test_thrust_scan, which needs a compiler fix. * Remove website URL from comments (ROCm#456) Referencing or using code from some websites is prohibited in this repository. This change removes an informational reference in the comments. * Add checks around some platform-specific benchmark code (ROCm#455) There were two spots in the new benchmark code that were causing compile-time issues on some Windows systems. This change adds a check to make sure we have 128-bit integer support before using int128_t in generation_utils.hpp. It also avoids calling clock_gettime on Windows, since it seems to be causing build issues there. Instead, I've restored the old Windows timing code from PR ROCm#431, which uses QueryPerformanceFrequency/Counter instead. * Add gfx1151 build target (ROCm#457) (ROCm#459) * Add gfx1151 target * Revert "Add gfx1151 target" This reverts commit 5889238d5e754f79fbb9d353b0bf4def528cfc78. * Add gfx1151 target while preserving address sanitizer targets --------- Co-authored-by: Stanley Tsang <stanley.tsang@amd.com> * Remove website reference (ROCm#460) Removed the link to more information from the CRC algorithm comments. * updated the changelog for 6.3 (ROCm#480) * updated the changelog for 6.3 * removed '(unreleased)' for 6.2 * added support for gfx12 and gfx1151 in default gpu list * updated changelog * fixed some minor grammar in changelog * Remove gfx940,gfx941 targets (ROCm#484) --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Wayne Franz <wayfranz@amd.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: amd-garydeng <garydeng@amd.com> Co-authored-by: spolifroni-amd <Sandra.Polifroni@amd.com> Co-authored-by: NguyenNhuDi <dinguyennhu@gmail.com> Co-authored-by: Val Movsik <160653499+vamovsik@users.noreply.github.com> [ROCm/rocThrust commit: d935e55]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.