Repository navigation
support labels with spaces - #471
Merged
Merged
Conversation
TorreZuk
commented
Jul 1, 2025
TorreZuk
commented
Contributor
- fix CI pipelines passing label list
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the CI label handling to support labels containing spaces by converting spaces to underscores when building the --ci_labels argument.
- Sanitize space-containing labels for CI pipelines
- Update
dynamicOptionsconstruction with transformed labels
Comments suppressed due to low confidence (1)
projects/rocblas/.jenkins/common.groovy:66
- Add a test or CI pipeline validation to ensure labels with spaces are correctly transformed into underscores in the generated
--ci_labelsargument.
labelOptions = labelOptions.replaceAll(" ", "_")
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
naveenrajm7
approved these changes
Jul 1, 2025
rkamd
approved these changes
Jul 2, 2025
amcamd
approved these changes
Jul 2, 2025
assistant-librarian Bot
pushed a commit
to ROCm/rocBLAS
that referenced
this pull request
Jul 2, 2025
support labels with spaces * fix CI pipelines passing label list
reboss
pushed a commit
to reboss/rocm-libraries
that referenced
this pull request
Jul 8, 2025
ammallya
pushed a commit
that referenced
this pull request
Jul 14, 2025
[ROCm/rocSPARSEcommit: 116207a]
ammallya
pushed a commit
that referenced
this pull request
Jul 14, 2025
[ROCm/rocSPARSE commit: 116207a]
ammallya
pushed a commit
that referenced
this pull request
Jul 22, 2025
ammallya
pushed a commit
that referenced
this pull request
Jun 8, 2026
kliegeois
pushed a commit
to kliegeois/rocm-libraries
that referenced
this pull request
Jun 8, 2026
[ROCm/rpp commit: 6ede5bf]
1 task
mpanoop
pushed a commit
to mpanoop/rocm-libraries
that referenced
this pull request
Oct 5, 2026
* refactor: migrate to new wavefront api to work around new depracation warnings * build(.gitlab-ci.yml): bump rocprim c++ version in ci * refactor(benchmark): migrate to new wavefront api for amd gpu targets * fix(benchmark_warp_scan): fix benchmark trying to compile non-power-of-two broadcasts [ROCm/hipCUB commit: 40f174d]
mpanoop
pushed a commit
to mpanoop/rocm-libraries
that referenced
this pull request
Oct 5, 2026
* refactor: migrate to new wavefront api to work around new depracation warnings * build(.gitlab-ci.yml): bump rocprim c++ version in ci * refactor(benchmark): migrate to new wavefront api for amd gpu targets * fix(benchmark_warp_scan): fix benchmark trying to compile non-power-of-two broadcasts [ROCm/hipCUB commit: 40f174d]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.