Skip to content

Add gfx1150 support#452

Merged
amcamd merged 8 commits into
developfrom
import/develop/ROCm_rocBLAS/add-gfx1150
Jul 16, 2025
Merged

Add gfx1150 support#452
amcamd merged 8 commits into
developfrom
import/develop/ROCm_rocBLAS/add-gfx1150

Conversation

@assistant-librarian
Copy link
Copy Markdown
Contributor

@assistant-librarian assistant-librarian Bot commented Jun 30, 2025

  • Adding initial support for gfx1150

  • Need to update tensile_tag.txt after PR with Tensile changes is merged in rocm-libraries and automatically in ROCm/Tensile ([tensile] Add gfx1150 Tensile support #396)

  • Update tensile_tag.txt for testing purposes, it will be reverted


🔁 Imported from ROCm/rocBLAS#1659
🧑‍💻 Originally authored by @amd-mtrifuno

@TorreZuk TorreZuk requested a review from fjankovi July 7, 2025 16:52
fjankovi
fjankovi previously approved these changes Jul 10, 2025
@TorreZuk
Copy link
Copy Markdown
Contributor

Looks fine once tensile merged and new tensile_tag available for test.

* use merged tensile develop commit
* must consume push back commit from ROCm/Tensile
@TorreZuk
Copy link
Copy Markdown
Contributor

Okay just added push back develop commit for Tensile tag so lets see if CI will pass now

@TorreZuk
Copy link
Copy Markdown
Contributor

@fjankovi approved the review dismissal is just because I fixed Tensile commit. Think we just need tests passing and rocBLAS review to merge now

TorreZuk
TorreZuk previously approved these changes Jul 16, 2025
Copy link
Copy Markdown
Contributor

@TorreZuk TorreZuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Comment thread projects/rocblas/CMakeLists.txt
* fix else < 7 to use rocm 6.3 gfx set
@amcamd amcamd merged commit d0524be into develop Jul 16, 2025
7 of 9 checks passed
@amcamd amcamd deleted the import/develop/ROCm_rocBLAS/add-gfx1150 branch July 16, 2025 17:18
assistant-librarian Bot added a commit to ROCm/rocBLAS that referenced this pull request Jul 16, 2025
Add gfx1150 support (#452)

- Adding initial support for gfx1150
- Need to update tensile_tag.txt after PR with Tensile changes is merged
in rocm-libraries and automatically in ROCm/Tensile
(ROCm/rocm-libraries#396)

- Update tensile_tag.txt for testing purposes, it will be reverted

---
🔁 Imported from
[#1659](#1659)
🧑‍💻 Originally authored by @amd-mtrifuno

---------

Co-authored-by: Milica Trifunovic <milica.trifunovic@amd.com>
Co-authored-by: assistant-librarian[bot] <assistant-librarian[bot]@users.noreply.github.com>
Co-authored-by: Torre Zuk <42548444+TorreZuk@users.noreply.github.com>
amd-mtrifuno added a commit that referenced this pull request Jul 18, 2025
- Adding initial support for gfx1150
- Need to update tensile_tag.txt after PR with Tensile changes is merged #697

---
🔁 Imported from
[ROCm/rocBLAS#1659](ROCm/rocBLAS#1659)
🧑‍💻 Originally authored by @amd-mtrifuno

---------

Co-authored-by: Milica Trifunovic <milica.trifunovic@amd.com>
Co-authored-by: assistant-librarian[bot] <assistant-librarian[bot]@users.noreply.github.com>
Co-authored-by: Torre Zuk <42548444+TorreZuk@users.noreply.github.com>
Swathi9494 pushed a commit that referenced this pull request Sep 10, 2025
- Adding initial support for gfx1150
- Need to update tensile_tag.txt after PR with Tensile changes is merged #697

---
🔁 Imported from
[ROCm/rocBLAS#1659](ROCm/rocBLAS#1659)
🧑‍💻 Originally authored by @amd-mtrifuno

---------

Co-authored-by: Milica Trifunovic <milica.trifunovic@amd.com>
Co-authored-by: assistant-librarian[bot] <assistant-librarian[bot]@users.noreply.github.com>
Co-authored-by: Torre Zuk <42548444+TorreZuk@users.noreply.github.com>
vamovsik pushed a commit that referenced this pull request Sep 18, 2025
- Adding initial support for gfx1150
- Add Strix Halo yaml files that are copy of Navi33 yaml files (the same
changes added for Strix Point)
- Need to update tensile_tag.txt after PR with Tensile changes is merged
#697

---
🔁 Imported from
[ROCm/rocBLAS#1659](ROCm/rocBLAS#1659) 🧑‍💻
Originally authored by @amd-mtrifuno

---------

---------

Co-authored-by: assistant-librarian[bot] <210906412+assistant-librarian[bot]@users.noreply.github.com>
Co-authored-by: assistant-librarian[bot] <assistant-librarian[bot]@users.noreply.github.com>
Co-authored-by: Torre Zuk <42548444+TorreZuk@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants