Skip to content

[tensile] Add gfx1150 Tensile support#396

Merged
amd-mtrifuno merged 2 commits into
developfrom
import/develop/amd-mtrifuno_tensile/add_gfx1150
Jul 15, 2025
Merged

[tensile] Add gfx1150 Tensile support#396
amd-mtrifuno merged 2 commits into
developfrom
import/develop/amd-mtrifuno_tensile/add_gfx1150

Conversation

@amd-mtrifuno
Copy link
Copy Markdown
Contributor

@amd-mtrifuno amd-mtrifuno commented Jun 26, 2025

@amd-mtrifuno amd-mtrifuno changed the title Add gfx1150 support Add gfx1150 Tensile support Jun 26, 2025
@fjankovi
Copy link
Copy Markdown
Contributor

CC: @lamikr @stellaraccident

TorreZuk
TorreZuk previously approved these changes Jun 27, 2025
Copy link
Copy Markdown
Contributor

@TorreZuk TorreZuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me if all tests pass. Thanks for the significant contribution!
Consumption by rocBLAS may push the envelope toward generics so will see if I can actually get that moving.

babakpst
babakpst previously approved these changes Jun 27, 2025
@amd-mtrifuno amd-mtrifuno dismissed stale reviews from babakpst and TorreZuk via 1482937 July 10, 2025 15:05
Copy link
Copy Markdown
Contributor

@TorreZuk TorreZuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me but needs Tensile team reviews

Comment thread shared/tensile/Tensile/Source/lib/include/Tensile/AMDGPU.hpp
@bstefanuk bstefanuk changed the title Add gfx1150 Tensile support [tensile] Add gfx1150 Tensile support Jul 15, 2025
Copy link
Copy Markdown
Contributor

@bstefanuk bstefanuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TorreZuk TorreZuk requested a review from amd-jnovotny July 15, 2025 18:00
Copy link
Copy Markdown
Contributor

@amd-jnovotny amd-jnovotny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog okay

@amd-mtrifuno amd-mtrifuno merged commit 5db1ccb into develop Jul 15, 2025
7 of 9 checks passed
@amd-mtrifuno amd-mtrifuno deleted the import/develop/amd-mtrifuno_tensile/add_gfx1150 branch July 15, 2025 19:02
assistant-librarian Bot pushed a commit to ROCm/Tensile that referenced this pull request Jul 15, 2025
[tensile] Add gfx1150 Tensile support (#396)

- Adding initial support for gfx1150 in Tensile
amcamd pushed a commit that referenced this pull request Jul 16, 2025
- Adding initial support for gfx1150
- Need to update tensile_tag.txt after PR with Tensile changes is merged
in rocm-libraries and automatically in ROCm/Tensile
(#396)

- Update tensile_tag.txt for testing purposes, it will be reverted



---
🔁 Imported from
[ROCm/rocBLAS#1659](ROCm/rocBLAS#1659)
🧑‍💻 Originally authored by @amd-mtrifuno

---------

Co-authored-by: Milica Trifunovic <milica.trifunovic@amd.com>
Co-authored-by: assistant-librarian[bot] <assistant-librarian[bot]@users.noreply.github.com>
Co-authored-by: Torre Zuk <42548444+TorreZuk@users.noreply.github.com>
assistant-librarian Bot added a commit to ROCm/rocBLAS that referenced this pull request Jul 16, 2025
Add gfx1150 support (#452)

- Adding initial support for gfx1150
- Need to update tensile_tag.txt after PR with Tensile changes is merged
in rocm-libraries and automatically in ROCm/Tensile
(ROCm/rocm-libraries#396)

- Update tensile_tag.txt for testing purposes, it will be reverted

---
🔁 Imported from
[#1659](#1659)
🧑‍💻 Originally authored by @amd-mtrifuno

---------

Co-authored-by: Milica Trifunovic <milica.trifunovic@amd.com>
Co-authored-by: assistant-librarian[bot] <assistant-librarian[bot]@users.noreply.github.com>
Co-authored-by: Torre Zuk <42548444+TorreZuk@users.noreply.github.com>
vamovsik added a commit that referenced this pull request Sep 18, 2025
- Add gfx1150 support

- Add missing changes for gfx1151

---------

Co-authored-by: Val Movsik <160653499+vamovsik@users.noreply.github.com>
ammallya pushed a commit that referenced this pull request Sep 18, 2025
Co-authored-by: Marius Brehler <marius.brehler@amd.com>

[ROCm/hipSOLVER commit: 6c0edf8]
rahulc-gh pushed a commit that referenced this pull request Sep 23, 2025
Co-authored-by: Marius Brehler <marius.brehler@amd.com>

[ROCm/hipsolver commit: 6c0edf8]
ammallya pushed a commit that referenced this pull request Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants