[hipFFTW] Fix checking of aliased_hipfftw_name#4403
Merged
evetsso merged 1 commit intoFeb 12, 2026
Conversation
When variable is unset such statement does not work as intended i.e. if is always false
assistant-librarian
Bot
added
the
external contribution
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (76.83%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #4403 +/- ##
===========================================
- Coverage 65.32% 65.31% -0.01%
===========================================
Files 1579 1579
Lines 242137 242137
Branches 33920 33920
===========================================
- Hits 158163 158149 -14
- Misses 69952 69973 +21
+ Partials 14022 14015 -7
*This pull request uses carry forward flags. Click here to find out more. 🚀 New features to boost your workflow:
|
evetsso
approved these changes
Feb 11, 2026
regan-amd
approved these changes
Feb 12, 2026
assistant-librarian Bot
pushed a commit
to ROCm/hipFFT
that referenced
this pull request
Feb 12, 2026
[hipFFTW] Fix checking of aliased_hipfftw_name ## Motivation This complements ROCm/rocm-libraries#2579 and addresses ROCm/rocm-libraries#2400 ## Technical Details When variable is unset then such statement does not work as intended i.e the if statement is always false and hipfftw stays without so version ## Test Plan N/A ## Test Result N/A ## Submission Checklist - [x] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This complements #2579 and addresses #2400
Technical Details
When variable is unset then such statement does not work as intended i.e the if statement is always false and hipfftw stays without so version
Test Plan
N/A
Test Result
N/A
Submission Checklist