[hipFFTW] Add versioning for hipfftw.so#2579
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## develop #2579 +/- ##
============================================
- Coverage 73.95% 53.80% -20.15%
============================================
Files 365 14 -351
Lines 72116 3768 -68348
Branches 6306 578 -5728
============================================
- Hits 53329 2027 -51302
+ Misses 15028 1511 -13517
+ Partials 3759 230 -3529
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
regan-amd
force-pushed
the
users/regan-amd/hipfftw_versioning
branch
from
e52ed72 to
486f7d1
Compare
regan-amd
force-pushed
the
users/regan-amd/hipfftw_versioning
branch
from
486f7d1 to
dfa828c
Compare
evetsso
approved these changes
Nov 17, 2025
af-ayala
approved these changes
Nov 18, 2025
assistant-librarian Bot
pushed a commit
to ROCm/hipFFT
that referenced
this pull request
Nov 18, 2025
[hipFFTW] Add versioning for hipfftw.so ## Motivation This is suggested to address ROCm/rocm-libraries#2400. ## Technical Details Adding versioning to the hipfftw target. ## Test Plan N/A . ## Test Result N/A ## Submission Checklist - [x] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.
ammallya
pushed a commit
that referenced
this pull request
Feb 3, 2026
* Modify CMakeLists to allow for splitting. * Modify CMakeLists for data and layout logic. * Run tests and get build artifact. * Test new Cmakelists for speedup. * Further improvements for speedup. * turn off the FMHA * turn off the automatic tile engine gemm * minor fix * disable the transpose test first * Address the comment * Jenkinsfile * change the make thread to 64 * change the compile thread to 32 * Try to use with less OS memory space * Have the Unity build batch size to 2 * reduce the chunk size --------- Co-authored-by: Vidyasagar Ananthan <vidyasagar.ananthan@amd.com> [ROCm/composable_kernel commit: e5b79b2]
ammallya
pushed a commit
that referenced
this pull request
Feb 3, 2026
1 task
evetsso
pushed a commit
that referenced
this pull request
Feb 12, 2026
## Motivation This complements #2579 and addresses #2400 ## Technical Details When variable is unset then such statement does not work as intended i.e the if statement is always false and hipfftw stays without so version ## Test Plan N/A ## Test Result N/A ## Submission Checklist - [x] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.
assistant-librarian Bot
pushed a commit
to ROCm/hipFFT
that referenced
this pull request
Feb 12, 2026
[hipFFTW] Fix checking of aliased_hipfftw_name ## Motivation This complements ROCm/rocm-libraries#2579 and addresses ROCm/rocm-libraries#2400 ## Technical Details When variable is unset then such statement does not work as intended i.e the if statement is always false and hipfftw stays without so version ## Test Plan N/A ## Test Result N/A ## Submission Checklist - [x] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.
kamuruga08
pushed a commit
that referenced
this pull request
Feb 19, 2026
## Motivation This complements #2579 and addresses #2400 ## Technical Details When variable is unset then such statement does not work as intended i.e the if statement is always false and hipfftw stays without so version ## Test Plan N/A ## Test Result N/A ## Submission Checklist - [x] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.
kamuruga08
pushed a commit
that referenced
this pull request
Feb 19, 2026
## Motivation This complements #2579 and addresses #2400 ## Technical Details When variable is unset then such statement does not work as intended i.e the if statement is always false and hipfftw stays without so version ## Test Plan N/A ## Test Result N/A ## Submission Checklist - [x] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This is suggested to address #2400.
Technical Details
Adding versioning to the hipfftw target.
Test Plan
N/A .
Test Result
N/A
Submission Checklist