Skip to content

[rocThrust][Code Coverage] Increase Code Coverage#410

Merged
NguyenNhuDi merged 15 commits into
ROCm:developfrom
NguyenNhuDi:zenguyen-rocthrust/code-coverage-develop
Jul 18, 2025
Merged

[rocThrust][Code Coverage] Increase Code Coverage#410
NguyenNhuDi merged 15 commits into
ROCm:developfrom
NguyenNhuDi:zenguyen-rocthrust/code-coverage-develop

Conversation

@NguyenNhuDi
Copy link
Copy Markdown
Contributor

Remaking this PR #174 to merge into develop instead of release-staging branch

@NguyenNhuDi NguyenNhuDi changed the title [rocThrust][Code Coverage] [rocThrust][Code Coverage] Increase Code Coverage Jun 27, 2025
umfranzw
umfranzw previously approved these changes Jul 1, 2025
Copy link
Copy Markdown
Contributor

@umfranzw umfranzw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jul 3, 2025

Codecov Report

Attention: Patch coverage is 88.44324% with 170 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
projects/rocthrust/test/test_complex_various.cpp 86.36% 0 Missing and 90 partials ⚠️
projects/rocthrust/test/test_utils.hpp 42.86% 33 Missing and 3 partials ⚠️
projects/rocthrust/test/test_complex.cpp 93.85% 8 Missing and 15 partials ⚠️
projects/rocthrust/test/test_real_assertions.hpp 60.47% 13 Missing and 4 partials ⚠️
projects/rocthrust/test/test_binary_search.cpp 98.78% 0 Missing and 4 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #410      +/-   ##
===========================================
+ Coverage    79.95%   83.59%   +3.63%     
===========================================
  Files          432      436       +4     
  Lines        36921    37976    +1055     
  Branches      4767     5022     +255     
===========================================
+ Hits         29520    31743    +2223     
+ Misses        3604     2339    -1265     
- Partials      3797     3894      +97     
Flag Coverage Δ
rocThrust 83.53% <88.44%> (+3.58%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ojects/rocthrust/test/test_adjacent_difference.cpp 79.47% <ø> (ø)
projects/rocthrust/test/test_advance.cpp 61.82% <ø> (ø)
projects/rocthrust/test/test_allocator.cpp 75.38% <ø> (ø)
...s/rocthrust/test/test_allocator_aware_policies.cpp 93.62% <ø> (ø)
projects/rocthrust/test/test_async_copy.cpp 92.73% <ø> (ø)
projects/rocthrust/test/test_async_for_each.cpp 96.30% <100.00%> (ø)
projects/rocthrust/test/test_async_reduce.cpp 85.64% <ø> (ø)
projects/rocthrust/test/test_async_scan.cpp 100.00% <ø> (ø)
projects/rocthrust/test/test_async_sort.cpp 96.18% <ø> (ø)
projects/rocthrust/test/test_async_transform.cpp 90.00% <ø> (ø)
... and 113 more

... and 32 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread projects/rocthrust/test/test_complex_various.cpp Outdated
umfranzw
umfranzw previously approved these changes Jul 7, 2025
@NguyenNhuDi NguyenNhuDi dismissed stale reviews from umfranzw and stanleytsang-amd via c3d26f0 July 16, 2025 15:37
@NguyenNhuDi NguyenNhuDi requested a review from a team as a code owner July 16, 2025 15:37
Comment thread projects/rocthrust/CHANGELOG.md Outdated
Comment thread projects/rocthrust/CHANGELOG.md Outdated
Comment thread projects/rocthrust/CHANGELOG.md Outdated
Comment thread projects/rocthrust/CHANGELOG.md Outdated
Comment thread projects/rocthrust/CHANGELOG.md Outdated
NguyenNhuDi and others added 5 commits July 16, 2025 10:38
Co-authored-by: spolifroni-amd <Sandra.Polifroni@amd.com>
Co-authored-by: spolifroni-amd <Sandra.Polifroni@amd.com>
Co-authored-by: spolifroni-amd <Sandra.Polifroni@amd.com>
Co-authored-by: spolifroni-amd <Sandra.Polifroni@amd.com>
Co-authored-by: spolifroni-amd <Sandra.Polifroni@amd.com>
@stanleytsang-amd stanleytsang-amd self-requested a review July 18, 2025 17:01
@NguyenNhuDi NguyenNhuDi merged commit 397dc5e into ROCm:develop Jul 18, 2025
9 of 13 checks passed
assistant-librarian Bot pushed a commit to ROCm/rocThrust that referenced this pull request Jul 18, 2025
[rocThrust][Code Coverage] Increase Code Coverage (#410)

Remaking this PR #174 to merge into develop instead of release-staging
branch

---------

Co-authored-by: spolifroni-amd <Sandra.Polifroni@amd.com>
NguyenNhuDi added a commit to NguyenNhuDi/rocm-libraries that referenced this pull request Jul 18, 2025
Remaking this PR ROCm#174 to merge into develop instead of release-staging
branch

---------

Co-authored-by: spolifroni-amd <Sandra.Polifroni@amd.com>
shahamed pushed a commit that referenced this pull request Jul 19, 2025
Remaking this PR #174 to merge into develop instead of release-staging
branch

---------

Co-authored-by: spolifroni-amd <Sandra.Polifroni@amd.com>
ammallya pushed a commit that referenced this pull request Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants