Skip to content

Fix RoPE for bf16 #3766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BrianHarrisonAMD merged 1 commit into from
Jan 13, 2026
Merged

Fix RoPE for bf16 #3766

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions projects/miopen/src/kernels/MIOpenRoPE.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ __device__ void ropefwdcontiguous(const TI* __restrict__ x,
FLOAT_ACCUM input = CVT_FLOAT2ACCUM(x[gid]);
uint64_t freqs_id = gid % rotary_numel;
FLOAT_ACCUM input_rotate_half =
(gid % 2 == 0) ? CVT_FLOAT2ACCUM(-x[(gid + 1)]) : CVT_FLOAT2ACCUM(x[gid - 1]);
(gid % 2 == 0) ? -CVT_FLOAT2ACCUM(x[(gid + 1)]) : CVT_FLOAT2ACCUM(x[gid - 1]);

FLOAT_ACCUM cos_val = CVT_FLOAT2ACCUM(cos[freqs_id]);
FLOAT_ACCUM sin_val = CVT_FLOAT2ACCUM(sin[freqs_id]);
Expand All @@ -72,7 +72,7 @@ __device__ void ropebwdcontiguous(const TI* __restrict__ dy,

FLOAT_ACCUM output_grad = CVT_FLOAT2ACCUM(dy[gid]);
FLOAT_ACCUM output_grad_rotate_half =
(gid % 2 == 0) ? CVT_FLOAT2ACCUM(dy[(gid + 1)]) : CVT_FLOAT2ACCUM(-dy[(gid - 1)]);
(gid % 2 == 0) ? CVT_FLOAT2ACCUM(dy[(gid + 1)]) : -CVT_FLOAT2ACCUM(dy[(gid - 1)]);

FLOAT_ACCUM cos_val = CVT_FLOAT2ACCUM(cos[freqs_id]);
FLOAT_ACCUM sin_val = (freqs_id % 2 == 0) ? CVT_FLOAT2ACCUM(sin[freqs_id + 1])
Expand Down
Loading