Fix RoPE for bf16#3766
Merged
Merged
Conversation
sbalint98
approved these changes
Jan 12, 2026
assistant-librarian Bot
pushed a commit
to ROCm/MIOpen
that referenced
this pull request
Jan 13, 2026
Fix RoPE for bf16 ## Motivation During ivestigating MIOpen error tolerance #912 , CI failed for RoPE kernels in bf16. ## Technical Details This PR fixes the wrong casting and negating operation order for fwd and bwd RoPE. ## Test Plan All tests pass. For some driver calls, the error got smaller. After the error tolerance fix applied, this kernel will pass the tests too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
During ivestigating MIOpen error tolerance #912 , CI failed for RoPE kernels in bf16.
Technical Details
This PR fixes the wrong casting and negating operation order for fwd and bwd RoPE.
Test Plan
All tests pass. For some driver calls, the error got smaller. After the error tolerance fix applied, this kernel will pass the tests too.