Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions projects/hipcub/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,8 @@ Full documentation for hipCUB is available at [https://rocm.docs.amd.com/project

* Removed the `GenerateResourceSpec.cmake` script - it is replaced by the added `generate_resource_spec.cpp` code mentioned above.

* Removed deprecated `IteratorWrapper::operator<<`, `If`, `IsPointer`, `IsVolatile`, `RemoveQualifiers`.

## hipCUB-4.2.0 for ROCm 7.2

### Resolved issues
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright (c) 2024-2025 Advanced Micro Devices, Inc. All rights reserved.
// Copyright (c) 2024-2026 Advanced Micro Devices, Inc. All rights reserved.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
Expand Down Expand Up @@ -186,14 +186,6 @@ class IteratorWrapper
{
return iterator_ >= other.iterator_;
}

[[deprecated]]
friend std::ostream&
operator<<(std::ostream& os, const DerivedIterator& iter)
{
os << iter.iterator_;
return os;
}
};

} // namespace detail
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/******************************************************************************
* Copyright (c) 2010-2011, Duane Merrill. All rights reserved.
* Copyright (c) 2011-2018, NVIDIA CORPORATION. All rights reserved.
* Modifications Copyright (c) 2021-2025, Advanced Micro Devices, Inc. All rights reserved.
* Modifications Copyright (c) 2021-2026, Advanced Micro Devices, Inc. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions are met:
Expand Down Expand Up @@ -57,30 +57,6 @@ using NullType = ::rocprim::empty_type;
#define HIPCUB_IS_INT128_ENABLED 1
#endif // !defined(HIPCUB_IS_INT128_ENABLED)

template<bool B, typename T, typename F> struct
[[deprecated("[Since 1.16] If is deprecated use std::conditional instead.")]] If
{
using Type = typename std::conditional<B, T, F>::type;
};

template<typename T> struct
[[deprecated("[Since 1.16] IsPointer is deprecated use std::is_pointer instead.")]] IsPointer
{
static constexpr bool VALUE = std::is_pointer<T>::value;
};

template<typename T> struct
[[deprecated("[Since 1.16] IsVolatile is deprecated use std::is_volatile instead.")]] IsVolatile
{
static constexpr bool VALUE = std::is_volatile<T>::value;
};

template<typename T> struct
[[deprecated("[Since 1.16] RemoveQualifiers is deprecated use std::remove_cv instead.")]] RemoveQualifiers
{
using Type = typename std::remove_cv<T>::type;
};

template<int N>
struct PowerOfTwo
{
Expand Down
9 changes: 5 additions & 4 deletions projects/rocprim/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -62,10 +62,6 @@ Full documentation for rocPRIM is available at [https://rocm.docs.amd.com/projec

* Updated config system to pick better fallback configs for untuned GPUs.

### Upcoming changes

* Deprecated the `ROCPRIM_PRINT_ERROR_ONCE` macro.

### Changed

* Changed various APIs with undefined behaviors to abort with a trap instead of printing a runtime error with `ROCPRIM_PRINT_ERROR_ONCE`
Expand All @@ -80,9 +76,14 @@ Full documentation for rocPRIM is available at [https://rocm.docs.amd.com/projec

### Removed

* Removed deprecated `zip_iterator::operator->`, `invoke_result_binary_op_t`.
* Removed unused `equality`, `inequality`, `sum`, `max`, `min` from thread_operator.hpp.
* Removed duplicate `inequality_operator` from binary_op_warpper.hpp

### Upcoming changes

* Deprecated the `ROCPRIM_PRINT_ERROR_ONCE` macro.
Comment thread
amd-jmahovsky marked this conversation as resolved.
Resolved

## rocPRIM 4.2.0 for ROCm 7.2

### Added
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright (c) 2017-2025 Advanced Micro Devices, Inc. All rights reserved.
// Copyright (c) 2017-2026 Advanced Micro Devices, Inc. All rights reserved.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
Expand Down Expand Up @@ -195,15 +195,6 @@ class zip_iterator
return detail::dereference_iterator_tuple<reference>(iterator_tuple_);
}

[[deprecated("This operator is no longer supported and will be removed in the next major "
"release.")]]
ROCPRIM_HOST_DEVICE
inline pointer
operator->() const
{
return &(*(*this));
}

ROCPRIM_HOST_DEVICE
inline reference
operator[](difference_type distance) const
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -388,27 +388,6 @@ using invoke_result = invoke_result_r<void, F, Args...>;
template<class F, class... Args>
using invoke_result_t = typename invoke_result<F, Args...>::type;

/// \brief Utility wrapper around ``invoke_result`` for binary operators.
///
/// \tparam T Input type to the binary operator.
/// \tparam F Type of the binary operator.
template<class T, class F>
struct [[deprecated("To deduce the type of accumulator, use 'rocprim::accumulator_t' "
"instead.")]] invoke_result_binary_op
{
/// \brief The result type of the binary operator.
using type = typename invoke_result<F, T, T>::type;
};

/// \brief Helper type. It is an alias for ``invoke_result_binary_op::type``.
///
/// \tparam T Input type to the binary operator.
/// \tparam F Type of the binary operator.
template<class T, class F>
using invoke_result_binary_op_t
[[deprecated("To deduce the type of accumulator, use 'rocprim::accumulator_t' instead.")]]
= typename invoke_result_binary_op<T, F>::type;

/// \brief The type of intermediate accumulator (according to CCCL)
template<typename Invokable, typename InputT, typename InitT = InputT>
using accumulator_t = ::std::decay_t<invoke_result_t<Invokable, InitT, InputT>>;
Expand Down
6 changes: 6 additions & 0 deletions projects/rocrand/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,12 @@
Documentation for rocRAND is available at
[https://rocm.docs.amd.com/projects/rocRAND/en/latest/](https://rocm.docs.amd.com/projects/rocRAND/en/latest/)

## rocRAND 5.0.0 for ROCm 10.0

### Removed

* Removed `h_scrambled_sobol(32|64)_constants`, `rocrand_h_scrambled_sobol(32|64)_direction_vectors`, `rocrand_h_sobol(32|64)_direction_vectors` from public namespace.

## rocRAND 4.5.0 for ROCm 7.14

### Added
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright (c) 2022-2025 Advanced Micro Devices, Inc. All rights reserved.
// Copyright (c) 2022-2026 Advanced Micro Devices, Inc. All rights reserved.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
Expand Down Expand Up @@ -28,8 +28,12 @@
#define SCRAMBLED_SOBOL_DIM 20000
#endif

namespace rocrand_device
{
namespace detail
{

// clang-format off
[[deprecated("Use 'rocrand_get_scramble_constants32(...)' instead.")]]
static const unsigned int h_scrambled_sobol32_constants[SCRAMBLED_SOBOL_DIM] = {
0xd091bb5c, 0x22ae9ef6, 0xe7e1faee, 0xd5c31f79, 0x2082352c, 0xf807b7df, 0xe9d30005, 0x3895afe1,
0xa1e24bba, 0x4ee4092b, 0x18f86863, 0x8c16a625, 0x474ba8c4, 0x3039cd1a, 0x8c006d5f, 0xfe2d7810,
Expand Down Expand Up @@ -2535,4 +2539,7 @@ static const unsigned int h_scrambled_sobol32_constants[SCRAMBLED_SOBOL_DIM] = {
};
// clang-format on

} // end namespace detail
} // end namespace rocrand_device

#endif // ROCRAND_SCRAMBLED_SOBOL32_CONSTANTS_H_
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright (c) 2023-2025 Advanced Micro Devices, Inc. All rights reserved.
// Copyright (c) 2023-2026 Advanced Micro Devices, Inc. All rights reserved.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
Expand Down Expand Up @@ -26,13 +26,20 @@

#include "rocrand/rocrandapi.h"

namespace rocrand_device
{
namespace detail
{

#ifndef SCRAMBLED_SOBOL_DIM
#define SCRAMBLED_SOBOL_DIM 20000
#endif // SCRAMBLED_SOBOL_DIM
#define SCRAMBLED_SOBOL32_N 640000

extern "C" [[deprecated(
"Use 'rocrand_get_direction_vectors32(...)' instead.")]] ROCRANDAPI const unsigned int
extern "C" ROCRANDAPI const unsigned int
rocrand_h_scrambled_sobol32_direction_vectors[SCRAMBLED_SOBOL32_N];

} // end namespace detail
} // end namespace rocrand_device

#endif // ROCRAND_SCRAMBLED_SOBOL32_PRECOMPUTED_H_
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright (c) 2022-2025 Advanced Micro Devices, Inc. All rights reserved.
// Copyright (c) 2022-2026 Advanced Micro Devices, Inc. All rights reserved.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
Expand Down Expand Up @@ -28,8 +28,12 @@
#define SCRAMBLED_SOBOL_DIM 20000
#endif

namespace rocrand_device
{
namespace detail
{

// clang-format off
[[deprecated("Use 'rocrand_get_scramble_constants64(...)' instead.")]]
static const unsigned long long int h_scrambled_sobol64_constants[SCRAMBLED_SOBOL_DIM] = {
0xd091bb5c22ae9ef6, 0xe7e1faeed5c31f79, 0x2082352cf807b7df, 0xe9d300053895afe1,
0xa1e24bba4ee4092b, 0x18f868638c16a625, 0x474ba8c43039cd1a, 0x8c006d5ffe2d7810,
Expand Down Expand Up @@ -5035,4 +5039,7 @@ static const unsigned long long int h_scrambled_sobol64_constants[SCRAMBLED_SOBO
};
// clang-format on

} // end namespace detail
} // end namespace rocrand_device

#endif // ROCRAND_SCRAMBLED_SOBOL64_CONSTANTS_H_
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright (c) 2023-2025 Advanced Micro Devices, Inc. All rights reserved.
// Copyright (c) 2023-2026 Advanced Micro Devices, Inc. All rights reserved.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
Expand Down Expand Up @@ -31,8 +31,15 @@
#endif // SCRAMBLED_SOBOL_DIM
#define SCRAMBLED_SOBOL64_N 1280000

extern "C" [[deprecated(
"Use 'rocrand_get_direction_vectors64(...)' instead.")]] ROCRANDAPI const unsigned long long
namespace rocrand_device
{
namespace detail
{

extern "C" ROCRANDAPI const unsigned long long
rocrand_h_scrambled_sobol64_direction_vectors[SCRAMBLED_SOBOL64_N];

} // end namespace detail
} // end namespace rocrand_device

#endif // ROCRAND_SCRAMBLED_SOBOL64_PRECOMPUTED_H_
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright (c) 2023-2025 Advanced Micro Devices, Inc. All rights reserved.
// Copyright (c) 2023-2026 Advanced Micro Devices, Inc. All rights reserved.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
Expand Down Expand Up @@ -31,8 +31,14 @@
#endif // SOBOL_DIM
#define SOBOL32_N 640000

extern "C" [[deprecated(
"Use 'rocrand_get_direction_vectors32(...)' instead.")]] ROCRANDAPI const unsigned int
rocrand_h_sobol32_direction_vectors[SOBOL32_N];
namespace rocrand_device
{
namespace detail
{

extern "C" ROCRANDAPI const unsigned int rocrand_h_sobol32_direction_vectors[SOBOL32_N];

} // end namespace detail
} // end namespace rocrand_device

#endif // ROCRAND_SOBOL32_PRECOMPUTED_H_
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright (c) 2023-2025 Advanced Micro Devices, Inc. All rights reserved.
// Copyright (c) 2023-2026 Advanced Micro Devices, Inc. All rights reserved.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
Expand Down Expand Up @@ -31,8 +31,14 @@
#endif // SOBOL_DIM
#define SOBOL64_N 1280000

extern "C" [[deprecated(
"Use 'rocrand_get_direction_vectors64(...)' instead.")]] ROCRANDAPI const unsigned long long
rocrand_h_sobol64_direction_vectors[SOBOL64_N];
namespace rocrand_device
{
namespace detail
{

extern "C" ROCRANDAPI const unsigned long long rocrand_h_sobol64_direction_vectors[SOBOL64_N];

} // end namespace detail
} // end namespace rocrand_device

#endif // ROCRAND_SOBOL64_PRECOMPUTED_H_
12 changes: 6 additions & 6 deletions projects/rocrand/library/src/rng/sobol.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -374,22 +374,22 @@ class sobol_constant_accessor
{
if constexpr(Scrambled)
{
return rocrand_h_scrambled_sobol64_direction_vectors;
return rocrand_device::detail::rocrand_h_scrambled_sobol64_direction_vectors;
}
else
{
return rocrand_h_sobol64_direction_vectors;
return rocrand_device::detail::rocrand_h_sobol64_direction_vectors;
}
}
else
{
if constexpr(Scrambled)
{
return rocrand_h_scrambled_sobol32_direction_vectors;
return rocrand_device::detail::rocrand_h_scrambled_sobol32_direction_vectors;
}
else
{
return rocrand_h_sobol32_direction_vectors;
return rocrand_device::detail::rocrand_h_sobol32_direction_vectors;
}
}
#pragma clang diagnostic pop
Expand Down Expand Up @@ -435,11 +435,11 @@ class sobol_constant_accessor
#pragma clang diagnostic ignored "-Wdeprecated-declarations"
if constexpr(Is64)
{
return h_scrambled_sobol64_constants;
return rocrand_device::detail::h_scrambled_sobol64_constants;
}
else
{
return h_scrambled_sobol32_constants;
return rocrand_device::detail::h_scrambled_sobol32_constants;
}
#pragma clang diagnostic pop
}
Expand Down
Loading
Loading