Skip to content

[rocPRIM][hipCUB] Add minimum version in find_package call for Google Benchmark #2405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
umfranzw merged 1 commit into from
Nov 7, 2025
Merged

[rocPRIM][hipCUB] Add minimum version in find_package call for Google Benchmark #2405

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion projects/hipcub/cmake/Dependencies.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,6 +336,7 @@ if(USER_BUILD_TEST)
endif(USER_BUILD_TEST)

if(USER_BUILD_BENCHMARK)
set(BENCHMARK_VERSION 1.8.0)
if(NOT EXTERNAL_DEPS_FORCE_DOWNLOAD)
find_package(benchmark CONFIG QUIET)
endif()
Expand All @@ -346,7 +347,7 @@ if(USER_BUILD_BENCHMARK)
FetchContent_Declare(
googlebench
GIT_REPOSITORY https://github.com/google/benchmark.git
GIT_TAG v1.8.0
GIT_TAG v${BENCHMARK_VERSION}
)
FetchContent_MakeAvailable(googlebench)
if(NOT TARGET benchmark::benchmark)
Expand Down
5 changes: 3 additions & 2 deletions projects/rocprim/cmake/Dependencies.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,8 +120,9 @@ if(BUILD_TEST)
endif(BUILD_TEST)

if(BUILD_BENCHMARK)
set(BENCHMARK_VERSION 1.8.0)
if(NOT DEPENDENCIES_FORCE_DOWNLOAD)
find_package(benchmark CONFIG QUIET)
find_package(benchmark ${BENCHMARK_VERSION} CONFIG QUIET)
endif()
if(NOT TARGET benchmark::benchmark)
message(STATUS "Google Benchmark not found. Fetching...")
Expand All @@ -130,7 +131,7 @@ if(BUILD_BENCHMARK)
FetchContent_Declare(
googlebench
GIT_REPOSITORY https://github.com/google/benchmark.git
GIT_TAG v1.8.0
GIT_TAG v${BENCHMARK_VERSION}
)
set(HAVE_STD_REGEX ON)
set(RUN_HAVE_STD_REGEX 1)
Expand Down