fix(rocthrust): qualify invocations to thrust::distance to resolve potential ambiguity#191
Merged
stanleytsang-amd merged 3 commits intoJun 13, 2025
Conversation
Naraenda
requested review from
RobsonRLemos,
lawruble13,
stanleytsang-amd and
umfranzw
as code owners
Member
Author
|
@stanleytsang-amd @RobsonRLemos Would be great if this could still fit in 7.0. Should be easy to review too. |
Naraenda
force-pushed
the
fix-thrust-use-of-unqualified-staging
branch
from
1435edd to
a18af27
Compare
stanleytsang-amd
approved these changes
Jun 13, 2025
stanleytsang-amd
merged commit 7a57b88
into
ROCm:release-staging/rocm-rel-7.0
20 of 23 checks passed
assistant-librarian Bot
pushed a commit
to ROCm/rocThrust
that referenced
this pull request
Jun 13, 2025
fix(rocthrust): qualify invocations to thrust::distance to resolve potential ambiguity (#191) Closes ROCm/rocm-libraries#151. This resolves a possible ambiguous call to unqualified `distance()` as described in the issue above. The resolution was a simple search and replace to qualify instances of this call to the rocThrust namespace.
jayhawk-commits
added a commit
that referenced
this pull request
Jun 20, 2025
### Includes the following PRs: - #121 - #122 - #123 - #146 - #191 - #200 --------- Co-authored-by: Mátyás Aradi <matyas@streamhpc.com> Co-authored-by: Alex Voicu <alexandru.voicu@amd.com> Co-authored-by: Ioannis Assiouras <38722728+iassiour@users.noreply.github.com> Co-authored-by: Nara <nara@streamhpc.com> Co-authored-by: Wayne Franz <wayfranz@amd.com>
ammallya
pushed a commit
that referenced
this pull request
Sep 24, 2025
* Test logs * Add tests for TempDirectory * MultiplePluginsNoApplicableEngines * Fix incorrect test_plugin class name * PR feedback * Improve my power level
ammallya
pushed a commit
that referenced
this pull request
Sep 24, 2025
* Test logs * Add tests for TempDirectory * MultiplePluginsNoApplicableEngines * Fix incorrect test_plugin class name * PR feedback * Improve my power level [ROCm/hipDNN commit: 86fbf5e]
evetsso
pushed a commit
to evetsso/rocm-libraries
that referenced
this pull request
Dec 31, 2025
Adds initial TDM support by enabling codegen for DMA descriptor, tensorcnt handling, and a new set of memory instructions tests that use TDM to copy tiles from a larger tensor.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #151.
This resolves a possible ambiguous call to unqualified
distance()as described in the issue above. The resolution was a simple search and replace to qualify instances of this call to the rocThrust namespace.