cmake fix for HIP on Windows#191
Merged
Merged
Conversation
eidenyoshida
approved these changes
Aug 3, 2021
assistant-librarian Bot
pushed a commit
that referenced
this pull request
Jun 13, 2025
fix(rocthrust): qualify invocations to thrust::distance to resolve potential ambiguity (#191) Closes ROCm/rocm-libraries#151. This resolves a possible ambiguous call to unqualified `distance()` as described in the issue above. The resolution was a simple search and replace to qualify instances of this call to the rocThrust namespace.
ammallya
pushed a commit
that referenced
this pull request
Oct 28, 2025
* cmake fix for hip on windows * Moving rocm check to separate file * Removing /opt/rocm reference from windows [ROCm/rocThrust commit: 45a4537]
ammallya
pushed a commit
that referenced
this pull request
Oct 28, 2025
### Includes the following PRs: - #121 - #122 - #123 - #146 - #191 - #200 --------- Co-authored-by: Mátyás Aradi <matyas@streamhpc.com> Co-authored-by: Alex Voicu <alexandru.voicu@amd.com> Co-authored-by: Ioannis Assiouras <38722728+iassiour@users.noreply.github.com> Co-authored-by: Nara <nara@streamhpc.com> Co-authored-by: Wayne Franz <wayfranz@amd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rocThrust now builds with HIP on Windows again, but still preserving the required order for Linux.